Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7ef6812e-5732-e8c7-e796-f568de4eef62@kontron.de>
Date:   Mon, 1 Aug 2022 14:14:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy
Content-Language: en-US
To:     Philippe Schenker <dev@pschenker.ch>,
        Shawn Guo <shawnguo@kernel.org>
Cc:     Peter Chen <peter.chen@kernel.org>, linux-usb@vger.kernel.org,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
        Fabio Estevam <festevam@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        Jacky Bai <ping.bai@nxp.com>, Jun Li <jun.li@nxp.com>
References: <20220722075600.10943-1-dev@pschenker.ch>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20220722075600.10943-1-dev@pschenker.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bytjNkoxZlRiN21nQ3FiSnhudW9KS3hxNG41ekV1NHZRQktKa2VaeHZGRXFU?=
 =?utf-8?B?T2l1T3RIUFIwZlk2SnRLcVNlcS9FRWhRMVV0aXd2ZFYzTGxBa0ZSSmNIeHpN?=
 =?utf-8?B?OHZSbjdIbEFKS21YUE5IUzRhZGlYT25MNURMTnpwV1RuUVREQkFmVlhxZTdY?=
 =?utf-8?B?SlhBaTNWNVdwdzJaYm9GWUNDWTRUY2E1d0xTMHN2R2czZ3hBblpVWHU3eVB4?=
 =?utf-8?B?c0wvV3E4UzJadEFOb0NVNkJjTEtxZlVHdEdRT3J6dTRmdmIwc0w5eXdqWXlU?=
 =?utf-8?B?ZEJYZ0N2Vk51SnBvWUYvTXQwbXZxYm1DK015L0tkMVJMMXpnaEFTYWFIK3M5?=
 =?utf-8?B?NGxsaWdENjVvUU9MLzNZTEdyMGtYNVVPTDB0NWhoOWdQRlcrWXlhWmN5MHp0?=
 =?utf-8?B?VEJ1Tk40bTlseVo2Qkp3WHUxTXlpbG1WYm84all1UWdRU0ZDSkhPd1dlbEdV?=
 =?utf-8?B?Zm5WWVljTHluYkRVVXU5c21WNTd1K1M3VGhpQ1FUWEJvenV2ZG5ybytDOTVp?=
 =?utf-8?B?R3RQbmJWei9MSEZDUmNSQWtOdHRiMENMK2VhUjIzbjlaSXpIOStuR3Z3TzBr?=
 =?utf-8?B?NUt5LzhkQW1SYWZpM0tKWmN1ZktzS1BnR1djblBRWGdBTGh2b01EZkhkeFZF?=
 =?utf-8?B?dy9JejdzZC9Ibk1XYmI3M1BoL0d5bFNZdXoyNEZRamxaZjNQM1ZWSndIaGEr?=
 =?utf-8?B?RmhQR25NekFLLzN2TStiOCtqVkFkQUhFeDQ5cytHRUxER1lEQzUzVmpBQS9S?=
 =?utf-8?B?YkVVekxwVVVRTWwxdTdBcG96QmdyYTYyYk1vbmdvVnk3eHRTemlmTDZZeVBE?=
 =?utf-8?B?eFNNclo5ZXFCaGdzR1E0cTFnUHkrejNMYVNjUVI4VDZEZGU3OHBtMEtYWW8w?=
 =?utf-8?B?SjljejRsS21HcWV4TGxSSVBRWUY5cERuQ01RWStGb3hIWmR3T3BsWFpVTnlQ?=
 =?utf-8?B?a0RWSnBpL3huWlZRWWtSZmVpSDZWNlNva0ZvQ0NzWDUrNUxyanNTQlJCaHo3?=
 =?utf-8?B?R00yaDFQczlhLyttWW1FSytuTnJQS3RUeGlPY2l1Z0JvVmpyUHRTZ3BLM1pN?=
 =?utf-8?B?dFdQVmc2NGh1a0N6L2RrR3M2Zk4xU2tZM21UUDlNb0dnZEtUNU5WR1NRVC9T?=
 =?utf-8?B?cGtablE3T2dTOGwvZkdpbXF5VkQrQ0NBaWlVQVY1ams4aXFqQzVLSTA2Sm83?=
 =?utf-8?B?cGVLTkZjb2FNd0cvWmdoV0dVTDBqZVk1MEluS3czNnZTNHZUZW5oc0RqbFpD?=
 =?utf-8?B?TXlUYjZxWWd2bVNHb2tOWE8vQTFhSEtvVTRFK1NOSzJGbC94ZS80YmdVWUJC?=
 =?utf-8?B?cEV1cW5qTlhjcjB5OTIrN3BoZTJ5SUVCaWt6SmRXR2N2S1RGclVtaE11ZTRQ?=
 =?utf-8?B?TTJyUGtTak4rQytUcTR6TU5UdEZVSGlsT1ZWMjkzUWhGbS8ycEY5Y1BzSDFy?=
 =?utf-8?B?aUJZbGtSaElrTDlXUkM3cEpadVN3RVhCUS9WZEg1a2ZKNFhlREFFeVg3MXRY?=
 =?utf-8?B?eUowc1JmMnJSMFVQWjNZdWFBU1R4QnVwN0Z3SDZTVlhQN3hwRjU1c3pkU0cr?=
 =?utf-8?B?VGFwOVhJVHV6a1Q1L0IrZHRNOEovc243SC96Qm9lTTVFNW8vRXpEWUxDNGRT?=
 =?utf-8?B?MnhUeVZFUUtQQzVxWE5lWFVEM2hOWGFLVlpQT3c4bUVScTFwYndUYlZRd2Fv?=
 =?utf-8?B?Skt2QVAwZXJIZUpmZ2VGU2YraHNKcExKYzhHSFVtNHVFYzBWVUdwelU1Z3Y1?=
 =?utf-8?B?VGRmN3lwM0tZY0tUWXZIRXVQRnhmdVZNNGViYndmVHJSZ09NSjRPMnJjTnlx?=
 =?utf-8?B?QUhpdjBqZjlkNCtpMzA0QUlWNktmREdUc0gvcXp6SG0xVUdBbGhsd3BnK3M3?=
 =?utf-8?B?N1hGYnZFSmIvUzVrYW5qZE00NHdVWEZBK2FOVUZvMk9ENldWbG5yczhwYWRo?=
 =?utf-8?B?MjNCR08xK1lIOVE4aFZONVZDRVhDR2VtcEtnV21DTDZKT2xja0hnUjh4OEgr?=
 =?utf-8?B?aUhxeHIzVmtuZ2xUY0NLam80WDRJVjdqK2gxMDc1Vk5WNWdRZy9jOXhVWTNK?=
 =?utf-8?B?MlY3cjgyMUFCYmtLSko4SzkzSUlzWUpNeFZQQUI5TmxrUkEwdVM2bDNkVVJV?=
 =?utf-8?B?OWd1ZytoMVlqbElMWVdPWVZqM2p3WEF0NU1FT3FpSW9mNGp4dEYvQ3p2Z3di?=
 =?utf-8?B?OWc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 63a271ae-faa7-4664-47bb-08da73b75a97
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 12:14:16.3981
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FzjaQF2vkidwf/9phvSUuLPnIIa2+eWCUTflqlrcvM4XCa2uyJH83tFkJpNQCSl7s1y1YVj1Y/oGSFMY2uwskD8HX5frB8lHTt+nE7X4/QE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1997
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+CC: Li Jun, Jacky Bai, Lucas Stach

Hi Philippe,

Am 22.07.22 um 09:55 schrieb Philippe Schenker:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> The Verdin iMX8M Mini System on Module does not have VBUS signal
> connected on Verdin USB_2 (usbotg2). On Verdin Development board this is
> no problem, as we have connected a USB-Hub that is always connected.
> 
> However, if Verdin USB_2 is desired to be used as a single USB-Host port
> the chipidea driver does not detect if a USB device is plugged into this
> port, due to runtime pm shutting down the PHY.
> 
> Add the power-domain &pgc_otg2 to &usbphynop2 in order to detect
> plugging events and enumerate the usb device.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

I'm probably having the same issue on our hardware. There was a previous
attempt to fix this globally for all the i.MX8MM boards here: [1].

Unfortunately this didn't seem to work as intended in my case (see
discussion for that patch). Looking at your patch I wonder if not having
the vcc-supply for the usbphynop causes problems in my case. Do you
happen to know the effect of adding the regulator here? I don't see this
in any other i.MX8MM board devicetree.

Could you test Li's patch instead of this board specific fix and see if
it works for you? On your hardware, do you have an always-on device on
the usbotg1 port? If yes, does the detection on the usbotg2 port still
work if the usbotg1 port is disabled in the devicetree?

Thanks
Frieder

[1]
https://lore.kernel.org/linux-arm-kernel/f4879eed-79a7-3a1a-8dd0-c1a6ed367f34@kontron.de

> 
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> index eafa88d980b3..197da74837ca 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -737,6 +737,7 @@ &usbphynop1 {
>  };
>  
>  &usbphynop2 {
> +	power-domains = <&pgc_otg2>;
>  	vcc-supply = <&reg_vdd_3v3>;
>  };
>