Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bnode.c
Date:   Mon, 01 Aug 2022 15:23:41 +0200
Message-ID: <3688658.kQq0lBPeGt@opensuse>
In-Reply-To: <20220720154324.8272-1-fmdefrancesco@gmail.com>
References: <20220720154324.8272-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On mercoled=C3=AC 20 luglio 2022 17:43:24 CEST Fabio M. De Francesco wrote:
> kmap() is being deprecated in favor of kmap_local_page().
>=20
> Two main problems with kmap(): (1) It comes with an overhead as mapping
> space is restricted and protected by a global lock for synchronization=20
and
> (2) it also requires global TLB invalidation when the kmap=E2=80=99s pool=
 wraps
> and it might block when the mapping space is fully utilized until a slot
> becomes available.
>=20
> With kmap_local_page() the mappings are per thread, CPU local, can take
> page faults, and can be called from any context (including interrupts).
> It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore,
> the tasks can be preempted and, when they are scheduled to run again, the
> kernel virtual addresses are restored and still valid.
>=20
> Since its use in bnode.c is safe everywhere, it should be preferred.
>=20
> Therefore, replace kmap() with kmap_local_page() in bnode.c. Where
> possible, use the suited standard helpers (memzero_page(), memcpy_page())
> instead of open coding kmap_local_page() plus memset() or memcpy().
>=20
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  fs/hfsplus/bnode.c | 105 +++++++++++++++++++++------------------------
>  1 file changed, 48 insertions(+), 57 deletions(-)

Please drop this patch because I'll send it again in a series of three, one=
=20
per file (bnode.c, bitmap.c, btree.c).

Unfortunately, while working at the last patch (btree.c), I just noticed=20
that I had missed one of the call sites of kmap() in bitmap.c.

Therefore, I'd prefer to send that again in a patchset and find a way to=20
test each of the three of them on a QEMU/KVM x86_32 VM, booting a kernel=20
with HIGHMEM64GB enabled.

Thanks,

=46abio