Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16f688e9-7777-c5f1-0269-f83ed6788831@kontron.de>
Date:   Mon, 1 Aug 2022 15:45:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 2/8] dt-bindings: regulator: pca9450: Allow arbitrary
 regulator names
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Frieder Schrempf <frieder@fris.de>
Cc:     devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Robin Gong <yibin.gong@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Per-Daniel Olsson <perdo@axis.com>,
        Rickard x Andersson <rickaran@axis.com>
References: <20220801131554.116795-1-frieder@fris.de>
 <20220801131554.116795-3-frieder@fris.de> <YufTP621Bsu8HVpP@sirena.org.uk>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <YufTP621Bsu8HVpP@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkw1WmRIWHdlVk55L2JHRTUya2tDQ1UvRmdWbjYvVGhSSWJDdnFneDY2Sm1W?=
 =?utf-8?B?S1hab0FqOTMza0FXWkJEZ2lkZExENXZzQTBSL0xKMittOVdZY05abWJQV2RU?=
 =?utf-8?B?c0hUYk9FU0FrNFZtQW1pWHZHaGhPQnVqSWpsZXNHelhQZ0UwR1o4aTU0WHhD?=
 =?utf-8?B?M2xBdzJGSURUVHVmMXcwUHl6SXE2Y2R0RXpVZzlsU0xLY1NiWTNnSEhJSElL?=
 =?utf-8?B?aCs0eGRsOUMvcEZicXIyQ1EzTWI4aUZUVHlsdDlUeFc0K3N4ZDJDcitsengw?=
 =?utf-8?B?V09ya3dqWGlDS1BvRXVKRnR0czNBeWNuT3pHajBpZm1lcnptVVNFTW1NaGkz?=
 =?utf-8?B?QjcvN1lWeFJZVHEzN29JaUtROG9aVWk5RUxUS2NmY0M4TmpPUlo2ZnVsY1RQ?=
 =?utf-8?B?MHZyekNQcW5leDN1Z0szN3FUSUtyTXdhR2Q2YkFITzlIODM3eXRUYU4yYy9z?=
 =?utf-8?B?UkNxd3V0Q1lYNHFTakF4SW5IRFhsMFQzbzF4K2xreFQvMmpRcTAreThxcWZK?=
 =?utf-8?B?bjhlTFJtU0RiTy9Od0VocDFIQkxHSi95ZCtrWGpDSzZnZHJkemFOaGFXTDBH?=
 =?utf-8?B?bWZ0cldGeWk2aHJocFRRS0srbzNsYk1Nb2hOSUJNRitNZHNZYm5BdzAwRXJo?=
 =?utf-8?B?a1o2YnRsdlB2Sk8vTGovc2NNS2Rpb2tKOGxrbGVYd0M1R0pNeERCTGVUK1dh?=
 =?utf-8?B?Sm5JRUxkbU1VTSsrbHpub1BmTFVFNnNjQ2tZK2ZXMTN0N3NOT3JCMkJuekc5?=
 =?utf-8?B?U2VPSmVPaTVJQXB5Q2RPcEVmTFNuREpiS2c2SWZVSUMrNTYwSXRicnRvcEpG?=
 =?utf-8?B?UVNoeVJLZkhJdXl3UWYxUDhDcGcyRS9lL1ZOYVp6cExvcVR5YTJLVnZlQXdX?=
 =?utf-8?B?VHpCMHA4a2NaL2FLQVNMcDRxN0tpTXMwYXUxMVIxM2VlUlBJaTNjejE3bloy?=
 =?utf-8?B?Z3ppM1Jkem1qNHpJbU85enk4c2ZjL0piS2l3Z3NUdW9kdjNOMzgzMjhSR0RH?=
 =?utf-8?B?NEVGUFNpcWlld0sxSjVKN1YrbHRjVVN2Mi9ZQUZQNktSamIvcHY2aS82clAv?=
 =?utf-8?B?ZSs5ZzNuUmNUNDdKam1YNUJ4SVZUelRjcUlUWktnS216K1BDcXpIa3c5Umpz?=
 =?utf-8?B?YTlYeGI0NTRCU2tMVVl6aUhnY0YrcGsxTlQ4ZDYyajZENjRTTS9NcG1rWGFI?=
 =?utf-8?B?dHpXMERvMUFKYXZZZlNyOHM1VWhwb0l4VlQ5anNTVHhKT0NPT01NR1ZQRDQ4?=
 =?utf-8?B?SWFuUTM4UlVwVjBVNXRtZkhpdlF4M0pmY1RkdGRGUUxwZ0daQWhVWWp5TjRI?=
 =?utf-8?B?M1NRSkVCejlZZ1psUjluQW9sMjlRcTU1QXhHWktoaTdTU29Gem9sSGpNYXJq?=
 =?utf-8?B?eUswdThocjhOUzhIanl4cFVOQ3hvRU9JUitiZkU0ZjIzajR2Z1FmRzA1eWk5?=
 =?utf-8?B?elpzZ09CQm5hVE85cVk5NlQyTFZKbUg4Yis1dWZHSzdlWjJlNElnVjUyN2Vu?=
 =?utf-8?B?TDVEZEs2R285L0t2dWwzaGh6Ym1IWDV0RGtOM1RQcmJiRDBLeDNMcGJScmpL?=
 =?utf-8?B?aGZpY0JOMDl4di9FMHFBNXFGa0ZvbFNhNXM3cXVNRWxYQ3lYTUpLckM4MHdk?=
 =?utf-8?B?VWdULzNJc00zaW9RZFpZMlRhelFrdUJQOVV6bTVnSUJOYmhQSHl4MVlidXph?=
 =?utf-8?B?cnYweEdkM0ZWdWlSNEVxME8wOHZQZWxDcWs1bW5hN3VnWWFMZURXTEVPVm1Y?=
 =?utf-8?B?UXR6bjZjZU1yVWExdTlDNVduUWFkNkdoS3NrMksyK2s5Y2xNemRlcnNTWGNB?=
 =?utf-8?B?OTcvWCt2a2dZNUJmb1NjcWVrdElyZGRkalhhWWRjSVhkVm9QdE9kY3B6dWQr?=
 =?utf-8?B?Y20wYVdmcnRNUlR4cm9QRDlCZEFzR3N5SGVmRzFPd1lyUmpIS1l5VjdCUnlN?=
 =?utf-8?B?UUV3RW12a2hPaUV1SWxEZmtGWDllSFNnVWF3b3N6eWxaTllzMWR3Z3J1MCtZ?=
 =?utf-8?B?c1JJMmxobWNuazNDbC9zQWRYR0pySC9LcTdVVE5MUWZkQTROZnFPVTZrZlRQ?=
 =?utf-8?B?dGNNbDNZdEJHRTZnWC9ienJhZVp0bFV3OUI1SFAwMDhnRkEvRFpIeVlYbFFC?=
 =?utf-8?B?VmExdWRPWFNtemd4UEZ2dk5hL0NLTDk4ZGpJMWFKNGhBVGsreHZqYTBvQ3R2?=
 =?utf-8?B?ZFE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 03d55182-a95d-42d6-5c19-08da73c4271a
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 13:45:53.4263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MX2vpWB0PhQt9QRlqTSLnDJbA8kyIRvSyDGDwQakzFTiFihRQdIXBff2doq4MioVSqPL2cn77O3aCLAR9Tkv+eAgDsNBUEC17USZAfTcUMA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB2318
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 01.08.22 um 15:21 schrieb Mark Brown:
> On Mon, Aug 01, 2022 at 03:15:46PM +0200, Frieder Schrempf wrote:
> 
>>            regulator-name:
>> -            pattern: "^LDO[1-5]$"
>>              description:
>> -              should be "LDO1", ..., "LDO5"
>> +              Should be "LDO1", ..., "LDO5" or whatever the name of the boards
>> +              voltage rail powered by this regulator is.
> 
> This should simply be removed from the bindings for the device, devices
> have no business placing any constraint on this generic binding.

Ok, IIUC something like below should do then. I can change this in the
next iteration of this series or send it separately if the rest of the
set gets accepted as-is.

--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -47,12 +47,6 @@ properties:
         description:
           Properties for single LDO regulator.

-        properties:
-          regulator-name:
-            pattern: "^LDO[1-5]$"
-            description:
-              should be "LDO1", ..., "LDO5"
-
         unevaluatedProperties: false

       "^BUCK[1-6]$":
@@ -62,11 +56,6 @@ properties:
           Properties for single BUCK regulator.

         properties:
-          regulator-name:
-            pattern: "^BUCK[1-6]$"
-            description:
-              should be "BUCK1", ..., "BUCK6"
-
           nxp,dvs-run-voltage:
             $ref: "/schemas/types.yaml#/definitions/uint32"
             minimum: 600000