Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <82620137-5aa5-6cf1-f7aa-6a298e2f7856@oracle.com>
Date:   Mon, 1 Aug 2022 07:59:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>,
        K Prateek Nayak <kprateek.nayak@amd.com>
Cc:     peterz@infradead.org, vincent.guittot@linaro.org, mgorman@suse.de,
        tim.c.chen@linux.intel.com, 21cnbao@gmail.com,
        dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
References: <20220711224704.1672831-1-libo.chen@oracle.com>
 <c50bdbfe-02ce-c1bc-c761-c95f8e216ca0@amd.com> <YufUj4klPKmKNj26@gmail.com>
From:   Libo Chen <libo.chen@oracle.com>
In-Reply-To: <YufUj4klPKmKNj26@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVlLOVdLQjJmM2xUVHpnbkpNZEV1MkhEZVVQRUQ0dnJ5N2JHYUpzY2x6ZXFM?=
 =?utf-8?B?UnlmMjIzMDNYaFZaUkFkQ1hpeFVDTlNWeEV5SExvZGpnWld4eFE0aTUyZ3dR?=
 =?utf-8?B?WUYweXVoNXZFbDVsQ2RhM1h2TlBUdjczd3JPSlMxOU5zQTJDSUhERyt6TlVH?=
 =?utf-8?B?UHFrVUJONlpFM1pCWTBJL3NpVzM4dThZQUw4WkJtUmFhMSt0MkVlS1VWSlhB?=
 =?utf-8?B?TGVvQnlUNXNGRkZUK1hGUVNoQUtMb3ZsV1FydmdCVWFCVmhHSStiVGxCeHcz?=
 =?utf-8?B?TDNUeEFsczFQWkMwcGtkVDBlUzJvOUd4ek52UzhjZENWamZRa255WW9tQkp2?=
 =?utf-8?B?a1V3ZmF5Mk4zdk1NVjc0VW1qMXVxbWhOZ0ZlZThZNWNrUkFaeFpDWHVnMFN5?=
 =?utf-8?B?cHRiR1pROFdlVWJoSERaVnZCdmpvcElwSml5cVUyeDMzSGxUM0JOeGFmS3A2?=
 =?utf-8?B?MEJNRndjZXVweU1KTloxL1dNbE5PUGJ1dmRoRW45WWJqWHVtb2ljb0FOYmRp?=
 =?utf-8?B?ZEk0bS9LU1VPS2RGK2V6RXlmelExZWVDc3VnelQxczdmNi9VaUFJRzRNTTc3?=
 =?utf-8?B?eW8wbk9TUWhnNzVTRFpBOUtYcGU3RGh4cWd6SlIwbHVtckludDcwdXcyektj?=
 =?utf-8?B?SXZtZURpRmtpM2ZSZU5JQnRtVC9JRVI5cUFqak5DdmFOWDByMTNIMGgydGJN?=
 =?utf-8?B?emRzUlJ0djB1QXpyRTBhNWRXZytzaUl0bGJmdkVxVlgzczZPSkE5eUdBZ3Iy?=
 =?utf-8?B?VHU0bmh4cnVtdy9tbVZIL0g3eEx3V1VLYlpJcXZaNmUvMlNOZWJUMlRDRDRy?=
 =?utf-8?B?Wll5ZWhiWmV3a2hUak1YSnhYUDZRZ3UwZXVMY01Jc0Rka2NUbG00Mmh2NGVF?=
 =?utf-8?B?NWlZc29RMGxZMFk2bWxwVTM3UHRQaklORUI1YjlOR285bzdYMktVem5YWGcz?=
 =?utf-8?B?OVo0ZVRqSll1aHJaMVNhUktHTlpjSCt5Ti9KcVJudm9QT0NPZWt2KzlNV3Jv?=
 =?utf-8?B?aHlqNTV1NkkyS3h6ZHZBVmpRQnNta3JjdWl2ZkhubWMzUzZLbVgvdi82ZkFU?=
 =?utf-8?B?WmNEM01GbWozbGtBUVNpZURuTnR1a3NuUThSRWxPMW1HVHo0TlJ6U1JscDMz?=
 =?utf-8?B?c1FxZ3NnSmRUbC9KT3dWQ29KanhtTUJqRENYRUdVMkxNd0NCU3p0aVRkNDB0?=
 =?utf-8?B?cVR4MGVTUWVZTzBoMjJuRHVKL2wyWW1vQXNRTkRCWXozS2lGZTRzK3pyYzdE?=
 =?utf-8?B?ZktscVBLM1ordlRVeGdDWXo1UWlyYVNkWUkwbjlzZ3Nxa2hlYVVyamJZOHJE?=
 =?utf-8?B?T3V2bXVPdHpEdjM1d2JJVytRTGN6aXAwQUlDSHdQaVVpMlMrelB5S3V5bUlk?=
 =?utf-8?B?Rzk3UGdqVktDK1l3MXRwUmZEMzl6cEhUTmUwendlSkcwYWozUjdCT0hMVGFW?=
 =?utf-8?B?T01ZanJLbEp4K0FTa0RBd1F3WkhLL3UxRWNCNTZvaFg3VHRNUU9qcGdFOC83?=
 =?utf-8?B?OG5wSjFuVnI4WnNHVUsyWE5BSlhFZnNVbWlOMFUvN2hkaXdnUmg0WW5zc2hm?=
 =?utf-8?B?WUhKVGcvWUZJVDN5OWdOR3dVSFZOZ0NkZmZUTXIvcCsvNEt1bDROd2lNWmdH?=
 =?utf-8?B?cVRNWlpyZEliTU4rUUx2WmxWV1AveHZwNFZuZE8zeEZyYUNvdUFOWktVdDI0?=
 =?utf-8?B?VENkUW5SWmc3LzBRZC9DK2haQ05hdGk3WTRna1NJTm8vaTBhanI0b2NlTEpO?=
 =?utf-8?B?YWJYYmY4ZnlFUkxmazAwSFA2Y21PVHdPbzhKcXgxb2ZrejlYT05rTFNlblVI?=
 =?utf-8?B?R21takJRUlR6RTBrS2pjK3lROTBwaWdwZ1pXMmlIdksvN3pHYlFhWUlvQm1s?=
 =?utf-8?B?VW81U2NFLzNiTmRzdGFKUFFtQVQ4RncxdlEyRzk3d2QzUVlweEZXM0p3NWQ2?=
 =?utf-8?B?b2JLWVJOeW52ZkdmeU8xL0pIZ1VFODA3Mzd4U05TRHJERTNkeUdCL0FscTZh?=
 =?utf-8?B?bWIybWx5Njc5WVJ1bDZ5WllOVGlQc3d2Q1NtNm83eXg3QlU2Rm1CL1FtbXZI?=
 =?utf-8?B?ODNEc3lzNzNuS2k5aENJakZMdktoTXBjdUE2aHlIM1pXUmJaWS94Yk95WW5H?=
 =?utf-8?B?eE1LNVMrRUw0VzdqcExmY1dTRGRDc3E3bU1hUzlvVnV6UWtkNVhwSjJGNTN3?=
 =?utf-8?B?L2c9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 163e9419-6c2d-450a-9198-08da73ce6ef6
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 14:59:29.0018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YmOHs82Jw784krNcx9/34IoHHFZyDCXk7Kc8HMwo1f8YjaRozyx2PMr545pb9Hsf0NAx6s6b+clAyzE5osZzdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4245
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-01_07,2022-08-01_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208010076
X-Proofpoint-ORIG-GUID: FgQiMOgqN8MI12y3iBt5CikG2POlJO8G
X-Proofpoint-GUID: FgQiMOgqN8MI12y3iBt5CikG2POlJO8G
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/1/22 06:26, Ingo Molnar wrote:
> * K Prateek Nayak <kprateek.nayak@amd.com> wrote:
>
>> Hello Libo and Peter,
>>
>> tl;dr
>>
>> - We observed a major regression with tbench when testing the latest tip
>>    sched/core at:
>>    commit 14b3f2d9ee8d "sched/fair: Disallow sync wakeup from interrupt context"
>>    Reason for the regression are the fewer affine wakeups that leaves the
>>    client farther away from the data it needs to consume next primed in the
>>    waker's LLC.
>>    Such regressions can be expected from tasks that use sockets to communicate
>>    significant amount of data especially on system with multiple LLCs.
>>
>> - Other benchmarks have a comparable behavior to the tip at previous commit
>>    commit : 91caa5ae2424 "sched/core: Fix the bug that task won't enqueue
>>    into core tree when update cookie"
>>
>> I'll leave more details below.
> Mel Gorman also warned about this negative side-effect in:
>
>     Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
>     Date: Fri, 15 Jul 2022 11:07:38 +0100
>     Message-ID: <20220715100738.GD3493@suse.de>
>
>     https://urldefense.com/v3/__https://lore.kernel.org/all/20220715100738.GD3493@suse.de/__;!!ACWV5N9M2RV99hQ!PQsIeuK0UwII-A0xS-B3plepNniNeyw14OJowT1cYL-tnuN99MkWfg9C8P60tVFFrnxj0NEanUmEkA$
?? Mel was talking about a completely different thing, I brought up a 
different patch that I wanted to revert and Mel thought it would hurt 
other workloads which don't benefit from pulling but
as you can see, tbench somehow benefits from it, at least according to 
one metric from one workload.

Libo
> I've reverted this commit (14b3f2d9ee8df3b) for the time being from
> tip:sched/core.
>
> Thanks for the heads-up!
>
> Thanks,
>
> 	Ingo