Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eb1a9b6d-8e43-8d0a-70a5-578af0c0bbfe@virtuozzo.com>
Date:   Mon, 1 Aug 2022 17:44:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] neigh: fix possible DoS due to net iface start/stop
 loop
Content-Language: en-US
To:     David Ahern <dsahern@kernel.org>,
        Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>,
        netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yajun Deng <yajun.deng@linux.dev>,
        Roopa Prabhu <roopa@nvidia.com>, linux-kernel@vger.kernel.org,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Konstantin Khorenko <khorenko@virtuozzo.com>, kernel@openvz.org
References: <20220729103559.215140-1-alexander.mikhalitsyn@virtuozzo.com>
 <20220729103559.215140-2-alexander.mikhalitsyn@virtuozzo.com>
 <09ac06d6-4373-0953-5ed0-ed85ef25c999@kernel.org>
From:   "Denis V. Lunev" <den@virtuozzo.com>
In-Reply-To: <09ac06d6-4373-0953-5ed0-ed85ef25c999@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzhsMDF4YUs2WVQzaHh3NVBLZzNQb29KNVkraUR0bytKbldtNTN4K096ZnVu?=
 =?utf-8?B?Q1JGaS9ITE4wVitkL1gwcHpYM0xwQ3dnZmFHTTNkbmJDR3RCaUFtaWQxeXVD?=
 =?utf-8?B?MG9KZkVrN3BXUFZ5YmZoQzZ4cDR4Y0N5VVRxTGs4VnNzVGhQTklGUEdldyth?=
 =?utf-8?B?THhFVlUyZ09zVkJ5K3pJVzVxb010MlgxMHU2VWFHWXpFUmlxcWpVZ0tUdVVX?=
 =?utf-8?B?MVFmVElud0RSYUt5Q0tKK1p3NytVbytmMTJVTFJCUElqV1M4dks2U0syWFBm?=
 =?utf-8?B?VldvSzVFb1lIMy96dHlwYWVUMmR1dHoyQTlvK3R2Z2dIUWdRa3FsQWlBMVpt?=
 =?utf-8?B?cjFzT2dKOFBWeG95bGY2b1JmeWVvZnFmaEhHU01iTndGVWI5b1lxdnUrRWJY?=
 =?utf-8?B?cm5SQU1IWmdGcDNObGpNVzVJeWs0OElzU1RnaysrVXNlMU5HKzlJOFI2MUlI?=
 =?utf-8?B?c1Ard0ZCSnJvcmdmMXN6WFZSSnJIVDNRUDFuRnUrL09VZE5ybjRrdXEvMjFa?=
 =?utf-8?B?RkZvaGV0c1hOdEtFdkp6dXk2bjNscnlycUdWbEYrMkJCYWNWTVlBVDFYZVBN?=
 =?utf-8?B?ZUQ5R0VtYmR6dHFocnZ6NGk4bTRzVGdoMjJxTTJIWWFDaUc0N0dGcHFiMjBF?=
 =?utf-8?B?ZGZkLzdsU2JQa1NmQ2YwRkJMWHFTWXFpUklNOE9xYVlHd3NycUlQcXBEUG96?=
 =?utf-8?B?dS9nbForQkxlRWxaNjFrOVAzRHRiSGxSZEE1R2JNd1Avbk94dlFiTWxleURa?=
 =?utf-8?B?SFQ5SzNaUzJXRFl3bng3UHh1VlZSc2RIcEJhWnd2MnRlUU9jaFAwL1JGTTBL?=
 =?utf-8?B?dXI4bWEzT09XcDJxMmFmay83a2lNOEt1L3BUMEtyL2htcFlCLzhzNXh3QWsy?=
 =?utf-8?B?bFRNblF2UUg0elpjdzF1dzNRUHAzcFNpY3VtZ2N4b1pJQkdSQzFsczE0NDc3?=
 =?utf-8?B?QmFRQUtIT1ZSNFoyc0RHRHJudmZjNUh6cXl4eTVIb2lYS1hXbmRVMy9VZkJq?=
 =?utf-8?B?Y0NUb0NXVEdkTGF3anl1MGMvQVhMWFNYRHpFMUEySy8wOHBBaWZNOWRabE9q?=
 =?utf-8?B?L2VYRG83akcwR3hubzlJYnQzNVFCWTI3QWIxVTJYMmxScU56eDdYWnhKNmIw?=
 =?utf-8?B?OGdsS2wrZUNkc1l5UFJJSlByWWg3c0praGNiWldKcWZmM1BpNDBuaWVxRFBp?=
 =?utf-8?B?azJ2ZXhSclBPVnVkZDN5Uzc1TWptaWozUmVDYXN5L1JGQnBKTW8zemJRSzkz?=
 =?utf-8?B?bFdWQWlqRktRcHkwWGEyQlpNUG9ndSs3bHFpeGwxQTl1MFZDcTNQK2FXV3B0?=
 =?utf-8?B?OTREQmpVSlQ4MTB3QWw4ZktHTGdRK1FyQWw0MmM4MFFEUkE4ODR0YlJPOGNw?=
 =?utf-8?B?MmppU2dkRi9lWWVlR1pLSjNaak04YlVqTER5d3dTa3FaMWs5UXJna0RaUHRt?=
 =?utf-8?B?U2dQbXMyNFkvZTJmeXNod0ZncnJ3SFd4UnJMY2NUV2dNNzFURlhrNjhzcTRY?=
 =?utf-8?B?R3Iva1pIbkZVZ056blNaTlpDeUQ2RXN1U2NrcjRocm8yd2dCVjVTNE5tUnlu?=
 =?utf-8?B?STdQM0d5OUxiQ1U4blhTT2ZTYStkbldZclhCaDNSMVdURWtkZmg3M1hZRlAx?=
 =?utf-8?B?czY2TXJkd01adGdMUTRzT1ROSXFQWm9JcUJwbS9oSDZzTFRnckJQYzVzRTVs?=
 =?utf-8?B?RlVRd21iUUZCc21MQ0h6Ny9NeFZNTitWVWxGckJQZFd4YWFGNWFwQ3VTYnpD?=
 =?utf-8?B?Q1JtMVN1OUxOUU1ld3dpUkQ3QURka0hjZ2VLbDkxcDNJQVNONnpkS21kYnI1?=
 =?utf-8?B?R25OdGVJWUVtYTdkVkpaUU1MTGVGa1VacVhuc3pERGR6N3BHMDdDVmd0S3dp?=
 =?utf-8?B?OVJRWW9qYXVDZVBVUVFERmx3dFlRTjBVNldUSVk0azZrRkY3RHlCNTgrRkI4?=
 =?utf-8?B?Rk1PSVQ5Ym9XTVRmSnRRa2xGSm04QkI2d3ZFSGFqRWlxN1c5V3UvYTlWL3U0?=
 =?utf-8?B?R3hoSHcvZ3FTTElhR1Myai9BTXhTNFJJUE1lVVVXSzBjZndDa1pmdjFGcUJJ?=
 =?utf-8?B?NGNyZFZ6MHFFOVBRSFUxaWtycHM4M21rN2cxbjJ6MGt4aHI0OVRlTTA5cU5r?=
 =?utf-8?Q?uAL7vZYQFilcxQCTfJ4CKdON5?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 942f442b-7bf7-40ce-8498-08da73d4b278
X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6956.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 15:44:19.3037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0as2+AyW50DJbuXYefxgVK8V2RT+cZsYLPIM6xAeL7oVlQF6qppgOneIiKGdVRVbnY7xNXfWiUorAXXCptQzsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2249
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01.08.2022 17:08, David Ahern wrote:
> On 7/29/22 4:35 AM, Alexander Mikhalitsyn wrote:
>> The patch proposed doing very simple thing. It drops only packets from
> it does 2 things - adds a namespace check and a performance based change
> with the way the list is walked.
I believe no. All items are removed before the patch and
all items are walked after the patch, similar O(n) operation.


>> the same namespace in the pneigh_queue_purge() where network interface
>> state change is detected. This is enough to prevent the problem for the
>> whole node preserving original semantics of the code.
>>
>
>> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
>> index 54625287ee5b..213ec0be800b 100644
>> --- a/net/core/neighbour.c
>> +++ b/net/core/neighbour.c
>> @@ -386,8 +396,7 @@ static int __neigh_ifdown(struct neigh_table *tbl, struct net_device *dev,
>>   	neigh_flush_dev(tbl, dev, skip_perm);
>>   	pneigh_ifdown_and_unlock(tbl, dev);
>>   
>> -	del_timer_sync(&tbl->proxy_timer);
> why are you removing this line too?

Because we have packets in the queue after the purge and they have to be 
processed.
May be we should better do

if (skb_queue_empty(&tbl->proxy_queue))
    del_timer_sync(&tbl->proxy_timer);

after the purge. That could be more correct.

>> -	pneigh_queue_purge(&tbl->proxy_queue);
>> +	pneigh_queue_purge(&tbl->proxy_queue, dev_net(dev));
>>   	return 0;
>>   }
>>