Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 Aug 2022 09:44:43 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jane Chu <jane.chu@oracle.com>, <tony.luck@intel.com>,
        <bp@alien8.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        <linux-edac@vger.kernel.org>, <dan.j.williams@intel.com>,
        <linux-kernel@vger.kernel.org>, <hch@lst.de>,
        <nvdimm@lists.linux.dev>
Subject: RE: [PATCH v5] x86/mce: retrieve poison range from hardware
Message-ID: <62e802fb22f2f_b075294a8@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220730061757.3441537-1-jane.chu@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220730061757.3441537-1-jane.chu@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4JiwrqD1gT947PB/ZdV5zvaK39oJtPZRtcnShDr1I/oX9XgKEw/gHZMiBjm3?=
 =?us-ascii?Q?KZRKQ4j26jxEfWFCNM+o4uK2V1/1w5yGOPQEJjq8+04mro4eksIzphb+9WST?=
 =?us-ascii?Q?eopVxkCqG2/hle/aXpSVCHvcaUk0OGWtfUXWVzjOGSEXvec9u67xjnDrodwo?=
 =?us-ascii?Q?ZGEcwkqhWzBSiXsEWADjk7IJLNf6auvkIcct8wlXKq3GvzBnKTqnT2T/4Jty?=
 =?us-ascii?Q?LRHrD0UGPD95UKIBp+cL+s5rHHXwpojvVXcqWjy8yJdR1PjIKM0t5NY8vJZ1?=
 =?us-ascii?Q?Pu+A8aDYkBeEiMXYaF+9cv1QkuNWvgnGt5GIAZGr1PEkF4KYp0vyJCjv6As0?=
 =?us-ascii?Q?qJDJCfdBmltZ0FkgN9TqNokoFT5BrE34HXUtsudSAsQYP+hSe+oIdiP1RQDi?=
 =?us-ascii?Q?Ue6V+mU0bdm3CuWlJgphFIBu8gOZTWFCdSfOGuUMJG+FhU4mwJY7eUOTuyHK?=
 =?us-ascii?Q?G2B0Xyj+PsgqE0/md1/Axm0SyLWPKup7+yN4ckxb5JhEefgNCoOkQGjI+zpR?=
 =?us-ascii?Q?VnPXr6kEzfI3snveBpeiLuDHuvekigw3XsuimsiuQnT71O4z4PIhX4zg1pOd?=
 =?us-ascii?Q?SQEbPUhUpjwys4L5Bd1VOPjCYY1bLgQtprxhJMjjAnPwpOVwfp2UC705YYLn?=
 =?us-ascii?Q?pOV5E32DgzRk4xu8eShiCFTWnAydGSBVDHbVhnHLOfIamiAgn4lgUK4eOdc5?=
 =?us-ascii?Q?0J9Z8GKDkOqXd+QldXRmBBp3XjvH+q0J1xInzK9PATol78bWA9CXKfksaN7z?=
 =?us-ascii?Q?oTCdxNgnqClF96yU4bAJ+5WDhpBOupxNXf4PLrS492RWw+FAS4ehp9dEuQuW?=
 =?us-ascii?Q?vyxq+YQrbVOnKO9beWu5kfOmuKIlHtbAeYYMDPpPPdRyEytL0xIncE9o2eXt?=
 =?us-ascii?Q?zHSuBwKXEmlviwCf1gsMKZUQu4KpqhsrVlU//cxWmfLzut4mPwAmR5sx9f0m?=
 =?us-ascii?Q?KGQqKKCcQ0TJXKUomqxXZzZYQTH3DzorSxlW8lQYFbK3+9Vr8F7AYCIzhJKS?=
 =?us-ascii?Q?SZexeIhaNZA2VXhKo2H6MylcOBBuQhSxpE3qjFFMxZRz/HBX+fkgrgpaVuHK?=
 =?us-ascii?Q?dZC55ojUnGZdHfKVHh1RBQuJkpnbWfFYvJUUP3v4ST394cO/RFwFCNw1ZhD6?=
 =?us-ascii?Q?rIZ/YS8JY3nkLAPwx79YZqv7fN+sdsCydz8VdrOUInmMB4BCIg4AktcJq5ul?=
 =?us-ascii?Q?KvnSKWOj4orCyZmquV/QkQc2CwG0lKL+ROc+WQHae1OyJtGUj2dM0e/lX0SX?=
 =?us-ascii?Q?gGxVOX6L7FOfXhdv17rFZe9qQgDzj9tYg/2YDCSP8OveC8mt78jHvVVRZoBA?=
 =?us-ascii?Q?FgMd1Cz1LDZzm2etbwIAr8+2QnNhhvYmwY+/gsGAfiHHqjc4pwm/34Az9bEM?=
 =?us-ascii?Q?Vb2cEP9RGL+S6s/B+FD2Qc3c/eTKSV87HfdJK0D8ehC1ETcaoZxC9p08KZrF?=
 =?us-ascii?Q?ezMX/ovJcn6bJkwVlKeVBCkdYe2TIqtHXBbi6buQ3mWBZlTgm7JhzE+TpFlR?=
 =?us-ascii?Q?BjTe1jGWB3RaXeJdAIBdGUNB2aHMSjqYyV3WUO7xsfczeQsvPB4AqH2L4DMB?=
 =?us-ascii?Q?L1qXxuE9GSVpSIycCtUJ/w4R0JvnNzYLFVo+B4frnCloyMdbvvTqcLyGXBTK?=
 =?us-ascii?Q?9A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9acbaee8-b74d-47a1-0e75-08da73dd246b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 16:44:46.4183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYfh6QV4M/AeKBT6kHR0agRPH2Sii0mNx5ceitcATYxc9iP0SzaxoJrbFOY1XmmFw/2vq53KES8m/zR1Lft7IRNH5WmKC0ok9Q8JY9jpCGM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4122
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jane Chu wrote:
> With Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine
> poison granularity") that changed nfit_handle_mce() callback to report
> badrange according to 1ULL << MCI_MISC_ADDR_LSB(mce->misc), it's been
> discovered that the mce->misc LSB field is 0x1000 bytes, hence injecting
> 2 back-to-back poisons and the driver ends up logging 8 badblocks,
> because 0x1000 bytes is 8 512-byte.
> 
> Dan Williams noticed that apei_mce_report_mem_error() hardcode
> the LSB field to PAGE_SHIFT instead of consulting the input
> struct cper_sec_mem_err record.  So change to rely on hardware whenever
> support is available.
> 
> Link: https://lore.kernel.org/r/7ed50fd8-521e-cade-77b1-738b8bfb8502@oracle.com
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> ---
>  arch/x86/kernel/cpu/mce/apei.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/apei.c b/arch/x86/kernel/cpu/mce/apei.c
> index 717192915f28..2c7ea0ba9dd7 100644
> --- a/arch/x86/kernel/cpu/mce/apei.c
> +++ b/arch/x86/kernel/cpu/mce/apei.c
> @@ -29,15 +29,27 @@
>  void apei_mce_report_mem_error(int severity, struct cper_sec_mem_err *mem_err)
>  {
>  	struct mce m;
> +	int lsb = PAGE_SHIFT;
>  
>  	if (!(mem_err->validation_bits & CPER_MEM_VALID_PA))
>  		return;
>  
> +	/*
> +	 * Even if the ->validation_bits are set for address mask,
> +	 * to be extra safe, check and reject an error radius '0',
> +	 * and fallback to the default page size.
> +	 */
> +	if (mem_err->validation_bits & CPER_MEM_VALID_PA_MASK) {
> +		lsb = __ffs64(mem_err->physical_addr_mask);
> +		if (lsb == 1)

This was the reason I recommended hweight64 and min_not_zero() as
hweight64 does not have the undefined behavior. However, an even better
option is to just do:

    find_first_bit(&mem_err->physical_addr_mask, PAGE_SHIFT)

...as that trims the result to the PAGE_SHIFT max and handles the zero
case.