Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2109067imn; Mon, 1 Aug 2022 11:24:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vE6d0WOCAinGplPQtZspEm7BMmfv4tbhh25kbv+pMFnWjgBEtZkNl91jInzzokjBkp+mS6 X-Received: by 2002:a05:6402:4381:b0:43b:cb55:ae3c with SMTP id o1-20020a056402438100b0043bcb55ae3cmr16789635edc.45.1659378266082; Mon, 01 Aug 2022 11:24:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659378266; cv=none; d=google.com; s=arc-20160816; b=E9uwiqCT2+cWXekGbFwfLiuGkKnpFZf7cRVdfBd3D9wXzLVuIXdi3YL03GouJSnd3M N8HJ/zhgkX1dB4pXNHZYZd4qRe+etqe5gxQ09cIwxseBLm9AlKh/fzrwpz6geB4pg1mC NiTFzKXbXH/dikLQ0T7EHPPlU8EKUfYOfgHpMEwmfJ/2qyva+SgFjoIaGc0gbwSLXAWf l/kXeVWWzDjvnYPrJkRZE0gL022lBOTKSP9SjdUdn9IByYDpS0Dah9SF8RmhwsEpUk4X wXNQz2T3mwqWYR6NPbwnDqxgVvPzNh2o4ex6e3r8Sir3ASWs2yRs+AsucpVMfvCUFgwD XgnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5eI4oBHRscjr08ZHNzQwOqsOD+3+F4rjZrnwT2lhjk8=; b=jD+tJ2tQdmFqNpgBizxODKZUTqBzwJpWE/HmZgcu6XADrDB4qq13mHcO3twKwzxjiD 6wnKvc3h0Vr5VKGgQBoB6OQdSZ4heDDr7ZLHMOWdmVU/6GGvJ2FiBbBS/KmY48T3eK8M FMZV2wJMZPawnflmVW0kpsydssqniau4E7SyejV5E/7MqYEPTgsgRp57r0v3uRaMqGPj gUjMfsqEmZ8CjJiMU9kxP5Z2cBqI9CgYaTwIJcOE5bzarOOznfXjTrEZ3ILlbHQMnLZn by9AMr5dW7S603V+FkhxzshpW/FH19tPerMSh7r7/T7DrG+/zUgVUpWhff/oz11CsuLG 6OZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cloudflare.com header.s=google header.b=uLJivFt0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cloudflare.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd39-20020a17090796a700b007304b932357si7794397ejc.783.2022.08.01.11.23.53; Mon, 01 Aug 2022 11:24:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cloudflare.com header.s=google header.b=uLJivFt0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cloudflare.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234046AbiHASCh (ORCPT + 99 others); Mon, 1 Aug 2022 14:02:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233976AbiHASCV (ORCPT ); Mon, 1 Aug 2022 14:02:21 -0400 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8287027FC2 for ; Mon, 1 Aug 2022 11:02:19 -0700 (PDT) Received: by mail-oo1-xc2a.google.com with SMTP id d12-20020a4aeb8c000000b004214e709b72so2157290ooj.6 for ; Mon, 01 Aug 2022 11:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=5eI4oBHRscjr08ZHNzQwOqsOD+3+F4rjZrnwT2lhjk8=; b=uLJivFt0JrijlTz4WiJCVuEF8oDRzf5Y7+H6eH45jC4nOYPshmi66MEhwrgCTE8YjQ yODopqvVSRyhcT85GJMk/fAiiPPldOdUR5F7OuR5KoOm4IRWjSJfjRi8lsTM6R3QM+QD UTvK9WXbkNelJtyCDqvAY/Rpe445Qz2Gi9NSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=5eI4oBHRscjr08ZHNzQwOqsOD+3+F4rjZrnwT2lhjk8=; b=59sp50ppMaJSYKeEGMWTsgPBOfEp1WDFX5A7t3dD60txsr5OM4na5NpHb/AVQSQemD PnY5NJJJvLg4jk9xuxRVavEihUDOXuA1MjgkEVj7tPvXaMxJkk57Y9SXL1sALkbIGYZx /O2ljgo0sdnMGPBfTOhvYddKjvzX7Wfa0y1QUB93KraWDpC1G4nQiIjsrBCMgW6nuHx1 wsnXHoRGh82EUr/1cJmHs36KOup+mRmZaCdr27LaW+Hw1vKwThWAOoBtMz3kAJo0fCIp mAGFi1lAM47Ld23D3cinRfC8aF7Zyinlpw++TalunkShwFkMvkiaxR+zRoKaf5UnYosY Qi2w== X-Gm-Message-State: AJIora+ChmewSAkCpsjs4n5RcZbGMuesN6vD9q6mhiR8MmBv2a4n3YgH ZYU0ZbKaWQBycaJc4w2i6iUh0Q== X-Received: by 2002:a4a:e7d8:0:b0:435:9a05:58b5 with SMTP id y24-20020a4ae7d8000000b004359a0558b5mr5600538oov.54.1659376938810; Mon, 01 Aug 2022 11:02:18 -0700 (PDT) Received: from localhost.localdomain ([184.4.90.121]) by smtp.gmail.com with ESMTPSA id n14-20020a9d64ce000000b00618fa37308csm2881348otl.35.2022.08.01.11.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 11:02:18 -0700 (PDT) From: Frederick Lawler To: kpsingh@kernel.org, revest@chromium.org, jackmanb@chromium.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, jmorris@namei.org, serge@hallyn.com, paul@paul-moore.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, shuah@kernel.org, brauner@kernel.org, casey@schaufler-ca.com, ebiederm@xmission.com, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-team@cloudflare.com, cgzones@googlemail.com, karl@bigbadwolfsecurity.com, Frederick Lawler Subject: [PATCH v4 2/4] bpf-lsm: Make bpf_lsm_userns_create() sleepable Date: Mon, 1 Aug 2022 13:01:44 -0500 Message-Id: <20220801180146.1157914-3-fred@cloudflare.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220801180146.1157914-1-fred@cloudflare.com> References: <20220801180146.1157914-1-fred@cloudflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Users may want to audit calls to security_create_user_ns() and access user space memory. Also create_user_ns() runs without pagefault_disabled(). Therefore, make bpf_lsm_userns_create() sleepable for mandatory access control policies. Signed-off-by: Frederick Lawler Acked-by: Christian Brauner (Microsoft) --- Changes since v3: - None Changes since v2: - Rename create_user_ns hook to userns_create Changes since v1: - None --- kernel/bpf/bpf_lsm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c index c1351df9f7ee..4593437809cc 100644 --- a/kernel/bpf/bpf_lsm.c +++ b/kernel/bpf/bpf_lsm.c @@ -250,6 +250,7 @@ BTF_ID(func, bpf_lsm_task_getsecid_obj) BTF_ID(func, bpf_lsm_task_prctl) BTF_ID(func, bpf_lsm_task_setscheduler) BTF_ID(func, bpf_lsm_task_to_inode) +BTF_ID(func, bpf_lsm_userns_create) BTF_SET_END(sleepable_lsm_hooks) bool bpf_lsm_is_sleepable_hook(u32 btf_id) -- 2.30.2