Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2146775imn; Mon, 1 Aug 2022 12:57:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR5iZc92hHIcSyBGRpbKsFLcXQbTcb3hdLlNPS072qaw/VMgU2UQ9EGwFcUfkMls3QuD5+Bb X-Received: by 2002:a62:1d86:0:b0:52d:9df0:2151 with SMTP id d128-20020a621d86000000b0052d9df02151mr3781579pfd.33.1659383862205; Mon, 01 Aug 2022 12:57:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659383862; cv=none; d=google.com; s=arc-20160816; b=HCquaWFs95RQi66TGvqtt10N7lIebSHuvGyY25rLO33SSkil+aRjgZEi2E50Z4A/PD 0SBCcokVhb2EFkkUaeDRcILcEmt40M3l6qi2vn14y3FzKQhCCWEuMIPJsX7shy+LypRY PqetuUzph67hPuGPWDrmAacsK5mgP6qmzb88Pkkc4iSy9VhxTgrqFjs4QYjErnQRDKZB IqADe3fuV/AVvBbSB7J5vuYfzoUvNK7ShV5lN2G8kbF91/wzg3G98yk0SbxZ2OObOvJN Cgo2c9dgKMwHA6KhSoXhx5xvb5di07Mp4FRzXTYGP95iu2hq96t5quJaGeeqAeKG5+/2 SlKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bGjskr4jc06IECP9MU1v2AO4lgVFnVsXijFYG9OY3F0=; b=xrHOcE0S8MCGZcm9wl5cPm0fjEQsQSH2gL3pt/IiOs5CYMebjAZx9GD0wWrJDfxzbx wmrPx+pS0IWl9X8xO0uX8SDoHofPGtostKbYQCgsMHyhQbes6JeGqFlDJ3ESCxpQGJG3 boRj97n7Ti24hX0k1JS5uSAMZ8PLjv/+mp9xojdS9XTLGPdr244zY+wN9H6myfivTNdm zSONy2VHM74OLRd3eLU1Lp+HiB95vKJXAqK7O1/GVXYtQHsRErqe81h2qeCmYR9eZnIy /t3S2JWo2aj3ZnOln3XyMylypT4iATanu/GJ0nTy20H+xcTGVU53RU8XSx2WN+wmPScj 6mqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw7-20020a17090b180700b001f50c96fe7bsi2750234pjb.62.2022.08.01.12.57.28; Mon, 01 Aug 2022 12:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233626AbiHAT2R (ORCPT + 99 others); Mon, 1 Aug 2022 15:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbiHAT2Q (ORCPT ); Mon, 1 Aug 2022 15:28:16 -0400 Received: from smtp.smtpout.orange.fr (smtp04.smtpout.orange.fr [80.12.242.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACB74B71 for ; Mon, 1 Aug 2022 12:28:13 -0700 (PDT) Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id Ib5Fo6JKAGWJJIb5FoUmw3; Mon, 01 Aug 2022 21:28:11 +0200 X-ME-Helo: pop-os.home X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 01 Aug 2022 21:28:11 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Huacai Chen , Jiaxun Yang , Thomas Gleixner , Marc Zyngier , Jianmin Lv Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-mips@vger.kernel.org Subject: [PATCH] irqchip/loongson-liointc: Fix an error handling path in liointc_init() Date: Mon, 1 Aug 2022 21:28:07 +0200 Message-Id: <1a6d74ab70712279023aa7bdbd31bd3aec103bc0.1659382063.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All errors lead to the error handling path, except this one. Fix it and release some resources before returning if this test fails. Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support") Signed-off-by: Christophe JAILLET --- drivers/irqchip/irq-loongson-liointc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c index c4f3c886ad61..8ab59b658913 100644 --- a/drivers/irqchip/irq-loongson-liointc.c +++ b/drivers/irqchip/irq-loongson-liointc.c @@ -207,7 +207,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision, "reg-names", core_reg_names[i]); if (index < 0) - return -EINVAL; + goto out_iounmap; priv->core_isr[i] = of_iomap(node, index); } -- 2.34.1