Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2147037imn; Mon, 1 Aug 2022 12:58:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t7822MyQMhLYbiJAoN/oWZrqoDL/yxd75FoskwQnf9bdrf/RmKpt9IaJ+QTir5sYCVR125 X-Received: by 2002:a17:907:760f:b0:72b:7eb4:be52 with SMTP id jx15-20020a170907760f00b0072b7eb4be52mr13287227ejc.737.1659383908485; Mon, 01 Aug 2022 12:58:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659383908; cv=none; d=google.com; s=arc-20160816; b=phor5FUBRnxbeM9hfBN6rcwZEZ/CpZO4E+Ql2bNhNYbYO39Ju2yIJwGzYQcS1B0Oin ke0ret1PEdfobjzyztk8WJRoIC4VPMt/YGib4boNpfllBqSitnZF/d+7Z0+O2eNZHrz7 DO5NFHFzyspSi5b+qf8i2vsVvQkzyKZXysPUbedLuSmyURpllFUpfjL5ehKff4IDgkwW kq9slys4lgjRv3JwJx521WsGzIOeiNAOIf5ZazKmIFuRBBNBUvFaKHXqZ+HgRcPxw3/h XTVSX0ux07+9SFlr+VPzcs9h5NaZiq6CV560ghi1OSdTZMX7b3veBJ0dP8cgPPQpr7G6 pxPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=PuaNloEeCj0TSViaHfK/6w16ljNPoPu5wE2eWOfMABk=; b=WmC2LqmqZ5ZsQFTEjRGUwkTmSUEU7NhApQgtw8yYHEeTHXTjf3vToqdpp/GlTRf+MJ m46iagpXY9hnJmqmxE7DjiS1kazezYKk8EVQno4XNgoHhzjhFMX7dCZ+Y492/Er1AC6Z +GvYjV3zKX1k6HLJDePbvG5p8KzT5X6tZ5V16XP7JgR94Gc0tdvpSRpu8/rM55cw+m96 oOlfG83aeN0lxtFEoVjPvR9b1Irj5qY2SCuo5AHdOulih2oPwgkCyQVLznlyEt5xPQgN Vwcm4rBAcsrRtNRMi1L5AdQWGUFLxrkv5ZI721GQh7pZZcjpICkxeIkXGt2ARsaqizq7 ZoWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a8nYQ2BH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rh16-20020a17090720f000b007122fed3491si11954653ejb.909.2022.08.01.12.58.03; Mon, 01 Aug 2022 12:58:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a8nYQ2BH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235159AbiHATu2 (ORCPT + 99 others); Mon, 1 Aug 2022 15:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235078AbiHATuR (ORCPT ); Mon, 1 Aug 2022 15:50:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C16F16166; Mon, 1 Aug 2022 12:50:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F24DB8167E; Mon, 1 Aug 2022 19:50:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 31F3CC43143; Mon, 1 Aug 2022 19:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659383414; bh=rUk41rIcjmeKzxxqdvWaLeWaI4ZzRkKxx75eQxlOa5U=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=a8nYQ2BHFnR8iuakQGaswLu5h9GVeePqQL5EWKwBoLs3ybnliYQNQrVwp1udKOkig 6EDBJ2NcXV8oOs+AJpO5VoklVRGzn6G9MnCUndlfyzCNFgT5CDjBA4vmxUd8DVl1e9 e/3ztnOcwVmejhh+3H0RPZIvWMZ/FvnPld1GXSSye1ANaQZF4dXaE1+nRknMn7FKG+ i+6AywG8nzZcPdAszUzJ28ywCs4O0JM7G3CfUSpKttREfYTLfB5qKa8eWOSXEm+3/I t482cKfLdofN0B0jnfwkCL4NQPVmu+Bs6iY0x8lsMGgSc5IRR/7+gi7WhsLhvx5TBU usNv9RfBdl/eg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 1B306C43140; Mon, 1 Aug 2022 19:50:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: devlink: Fix missing mutex_unlock() call From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165938341410.9721.7137509933783048344.git-patchwork-notify@kernel.org> Date: Mon, 01 Aug 2022 19:50:14 +0000 References: <20220801115742.1309329-1-ammar.faizi@intel.com> In-Reply-To: <20220801115742.1309329-1-ammar.faizi@intel.com> To: Ammar Faizi Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lkp@intel.com, dan.carpenter@oracle.com, moshe@nvidia.com, jiri@nvidia.com, fernandafmr12@gnuweeb.org, netdev@vger.kernel.org, gwml@vger.gnuweeb.org, linux-kernel@vger.kernel.org, kbuild@lists.01.org, kbuild-all@lists.01.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Mon, 1 Aug 2022 18:59:56 +0700 you wrote: > From: Ammar Faizi > > Commit 2dec18ad826f forgets to call mutex_unlock() before the function > returns in the error path: > > New smatch warnings: > net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \ > returns '®ion->snapshot_lock'. > > [...] Here is the summary with links: - net: devlink: Fix missing mutex_unlock() call https://git.kernel.org/netdev/net-next/c/80ef928643c1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html