Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751110AbXFFTa3 (ORCPT ); Wed, 6 Jun 2007 15:30:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757499AbXFFTaG (ORCPT ); Wed, 6 Jun 2007 15:30:06 -0400 Received: from brick.kernel.dk ([80.160.20.94]:5067 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbXFFTaF (ORCPT ); Wed, 6 Jun 2007 15:30:05 -0400 Date: Wed, 6 Jun 2007 21:36:48 +0200 From: Jens Axboe To: Takashi Iwai Cc: Jan Engelhardt , Andrew Morton , Uwe Bugla , linux-kernel@vger.kernel.org, Jaroslav Kysela , Mauro Carvalho Chehab Subject: Re: BUG in 2.6.22-rc2-mm1: Parts of Alsa sound architecture broken Message-ID: <20070606193647.GF4735@kernel.dk> References: <20070525102806.77ee9c0c.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2337 Lines: 52 On Tue, Jun 05 2007, Takashi Iwai wrote: > At Tue, 5 Jun 2007 15:25:07 +0200 (MEST), > Jan Engelhardt wrote: > > > > > > >> > >Well, I find the change of CONFIG_SND to menuconfig is fine, too. > > >> > >But CONFIG_SND_PCI_DRIVERS and others don't make much sense to me. > > >> > >How is it useful at all? > > >> > > > >> > Hah, I just tell you some of my own experience. > > >> > In summer 2003, I bought the last new machine, and it got these > > >> > shiny new ports they like to call USB. :) > > >> > I did not have much use for it, but I left it on - you never know > > >> > what standard next is the big win of the decade. And actually, > > >> > it did not took long (well, summer 2005) to get my first USB device. > > >> > Still, I am hell as sure I do not have USB-based sound devices > > >> > anytime soon, so it would be cool to deactivate the whole usbsound > > >> > menu at once. I think I said that in the patch description, did not I? > > >> > > >> But it's not cool to add an extra config item just for that, too. > > >> And, the structure of menuconfig-if-endif is uglier than menu-endmenu. > > >> That's why I feel a bit uneasy, although all these are a matter of > > >> taste... > > > > > >Forgot to mention about another annoying drawback. Because of the new > > >CONFIG_SND_*_DRIVERS, you'll have to re-select all belonging > > >CONFIG_SND_*, even via config oldconfig. Putting the dependency on > > >the top seems to reset the values defined in the old .config. > > > > Well, *I* (previously) submitted patches with "default y", but Jens > > Axboe [http://lkml.org/lkml/2007/5/12/164] disagreed heavily enough to > > stop that practice. > > Hm, I guess Jens didn't know about this side-effect. > > When I don't set "default y", I'll be asked for each belonging item > even though I chose "y" manually for the top config > (CONFIG_*_DRIVERS). > > Strangely, setting "default y" has no this effect... That sounds like a bug in the kconfig system. I still think default y is an *awful* idea, but you can read why in the thread referenced above. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/