Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 Aug 2022 17:08:06 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [for-next][PATCH 21/21] tracing: Use a struct alignof to
 determine trace event field alignment
Message-ID: <20220801170806.061e1268@gandalf.local.home>
In-Reply-To: <a7d202457150472588df0bd3b7334b3f@AcuMS.aculab.com>
References: <20220731190329.641602282@goodmis.org>
        <20220731190435.611455708@goodmis.org>
        <a7d202457150472588df0bd3b7334b3f@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 1 Aug 2022 07:46:22 +0000
David Laight <David.Laight@ACULAB.COM> wrote:

> > Define a macro as:
> > 
> >    ALIGN_STRUCTFIELD(type) ((int)(offsetof(struct {char a; type b;}, b)))
> > 
> > which gives the actual alignment of types in a structure.  
> 
> The simpler:
> 	__alignof__(struct {type b;})
> also works.

I'll have to try that out.

For now, as the previous version made it through all my tests, I may be
pushing it, but change it to this for simplicity if that also works and
passes all my test.

Thanks,

-- Steve