Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2192481imn; Mon, 1 Aug 2022 14:48:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR5408XWuhkqJNk4nJQijKoO2sA0PZu9gEOzIvmkGAtGrR0oYzz92JdWRBi7VB7xQsZFxZTk X-Received: by 2002:a17:906:9b0a:b0:730:9d82:5115 with SMTP id eo10-20020a1709069b0a00b007309d825115mr1122321ejc.629.1659390535587; Mon, 01 Aug 2022 14:48:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659390535; cv=none; d=google.com; s=arc-20160816; b=BKAaZcNrmk1FAJPA6phYgUms+RREM+FztQvo21Y2RJiokId5sDP1txRTua6mCtIJ99 IvPcN3d5gWpbcQkHBWEiafOMT3Czlg2RxKaHIwXwTsy2AJEGmDvT/ikxMF449QIcd4xd nMhkk3Bh7xcTdS0KzWuGQGPBoaMGjK1GgZv5zPJTbRVMJKpAZQVPJx5MPEXdnyLtS1Ck zZkvT/9SM7YbmtWQCfapxCpdtwxKKl/fXWBS9QDZUl1nqxJ/zxpOKw1zEOJNyzqsRaT4 DOjkfZWJbNJw2gxcAvcreGulzkPFnOw8L3Ai67RVqrLDa1x6vjaV/ZFocaBqpK+cA39O daHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=9mmgjmEfi+Pg8SxIlnb6z90AkOOq77tXAXYNH2j8r6c=; b=P4thckKyDMf+FgjQjjM6ThcA2EEBJYKwYxTcuhBI3TX0qmm3MmjNwElieIDrfrUJBd SGWOlsCqLY8ObMt5PhvDGbOVDK2Djhff15ye35l4IhTFLuoWC6lZsAadzKxBQdwd8PVP ED7c+2tygu6ad0N04tWRRz/XCrXNOiyMcTbNKsyO9m/TMcdgCh0UivDqTIojTZXRgvo+ CkqBH6Iu8aPrM2CcLKOir1ROUpXXYWZbv+XHaRMPD0AMbtmUmQ/p+Ipflbj2OdPKzmEU yEopxgAjsr1KE4nGh1xbYpjIclOXemBguYIPszmlwYNKNK3/VwjAo/toS5RdhtjoQM0k u3NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VPwlC71I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb16-20020a1709077e9000b007308e7cd167si3391133ejc.846.2022.08.01.14.48.30; Mon, 01 Aug 2022 14:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VPwlC71I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234725AbiHAVXO (ORCPT + 99 others); Mon, 1 Aug 2022 17:23:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234441AbiHAVXF (ORCPT ); Mon, 1 Aug 2022 17:23:05 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511962A72D for ; Mon, 1 Aug 2022 14:23:02 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id k25-20020a056830169900b0061c6f68f451so9086973otr.9 for ; Mon, 01 Aug 2022 14:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=9mmgjmEfi+Pg8SxIlnb6z90AkOOq77tXAXYNH2j8r6c=; b=VPwlC71IfmGW7jPQEyXLB72afN/1A/fwLOhvIvdGAMmffhnD0IATcH9CjCi+39TpO2 Ukvgw5hg33gf8eijtv+C+MgESZ4VgU+2fWQvbhoV9BUeg36vW3O9iuJ3U0UHTPKAWS/K OKj2Sg6PR520xucLZYh5MRVZyBTlCosijLq1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=9mmgjmEfi+Pg8SxIlnb6z90AkOOq77tXAXYNH2j8r6c=; b=skThDQGIvc2vBl9CMlvm1EuIELmDQx92PXtrzVz0oLt3keaA2P5xsAAuiwchk9+bHm I/3swc0Oz2kOiPbRlQDzHvK5hPuSIGbFnY6w6hEN648GJ8zMO/T5C2EK2mBOXZxOdr3M d/PH3lkgEcRXYGWTeOMpjeLLxED5Bttd39FV+BFcVoQlyMbwp0w6ur6j3NGnPR7i5Vq9 owTQ0qW3SNL5eu1gJDIu5N9+pnb95P3tvaprUX5EYiBzx/1rxf/vhI4XhXFkwk8OgQPp DAa28M/qam/jjXavqGVyHPWQJwXK+MuWzw9tO/tNOn9nXP+4jhaSZAQw/PlzbDU1lEma P+IQ== X-Gm-Message-State: AJIora/j6que/FzRtUauPYlwzXF4itQnCtcyMaTVfL+rSzR26Pyx49qh JZnR4czcN6+PGDkUjqgmCAjaTwiYnL5Msxe0KyszeA== X-Received: by 2002:a05:6830:2645:b0:61c:b7cd:bde3 with SMTP id f5-20020a056830264500b0061cb7cdbde3mr6503564otu.73.1659388981595; Mon, 01 Aug 2022 14:23:01 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 1 Aug 2022 16:23:01 -0500 MIME-Version: 1.0 In-Reply-To: <1659384830-9909-1-git-send-email-quic_khsieh@quicinc.com> References: <1659384830-9909-1-git-send-email-quic_khsieh@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Mon, 1 Aug 2022 16:23:01 -0500 Message-ID: Subject: Re: [PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4 To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Cc: quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kuogee Hsieh (2022-08-01 13:13:50) > Data Symbols scrambled is required for tps4 at link training 2. > Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to > work. > RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter > measurement with minimal equipment for embedded applications purpose > and is not required to be set during normal operation. > Current implementation always have RECOVERED_CLOCK_OUT_EN bit set > which cause SCRAMBLING_DISABLE bit wrongly set at tps4 which prevent > tps4 from working. > This patch delete setting RECOVERED_CLOCK_OUT_EN to fix SCRAMBLING_DISABLE > be wrongly set at tps4. > > Changes in v2: > -- fix Fixes tag > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd