Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Daniil Lunev <dlunev@chromium.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Avri Altman <avri.altman@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3] scsi: ufs: ufs-pci: Correct check for RESET DSM
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1czdj4jrl.fsf@ca-mkp.ca.oracle.com>
References: <20220728111748.v3.1.I22460c4f4a9ccf2c96c3f9bb392b409926d80b2f@changeid>
Date:   Mon, 01 Aug 2022 19:38:30 -0400
In-Reply-To: <20220728111748.v3.1.I22460c4f4a9ccf2c96c3f9bb392b409926d80b2f@changeid>
        (Daniil Lunev's message of "Thu, 28 Jul 2022 11:18:21 +1000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?npRor503iLChvfvNcJ05+tlkKUx4FGCeoALCSr36KOYOGCEdXX9g0inUWTCz?=
 =?us-ascii?Q?EvtmjrVHp0J5hi76D0qKlH6SbkbMZ7dXkXxq7/ls/yhR7G4J/v0Rz7cyxEea?=
 =?us-ascii?Q?0jcmqWypfq2k4mP9XyFnKEGLuVuyCNoLchmBRk6DDo9iknDbqr6t3KmA7LSm?=
 =?us-ascii?Q?39ve3v0fPxniUUOCoxob4QrSi0CE882IbeDbdcpxtV4IWSPodglMqRScGXl+?=
 =?us-ascii?Q?j7DuGJLdcJqScReXWrrCtkN87fJXIYZGmsTA1j5Qp/Ix/aXPruFv+By65uLN?=
 =?us-ascii?Q?2M5zPmxrFUsJiTC2czDkLdPRNYa1g8t9Oi4hAAkDGTNx7Cqut9KGRBblx+cu?=
 =?us-ascii?Q?rTz8zE7xTX1QXySlNHhb7IcFKke311YF8v+g2PYeKKfvnWdBfQJwWY6Qi4eh?=
 =?us-ascii?Q?UWLON4nVDvE4zCP6lJVyhoTCxrHxRDDnszswoUSEK1KoRbH49QC1djpAjaxU?=
 =?us-ascii?Q?rzGBCUklqr5Q46wnjCDomogKrMHOejB0xcMfuWw9UK+BVlbtDUT2JPoE+scq?=
 =?us-ascii?Q?k0u1YN8PM7D98XXEeJc5IP41IQOqmRLV+hLPycfxIcZ/m2U6XG+8EyS8p1zb?=
 =?us-ascii?Q?YGgwFK4fIe94drN95hyZo4KqBdcvCkPLKChwdFoFZ5PwL1EGCrfHNsXl9pCA?=
 =?us-ascii?Q?5nviKlc67QNnj3EiPAFbaCDXZLGBu37UsIU8s9yqWTctUbw9bnVhMOdA4I5o?=
 =?us-ascii?Q?Jnh7RGJvP/prRPq8v+7dTvLWAKNtYUUu7Q0pM5hPtSdec4z/QpPGvC71lE+x?=
 =?us-ascii?Q?KOk3XZ0iRoVY87MYH5LwEIpqwJu6+gCl3gtS8rzwsP506uF9a+baY/+y0Qna?=
 =?us-ascii?Q?5/XAUJuQOCNzrEkat3PyEOHQTL9BfuDQssN0hc/1zmCr0d/RCoJbYeUNzNg3?=
 =?us-ascii?Q?voaczAr4LoOqZP/hpAZdTBm7gbT8sJr3hyoJ2fayvkzQl0TlqBYmnr8g5Lw7?=
 =?us-ascii?Q?nnB98xr+YFFlYNnnNq19d6QSQdhDfD/0GnTalYbwbhVEV06nh74BulnInoUw?=
 =?us-ascii?Q?MSBeEtmNPlh1st9MRgCb78ueLKZ/zig3x15e623yQafOBIyr3T38/zH5XMxp?=
 =?us-ascii?Q?9hwhhjH5HwC91zV0LohfeJ4a1YmbibkJA5nmMZCQUIkEAIO3dwrgZtU/6gte?=
 =?us-ascii?Q?fAyYWShd7p3NjJGXrBwn59IsXCPF/32zK6aZdLmMSqqxq9KdG2ZvUc4f6hB8?=
 =?us-ascii?Q?nuzewU6WpdgBGN1RYfdF10Di7MOkS2erJvtkGvNZRanwGd7xoJG+7T2sm2jK?=
 =?us-ascii?Q?SPHVk+osRphInIeLrNeOeJuE4Uk+g3P/FLcmz8yO7bc/fSghhAW8KaqFg7y8?=
 =?us-ascii?Q?wNwhwPS08TcZbT1+c06XwWsldodsAjnMprM8+++Ec+jjXoWlc8Z+bhcRG5Kf?=
 =?us-ascii?Q?LwiTsiL+k77vLJRdn5yFUvIY5z4fuTklV9g0H6YLB4vT8Ga4KFXIV4RfJV1z?=
 =?us-ascii?Q?7IKKoZAUci6y7arCSw83xwsb2j4iQXWLis4G/7XHPyBoMsimpySIJXFYtd3r?=
 =?us-ascii?Q?P+NByDyUbbuyZ+cAJsQgfHNj4i5kFhh5UZ6e93w+UzX4z/WLnESyNJvSxK1a?=
 =?us-ascii?Q?7yYoWBQjGkaHrzjm9iK5880u3XHsaiYfdWRiKK7w0Ra2AM/B4eLYlqbkLBfi?=
 =?us-ascii?Q?XA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc986e51-775b-42b7-3376-08da7416f2f7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 23:38:34.1985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q5ovdefKUXNP05BiKM/i12KkS83JT7kaRalBf/sISookGAi/zsJWYBOjI0EGLANQ75eMhS/PNGfVIgt52H/iQk7PvO6usErf4+dWey8rY+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3383
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-01_12,2022-08-01_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=830
 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208010118
X-Proofpoint-GUID: F_owRWidSACKY7h3efg0pgHyrGbgV-wF
X-Proofpoint-ORIG-GUID: F_owRWidSACKY7h3efg0pgHyrGbgV-wF
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Daniil,

> dsm_fns is a bitmap, and it is 0-indexed according to the check in
> __intel_dsm function. But common initialization was checking it as if
> it was 1-indexed. This patch corrects the discrepancy. This change
> won't break any existing calls to the function, since before the
> change both bits 0 and 1 were checked and needed to be set.

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering