Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alistair Popple <apopple@nvidia.com>
To:     linux-mm@kvack.org
Cc:     jgg@nvidia.com, akpm@linux-foundation.org, minchan@kernel.org,
        linux-kernel@vger.kernel.org, jhubbard@nvidia.com,
        pasha.tatashin@soleen.com, david@redhat.com,
        Alistair Popple <apopple@nvidia.com>
Subject: [PATCH v2] mm/gup.c: Simplify and fix check_and_migrate_movable_pages() return codes
Date:   Tue,  2 Aug 2022 10:30:12 +1000
Message-Id: <814dee5d3aadd38c3370eaaf438ba7eee9bf9d2b.1659399696.git-series.apopple@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VGlScQB7HI/IZAc3cv11DWVMAW28hf3r6pkUKzHG8spTRt6u0fliJucXyVIh?=
 =?us-ascii?Q?hODQcE8HQExn7QRfqz75yZ1MIJU5H8FU/uE2kqEHnKsWuNSoa1jZKV+9FIMt?=
 =?us-ascii?Q?iN2wPuIxYANBela8JRo6jFIMwObwGdp9MNOAR3o+1EEHyMJoAFSzH1cX/jmv?=
 =?us-ascii?Q?6VEvi+ZB7O+n9uqqynn9swfppWN5BlDZD3ER+2tZY8BUKsgQIsN03R9F5K6u?=
 =?us-ascii?Q?cyyPyX3aph7kkjRt+tV40/zjGtNFeF9oTDy3PFDLUEirGjE9B4UQWJw4E44f?=
 =?us-ascii?Q?50J6VedFMlmpyUar6e0x2sIo+rRkqmOANyggo/mvKfb9cM5xWbJRjCy0son4?=
 =?us-ascii?Q?PbA+4UoF2HBaghnvYj1vfrT9lQuDPTnK7FBhcblEZ1Bk98Vpy9W+wZWo6T0s?=
 =?us-ascii?Q?dyZ/TzfxwJRpm4h3mIFaedLCYVwSJKH/djdrNWM11LhXaG6CxswdF+GiPZOx?=
 =?us-ascii?Q?6F7t83HlTT8qX+WEbWoxVLCj4iH6zzq3tsO3L0//1M6VVxYwd87m3cEaUqBV?=
 =?us-ascii?Q?iI33qL1YrE1jnRi8iCXQMPRkT0dGp6xQbXGeH5Ofp4LSVmK90nWd5Q8s0dc1?=
 =?us-ascii?Q?knsF5VdMSwXzUJvzLACTOexSh6KxdC1wADN4RwyMD2yrZAcENmvxQSBEDkb+?=
 =?us-ascii?Q?3bm6E4Ty2a+j049bbS5QztfIiwoa/hdnBeX7pHLHgXb3vVB8rL8ii05WKOeH?=
 =?us-ascii?Q?jjF+XRwiDDYl219zxKQ/XD7TWG8yzMHuY66M4ZwrS3yxHg49AhjCY94vKCWY?=
 =?us-ascii?Q?YCecZVMQh18KJ0vSCO/padPkhyuUEQM6p4j7oatdstZ8HmUylhl/wvedOT6H?=
 =?us-ascii?Q?/0d0Cx19zC30aB+VKkba4ryF5xuSLYZt9ZztVZEBBE4/9pXr2W/Hj3hkpX8c?=
 =?us-ascii?Q?FuDz8TbQQrY9dSDyQiswnKqRSvLL6AMh67WIjqa0j0fRC7oLHJX3FnffUp5P?=
 =?us-ascii?Q?FHMOnYcE1EBHmTRELW+AQBV7kmyVqytsrKDEYs02SPtge7oDdYvPC//bj5ag?=
 =?us-ascii?Q?aDxd6dXgVcKW8sQvnigL/iMYxQaMCcDCLatxhYf6qq6vz1Oaj9fvD2qYW7PB?=
 =?us-ascii?Q?dAatZxTzxP2QjybfDbFUIAd5cUj16aA5FhRPfAznW4xJJ8KQegzWcgB6Zi7b?=
 =?us-ascii?Q?pGVtkaZvn/G3xpdtHmamH4zzkxq8/Zsb7Ux6JlYEdKyS1Utu4axNZPAG6x2N?=
 =?us-ascii?Q?zMuFeITqiqRv3WgQ4787XKVPJL2PAugtt5DyvFHo7MgI0eL0m2bZqFj7eX9V?=
 =?us-ascii?Q?nDv9Ed9eKOG2SGB1ZRDdddrB8jdOhFbsI4jbqGJkbrnYwK55SoFe/HRx2D2p?=
 =?us-ascii?Q?8sMyqv1kongl48aEftAZUjpmu40Il/MF/z82GuDFS11lPSbqz0jGKW4N1QEM?=
 =?us-ascii?Q?8M326ulKwU38ZeGNCkkffM6YtK83VwM8r95Smt9btcfyRRcOsWnnxXm6JFo9?=
 =?us-ascii?Q?rHv3fE5ExpmBbbA+ZPYs4jSeAEfDg/4iRkzmvcg0hZA6oekshvpIZMNmUsWb?=
 =?us-ascii?Q?bCXDy6+V2V0rjc0/+tATblyQFF2prTCTlY3UjSc8ISKH1Pxn702Wk6oKAFbR?=
 =?us-ascii?Q?jOsPFF/iCAR2OCohlpLvZTa+AUSUIhpDH34sdRWp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 337cbc66-8dde-464f-ed53-08da741e7a56
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 00:32:27.7954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T5u4rcs5FQLs6GjO6E90x8VkTeyx6+vfX8zeXpfXIPiZuu/fAdV6S7FKzA+W3uBgKv+8c4Zm6ykzKEam2f+sYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4842
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When pinning pages with FOLL_LONGTERM check_and_migrate_movable_pages()
is called to migrate pages out of zones which should not contain any
longterm pinned pages.

When migration succeeds all pages will have been unpinned so pinning
needs to be retried. This is indicated by returning zero. When all pages
are in the correct zone the number of pinned pages is returned.

However migration can also fail, in which case pages are unpinned and
-ENOMEM is returned. However if the failure was due to not being unable
to isolate a page zero is returned. This leads to indefinite looping in
__gup_longterm_locked().

Fix this by simplifying the return codes such that zero indicates all
pages were successfully pinned in the correct zone while errors indicate
either pages were migrated and pinning should be retried or that
migration has failed and therefore the pinning operation should fail.

This fixes the indefinite looping on page isolation failure by failing
the pin operation instead of retrying indefinitely.

Signed-off-by: Alistair Popple <apopple@nvidia.com>

---

Changes for v2:
 - Changed error handling to be move conventional using goto as
   suggested by Jason.
 - Removed coherent_pages check as it isn't necessary.
---
 mm/gup.c | 81 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 41 insertions(+), 40 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index 364b274..5707c56 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1901,20 +1901,24 @@ struct page *get_dump_page(unsigned long addr)
 
 #ifdef CONFIG_MIGRATION
 /*
- * Check whether all pages are pinnable, if so return number of pages.  If some
- * pages are not pinnable, migrate them, and unpin all pages. Return zero if
- * pages were migrated, or if some pages were not successfully isolated.
- * Return negative error if migration fails.
+ * Check whether all pages are pinnable. If some pages are not pinnable migrate
+ * them and unpin all the pages. Returns -EAGAIN if pages were unpinned or zero
+ * if all pages are pinnable and in the right zone. Other errors indicate
+ * migration failure.
  */
 static long check_and_migrate_movable_pages(unsigned long nr_pages,
 					    struct page **pages,
 					    unsigned int gup_flags)
 {
-	unsigned long isolation_error_count = 0, i;
+	unsigned long i;
 	struct folio *prev_folio = NULL;
 	LIST_HEAD(movable_page_list);
-	bool drain_allow = true, coherent_pages = false;
-	int ret = 0;
+	bool drain_allow = true;
+	int ret = -EAGAIN;
+	struct migration_target_control mtc = {
+		.nid = NUMA_NO_NODE,
+		.gfp_mask = GFP_USER | __GFP_NOWARN,
+	};
 
 	for (i = 0; i < nr_pages; i++) {
 		struct folio *folio = page_folio(pages[i]);
@@ -1935,7 +1939,6 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 			 * pages.
 			 */
 			pages[i] = 0;
-			coherent_pages = true;
 
 			/*
 			 * Migration will fail if the page is pinned, so convert
@@ -1946,10 +1949,10 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 				unpin_user_page(&folio->page);
 			}
 
-			ret = migrate_device_coherent_page(&folio->page);
-			if (ret)
-				goto unpin_pages;
-
+			if (migrate_device_coherent_page(&folio->page)) {
+				ret = -EBUSY;
+				goto error;
+			}
 			continue;
 		}
 
@@ -1960,8 +1963,10 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 		 */
 		if (folio_test_hugetlb(folio)) {
 			if (isolate_hugetlb(&folio->page,
-						&movable_page_list))
-				isolation_error_count++;
+						&movable_page_list)) {
+				ret = -EBUSY;
+				goto error;
+			}
 			continue;
 		}
 
@@ -1971,28 +1976,26 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 		}
 
 		if (folio_isolate_lru(folio)) {
-			isolation_error_count++;
-			continue;
+			ret = -EBUSY;
+			goto error;
 		}
+
 		list_add_tail(&folio->lru, &movable_page_list);
 		node_stat_mod_folio(folio,
 				    NR_ISOLATED_ANON + folio_is_file_lru(folio),
 				    folio_nr_pages(folio));
 	}
 
-	if (!list_empty(&movable_page_list) || isolation_error_count
-		|| coherent_pages)
-		goto unpin_pages;
-
 	/*
-	 * If list is empty, and no isolation errors, means that all pages are
-	 * in the correct zone.
+	 * All pages are in the correct zone.
 	 */
-	return nr_pages;
+	if (list_empty(&movable_page_list))
+		return 0;
 
-unpin_pages:
 	/*
-	 * pages[i] might be NULL if any device coherent pages were found.
+	 * Unpin all pages. If device coherent pages were found
+	 * migrate_deivce_coherent_page() will have already dropped the pin and
+	 * set pages[i] == NULL.
 	 */
 	for (i = 0; i < nr_pages; i++) {
 		if (!pages[i])
@@ -2004,21 +2007,19 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 			put_page(pages[i]);
 	}
 
-	if (!list_empty(&movable_page_list)) {
-		struct migration_target_control mtc = {
-			.nid = NUMA_NO_NODE,
-			.gfp_mask = GFP_USER | __GFP_NOWARN,
-		};
-
-		ret = migrate_pages(&movable_page_list, alloc_migration_target,
-				    NULL, (unsigned long)&mtc, MIGRATE_SYNC,
-				    MR_LONGTERM_PIN, NULL);
-		if (ret > 0) /* number of pages not migrated */
-			ret = -ENOMEM;
+	if (migrate_pages(&movable_page_list, alloc_migration_target,
+				NULL, (unsigned long)&mtc, MIGRATE_SYNC,
+				MR_LONGTERM_PIN, NULL)) {
+		ret = -ENOMEM;
+		goto error;
 	}
 
-	if (ret && !list_empty(&movable_page_list))
+	return -EAGAIN;
+
+error:
+	if (!list_empty(&movable_page_list))
 		putback_movable_pages(&movable_page_list);
+
 	return ret;
 }
 #else
@@ -2026,7 +2027,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 					    struct page **pages,
 					    unsigned int gup_flags)
 {
-	return nr_pages;
+	return 0;
 }
 #endif /* CONFIG_MIGRATION */
 
@@ -2054,10 +2055,10 @@ static long __gup_longterm_locked(struct mm_struct *mm,
 		if (rc <= 0)
 			break;
 		rc = check_and_migrate_movable_pages(rc, pages, gup_flags);
-	} while (!rc);
+	} while (rc == -EAGAIN);
 	memalloc_pin_restore(flags);
 
-	return rc;
+	return rc ? rc : nr_pages;
 }
 
 static bool is_valid_gup_flags(unsigned int gup_flags)

base-commit: 187e7c41445a0f202bb551f08ca7f8158fea1cd7
-- 
git-series 0.9.1