Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01b70c1c-b274-7e8f-cdfd-cea020f7279b@quicinc.com>
Date:   Tue, 2 Aug 2022 09:08:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.3
Subject: Re: [PATCH v3] mm/page_owner.c: add llseek for page_owner
To:     Souptick Joarder <jrdr.linux@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>, <vbabka@kernel.org>,
        "Minchan Kim" <minchan@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        <linux-kernel@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>
References: <20220729004920.8544-1-quic_yingangl@quicinc.com>
 <CAFqt6zaAFONhDtWcwBbTVM5LkT4v0uM0wLiAnVGpzNydHp_S0Q@mail.gmail.com>
Content-Language: en-US
From:   Kassey Li <quic_yingangl@quicinc.com>
In-Reply-To: <CAFqt6zaAFONhDtWcwBbTVM5LkT4v0uM0wLiAnVGpzNydHp_S0Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/30/2022 10:28 AM, Souptick Joarder wrote:
> On Fri, Jul 29, 2022 at 6:19 AM Kassey Li <quic_yingangl@quicinc.com> wrote:
>>
>> There is usage to dump a given cma region page_owner
>> instead of all page's.
>>
>> This change allows to specify a ppos as start_pfn
>> by fseek.
>>
>> Any invalid ppos will be skipped, so it did not
>> broken the origin dump feature.
>>
> 
> I think a Suggested-by tag needs to be added.
   re-send it again. please help to review, thanks.
> 
> 
>> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
>> ---
>>   mm/page_owner.c | 20 ++++++++++++++++++--
>>   1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/page_owner.c b/mm/page_owner.c
>> index e4c6f3f1695b..231b1877af99 100644
>> --- a/mm/page_owner.c
>> +++ b/mm/page_owner.c
>> @@ -497,8 +497,8 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>>                  return -EINVAL;
>>
>>          page = NULL;
>> -       pfn = min_low_pfn + *ppos;
>>
>> +       pfn = *ppos;
>>          /* Find a valid PFN or the start of a MAX_ORDER_NR_PAGES area */
>>          while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0)
>>                  pfn++;
>> @@ -561,7 +561,7 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>>                          continue;
>>
>>                  /* Record the next PFN to read in the file offset */
>> -               *ppos = (pfn - min_low_pfn) + 1;
>> +               *ppos = pfn + 1;
>>
>>                  return print_page_owner(buf, count, pfn, page,
>>                                  page_owner, handle);
>> @@ -570,6 +570,21 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>>          return 0;
>>   }
>>
>> +static loff_t llseek_page_owner(struct file *file, loff_t offset, int whence)
>> +{
>> +       loff_t retval = 0;
>> +       switch (whence) {
>> +               case SEEK_CUR:
>> +               case SEEK_SET:
>> +                       file->f_pos = offset;
>> +                       break;
>> +               default:
>> +                       retval = -ENXIO;
>> +       }
>> +
>> +       return retval;
>> +}
>> +
>>   static void init_pages_in_zone(pg_data_t *pgdat, struct zone *zone)
>>   {
>>          unsigned long pfn = zone->zone_start_pfn;
>> @@ -660,6 +675,7 @@ static void init_early_allocated_pages(void)
>>
>>   static const struct file_operations proc_page_owner_operations = {
>>          .read           = read_page_owner,
>> +       .llseek         = llseek_page_owner,
>>   };
>>
>>   static int __init pageowner_init(void)
>> --
>> 2.17.1
>>
>>