Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2339807imn; Mon, 1 Aug 2022 21:55:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uWAxPQw1ggNBO6M5sdjOeg8DV5/BOoL3dOqEpxI322r1BeKUYNeB47xcKCblofq/CukIu5 X-Received: by 2002:a17:906:93f7:b0:72b:8acd:d8ba with SMTP id yl23-20020a17090693f700b0072b8acdd8bamr14482449ejb.496.1659416154144; Mon, 01 Aug 2022 21:55:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659416154; cv=none; d=google.com; s=arc-20160816; b=jggoWgZilVluwi70zJY37UNWm+PIS7gBpXyKJhV48D1EGp8gutwLHDIIU34xtXBusr ivC7hJObwGkImni9VUCLvVcKHghMc5byL+5BoITceSVZaMhc4F9f4nzWmHcTUc+WDGgA FDFfX6RHZ01J5BSgkmIHfqJvodkfXVGeaO3KQLPK7t0zrXzCh3QNgNVPo3H4h/RrUN9H I0vJdkpnfrj0PBcGw7zXdIf7PFlmP/AKV70VM8aNOfpHuLPhwxRn8df/o+tSL0l8mYKv iwQOYtb7E8lzhTSsMcgd5Iga8oQwy+imwlGcn74I3zYlr0ZGw+yIrQXmfCnAReP8STBU +kxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mB9h8G9LJF8fW8nHybI8e5Iuu0xEFlrhVdl6RtAPL58=; b=tz2RbhQUs3RvK0uCV2Ft/Vaa18dSssOc8heqIhQ1iV2JQcmVsxKT0gBcm1XfL6L9CO nUxw4tHsQRUt54+w/zk3Hn689Mfb6DLmvU/JKhisuS+Aa0hLzV9PSATHdNun7Y45CrsK duXfwFaZmQYqrGxOE7asMKjTpOsDwEhJ4Moxebm+QlmB4hg0VbAv8xj0JFtbCvwPswlo s5mKLZo0InRx7GxfNE6y+ea4ybvQLwNWG5NPhFY+//DbEoOPVYvgUwIR09B+evy2L+XC BVTaCLGUCc9S/5iVWPUYecLh3V6rgzONOBLkmkZ0Ox0Sg0kFjyqQYU6tuAPouHC82Ekc Xiuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=D8xqF6gq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o25-20020aa7c519000000b0043d727cea7fsi5485848edq.341.2022.08.01.21.55.29; Mon, 01 Aug 2022 21:55:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=D8xqF6gq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235008AbiHBEMV (ORCPT + 99 others); Tue, 2 Aug 2022 00:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiHBEMT (ORCPT ); Tue, 2 Aug 2022 00:12:19 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00B6718B06 for ; Mon, 1 Aug 2022 21:12:18 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id i62so20169708yba.5 for ; Mon, 01 Aug 2022 21:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mB9h8G9LJF8fW8nHybI8e5Iuu0xEFlrhVdl6RtAPL58=; b=D8xqF6gqVwgRmjc6T7IFge/nqYPeDWoinA/3nld8iU+Rg3OvO70iE2v1rzUIrG8MZj qGhIBy760M2U1mdG2ZYlat0wTNl05qOXhSP6ELrth4M0ansXNj/qv8lRqp1J5FwCrZVv TJiUTFnl3jsOxN0b9vuw3V48OlVC0QBVetP5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mB9h8G9LJF8fW8nHybI8e5Iuu0xEFlrhVdl6RtAPL58=; b=K41eiW2T+KKYWhA0CfZLdMM5wISXkCQa5Gm3QIf8hluUC4nQGANhxP4XXJQ8uagnPw mJ/cHUqSnvCd8261zmstHIbrimxDQpcCTTOk/2e5YkmnxgN6wbr56sjYGzciKBZY1JPX 8OIFHwfh/48g6XhZgwRNWcjPP0by20LH77W+aSUPhGl/P5ZWMMdCP3o4amEamXlAx56L DdSzzrtoIYHC/od2C6VBBx3MihkjvozLULVgBw9h+jgg9oE0c3cGssEXQgUJe2Hif1Jd zMEyhxUoOX61h6P2SetV1LhAgr0JBpNi31UMh3hKBVnC5AxkhmK4WPSdaNZeEKLADxK/ Knzg== X-Gm-Message-State: ACgBeo2LobUJiBxw3O4QSf3ct8OqN9RI5C351H0vt9S0UmQbYVMSAdvz Gl5R1HJtkaeOBRpTQtCxqMeVIhwqc9BuwRgczlj35w== X-Received: by 2002:a25:7cc2:0:b0:677:5a84:9f79 with SMTP id x185-20020a257cc2000000b006775a849f79mr4233940ybc.518.1659413538291; Mon, 01 Aug 2022 21:12:18 -0700 (PDT) MIME-Version: 1.0 References: <20220802103643.v5.1.Ibf9efc9be50783eeee55befa2270b7d38552354c@changeid> In-Reply-To: From: Daniil Lunev Date: Tue, 2 Aug 2022 14:12:07 +1000 Message-ID: Subject: Re: [PATCH v5] ufs: core: print UFSHCD capabilities in controller's sysfs node To: Bart Van Assche Cc: Adrian Hunter , Greg Kroah-Hartman , Alim Akhtar , Avri Altman , Bean Huo , "James E.J. Bottomley" , Keoseong Park , "Martin K. Petersen" , Mauro Carvalho Chehab , Sohaib Mohamed , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Calling this the effective capabilities of the controller-device pair > sounds good to me. But please do not refer to hba->caps. I'd like to > rework hba->caps such that it only includes controller capabilities and > no information related to the WriteBooster. Additionally, several UFS > device capabilities that may be exported in the future are not > represented in hba->caps. So can you clarify where specifically do you want me to mention that? Should I name the directory "effective_capabilities" or the commit message? Thanks, --Daniil