Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7b87da8-cd78-77ef-dd93-7886d4197050@amd.com>
Date:   Tue, 2 Aug 2022 11:47:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [RFC v2] perf: Rewrite core context handling
To:     peterz@infradead.org
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, alexey.budankov@linux.intel.com,
        ak@linux.intel.com, mark.rutland@arm.com, megha.dey@intel.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        kim.phillips@amd.com, linux-kernel@vger.kernel.org,
        santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20220113134743.1292-1-ravi.bangoria@amd.com>
Content-Language: en-US
In-Reply-To: <20220113134743.1292-1-ravi.bangoria@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1VFY0tCaXc5UEJnQ2taMDBuS0FQVEc2aTlnMjd1K3pJVjdCZFd0bGN4MzhT?=
 =?utf-8?B?aVJmdjZPUTAvWG1LRThrOFhMSEpYT09VbVN0K1lmOHZEV0FJRm83blhUQlNv?=
 =?utf-8?B?elh5d3lhbkJXak1FVHA4cWdPTms2UVVTOWNNQkJVajNOajlnM3VKRlBjOXQ5?=
 =?utf-8?B?MVU0RnU2V2EwWjFkK1BFZkJGQVZqb2tjNlh3R1VQeXFpMDhzelBqMWtMekxs?=
 =?utf-8?B?emhJSmxSZ1ZkSUdpT3A2TGNtY01ZR1pTSG1PWTl1cDFFemJiZU1uTzBwbXpm?=
 =?utf-8?B?R3FSVHpIU09zNTlzc0MzV2VsZXlYY0pDcC9NcTJzS0xtZkZQRkRBSXJVd0Vj?=
 =?utf-8?B?MHdvZUJtK0x6NVZhK1IwY0F6RllqQ1FSUW0rOEszd052Tk1jUVZsL012SjNF?=
 =?utf-8?B?WVJjWjdESFRoRk1veXpZT2loWWRscEJjSkZLdStCQXBpZHFUVU96M2NCaEtn?=
 =?utf-8?B?UFhFL2o3QTk2bXA0U09IYUxzeUNqbGN0ZWR6ZTh0aGF3MHZiNlNSTUlvNS81?=
 =?utf-8?B?RDhQME00MWg3YTRSNVBLaEUwMDE0dmpkQytrTjBKSGNDQ2JabjZTOS95dGZk?=
 =?utf-8?B?NDd2dG90NkpIeHV4QnBXRjFwbGp1bkJXQ3U2NUU1bkRrL0RRY1dCd2hxcGps?=
 =?utf-8?B?NDMxeVNxK3B0QlY1ME13SG5MOW5vc1NEWk1ULzhraDFOM1g1L0pJb2hCRi85?=
 =?utf-8?B?cWFxTGsxL3pmMmUyTjdKc1g2TXJZN2s5Q0c0RVgvT3FLcGx2cFJiNFBML1Rs?=
 =?utf-8?B?bklDL3JOdk93aWtSRGRZZ28rQklIVmtvaVVDSjgyQ0R2dFh3K2pOcnZXck4y?=
 =?utf-8?B?OFdiNUFuWFoyUHJEOWVCR2hoSDF5bFRTNUtoMHA2UlEwenZwTDVxQnN5WGkw?=
 =?utf-8?B?OVRRalVZRHV1K2NFMitpMnVxU1pDYy96bVNCblc1K0s0RjBXdVNpTDdsSDJW?=
 =?utf-8?B?aHNtemsxSGl4VmdGbUdPL05QWXNpbk5MTENDMHJ1NWYrVndiWEFNcmpzQ0Qr?=
 =?utf-8?B?Y2FhT1d2UEFEUEs0K0ZzRnpFYWsvQUg1VEV2Yit4NW80U2x6NFhNcWhoc3hN?=
 =?utf-8?B?bmloT3hIcXhGNk85VjBNUDZZWk84Y09xMTJvS0NPaXJGOVFJeDJDbFl0UHp5?=
 =?utf-8?B?UnBFQUlkRTRQcUZ2SkNsRU4zL0FrY3VpTWZiU2pxN2ZyWS91N2Z1ditjZjBP?=
 =?utf-8?B?cjVlcjdEcm8zOUMxeDF1UXhrU2d4UmRYdXRwZSs4WjVQUURLTVRzTU1TQllN?=
 =?utf-8?B?Z1NPN0lOc1BvRm94Slh0Mm9iU3VTZmJoZEtTTDhyTmNCSStWNkhSUlZXaXZm?=
 =?utf-8?B?Q0FwWUpRdGtCNmhRV0FHSHZHKzhsNUhSNDl4SFRLc3VlZ3Y5UmQ1RzBKMlFs?=
 =?utf-8?B?ZzVtcWZ0WHlrb2lEenUrYnVlZm9XZytuSUg0U2NVU3huRFdzRDg0aDdnQytY?=
 =?utf-8?B?ZzNEV3k3WWZobXRPWmtRRGJ6TmRtREUwNlNhNUZ0STVEMmJQRWpaOWg1eHdu?=
 =?utf-8?B?dHdtWUtFRWZVN3pwK1hmZjJHbC9RTlJySFk1YTdmNmx6cEsvNnBnQm4wSDRy?=
 =?utf-8?B?Q2phUzY0UzJrVFFGMlVPRG5tdGVNaGNmR0o5SHJlUm11Ly91aXN1d1RMMHoz?=
 =?utf-8?B?bk5SblBMdWdHNy9PV2UwbWEzaGV0N3RPY3JMZ0ZPTHREY055aEE1MHBBMVJM?=
 =?utf-8?B?ZFNOYkczbGxla2VjNm0vMXV5VWd2UXhocU55aiswZ3RMalJpNFQ3SEhBNmVx?=
 =?utf-8?B?ekEwbHZiRllMSHkrN2F0K2NWT0JRYVpIaG1KcVJKRzFjQS9HL0RVeUN4NDFK?=
 =?utf-8?B?R0g5MEhMcnBHL0l4MGRGQTRCNTVKVC9vNVJyVUFYTGVmQ0lhUjhCY09RQnpX?=
 =?utf-8?B?eWdybEp0WjdNQ2Q1UERRcHRLNzFjcjlFeG1OOXI5UGFQZUYwd29tdUZGMzhE?=
 =?utf-8?B?Q2dFbzdiUktDNzhXMWdvVW0wUmdsL3FhL0RNbityY0lULzJXaFR5SWp6VWlT?=
 =?utf-8?B?VzFIRHAzSkR3cllUVmNCbkF0dVo0eTNZcDRreEtYQVJTQVNDMmR6MDRpVTUw?=
 =?utf-8?B?dnBDNzJvaWNGMHdQODlXRGphdTB6R1VkZWJqbGdtdjNqeWVYYXdKYmtxc1N2?=
 =?utf-8?Q?Jqytwf4VlgnyaUxfAZFHRwNSg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc285aa7-8a51-4c24-1e6c-08da744eb30d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 06:17:38.9879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YvJekPAB052SzBXS9jm1QeXfRCEm2+08p2qsAmYld1xCfh8jidGbo6XgeKlleCOF4OQsNYL+o/70KHIM2veGnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3095
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[...]

>  static void
> -ctx_sched_in(struct perf_event_context *ctx,
> -	     struct perf_cpu_context *cpuctx,
> -	     enum event_type_t event_type,
> +ctx_sched_in(struct perf_event_context *ctx, enum event_type_t event_type,
>  	     struct task_struct *task)
>  {
> +	struct perf_cpu_context *cpuctx = this_cpu_ptr(&cpu_context);
>  	int is_active = ctx->is_active;
>  	u64 now;
>  
> @@ -3818,6 +3905,7 @@ ctx_sched_in(struct perf_event_context *ctx,
>  		/* start ctx time */
>  		now = perf_clock();
>  		ctx->timestamp = now;
> +		// XXX ctx->task =? task

Couldn't get this XXX, it's from your original patch. If you can recall, it
would be helpful.

>  		perf_cgroup_set_timestamp(task, ctx);
>  	}

Also, this hunk is under if (is_active ^ EVENT_TIME), which effectively is
(is_active != EVENT_TIME). I'm assuming it should be (is_active & EVENT_TIME)?

Thanks,
Ravi