Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 14:54:03 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     "Sang, Oliver" <oliver.sang@intel.com>, lkp <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        John Garry <john.garry@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        "Alexander Potapenko" <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: [mm/slub] 3616799128:
 BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
Message-ID: <YujKCxu2lJJFm73P@feng-skl>
References: <20220727071042.8796-4-feng.tang@intel.com>
 <YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020>
 <YuY6Wc39DbL3YmGi@feng-skl>
 <Yudw5ge/lJ26Hksk@feng-skl>
 <0e545088-d140-4c84-bbb2-a3be669740b2@suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0e545088-d140-4c84-bbb2-a3be669740b2@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8ZIj1cC8u63K82b2FuGSoANQUQMxjq/2LV/aEhsCn+VpYIl25WoEp26ax+TG?=
 =?us-ascii?Q?hOtuflwwmAqqbGUbTtQa6UcSDhrI5WPf7r8xNqIFiInW26e1AR+uM60vrQS0?=
 =?us-ascii?Q?hK5YPhK+los920YeFa2esIBnK5I2VRwd+BSp3sXeM7fcb3s/9HknLRbqn0oZ?=
 =?us-ascii?Q?m1ZSUoV0a42vc1kodvB+nXA2MJv5vE0Yc4zT3AZa/QpqZS6jcYU3Zs+HXZHW?=
 =?us-ascii?Q?ku2+Bb4EecOHVzHcRlo5JdDcuTh8+OMudvLK3ruf+ItS4GLEc1i996BkT6Dp?=
 =?us-ascii?Q?lWwMi4xSh52G8W2G1e6lX1upC23oKVwx8X9HOc6MpyYKoUoRXh2AN1lRKSfI?=
 =?us-ascii?Q?8VEH5xHHgb66Y9FDokT/2D29ocbPR3Fohikx5xNPjBR8XPQ/R+TtmoVg7rH1?=
 =?us-ascii?Q?UjAcFCc9H7vdklXdEL3bAUvcUDgF14xy3ZEqUi+/kvu/xcJLkm/ITN07RATU?=
 =?us-ascii?Q?nQD2FEwKso+0KgLpx+OGZm2ax4btNEU6HvFtvIVoAuHFXFwL1kL5cZ7f2YZg?=
 =?us-ascii?Q?tbcIYeVYPJjk41klyUAE1mPsEe/KVeUaUfp0bf9TJJsli6F/oZE8ud4JYfDp?=
 =?us-ascii?Q?RmZL+QqxPYWhUrU3jGqST8B9o6TY8gClk/GGE0BqC9Q3qvuEnAk4AsmkNmmP?=
 =?us-ascii?Q?Dmr6M3Vaoxa4n/SaEhHWI29w2LowtnmREKwZvPWR2upIIENA8RTDjcG8uwNc?=
 =?us-ascii?Q?jsHCHaITw4XmSjf3SQ9uLTo44ysbOfRvcJy+2kByHAuI7rGqd8y3jGb9JWgx?=
 =?us-ascii?Q?NAxKNnabpHAdneB3vxFVi1E1+SP2gT39UF8L94G0d9jbGRtHe4IvwrbzNS8H?=
 =?us-ascii?Q?gB9bQcnZMjVHz+aN+wCsgv2kRdurB+gpROoBOBWSJVPaHY3wzK3+YJnUz1z0?=
 =?us-ascii?Q?N1bbuE9C4VbkxppXnMQ4QKnagaP8uKf2TXlyAyuUNhpU2CT7DmabkvV9/X6l?=
 =?us-ascii?Q?LbttETSN0Cb3zu+eXxg+frc+f4agRfzQ9oMGkYChWyCWMu3IoItxjP2cdqt2?=
 =?us-ascii?Q?YiGGhkR8ILfUN9+No4gqHzLcVOwaJcCMo+sYvbJHE0w0qv971upA8uvSVMoI?=
 =?us-ascii?Q?wg/4Nx3Esh5OAkP/rrNnTjNcDZaARraLmNol9vNw2wGvedYfuhEwGf9HxLOP?=
 =?us-ascii?Q?U3Z2tDyDhbsGpruZ6aW3ju+NGpQ74Pr8OzViwf17NMo/SlfcsOcXN+8D/7bb?=
 =?us-ascii?Q?q+VOizqHXAoLxj9aNPuF/lcK+QqZnsDi5o2lY3QXNA00CZ4k3on7biQ7pBQE?=
 =?us-ascii?Q?99Qp72P8POQ7YZrBMN4O5PeAtSMHdSqy2Um6nF+6v2T3/WKNf3At7RT/RxDa?=
 =?us-ascii?Q?/bWvtc1tKdwoHT4mXhYTUhV9mvtSuLfWICBYIMjhi4hsHvGU7tCZdKiiw4xD?=
 =?us-ascii?Q?7qlNDj/ldWnjNAipUubRPEINLHPdZZ958D2dl0nQRfD4sVM9BmFy0DexIb5q?=
 =?us-ascii?Q?P0YCtEgf06Ubm3vitvwhrr/pTW0Td6ttlsl9n067drwyZTNqAaIE4ODexKeo?=
 =?us-ascii?Q?Wu0+JNm3eyPv/OiuciYNciAQ9DYDoFu+CUJu9mwg33hT+508VxYiJLfGEk9x?=
 =?us-ascii?Q?qRY8f3GHgDmt4FZ32qqhPwd1pnGYSjOjDYwkPfZU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 724fb791-6c3c-44d8-b876-08da7453ddf9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 06:54:38.4240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /4WQL0JM29k7MSj3YETR2EnHPZaxwWnpuvBfH8FoT82aAQx/nw3FrM7MguE9DNxtKEwwZ9dod8GiKtfXbdt7wQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3322
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2022 at 10:23:23PM +0800, Vlastimil Babka wrote:
> On 8/1/22 08:21, Feng Tang wrote:
[snip]
> > Cc kansan  mail list.
> > 
> > This is really related with KASAN debug, that in free path, some
> > kmalloc redzone ([orig_size+1, object_size]) area is written by
> > kasan to save free meta info.
> > 
> > The callstack is:
> > 
> >   kfree
> >     slab_free
> >       slab_free_freelist_hook
> >           slab_free_hook
> >             __kasan_slab_free
> >               ____kasan_slab_free
> >                 kasan_set_free_info
> >                   kasan_set_track    
> > 
> > And this issue only happens with "kmalloc-16" slab. Kasan has 2
> > tracks: alloc_track and free_track, for x86_64 test platform, most
> > of the slabs will reserve space for alloc_track, and reuse the
> > 'object' area for free_track.  The kasan free_track is 16 bytes
> > large, that it will occupy the whole 'kmalloc-16's object area,
> > so when kmalloc-redzone is enabled by this patch, the 'overwritten'
> > error is triggered.
> > 
> > But it won't hurt other kmalloc slabs, as kasan's free meta won't
> > conflict with kmalloc-redzone which stay in the latter part of
> > kmalloc area.
> > 
> > So the solution I can think of is:
> > * skip the kmalloc-redzone for kmalloc-16 only, or
> > * skip kmalloc-redzone if kasan is enabled, or
> > * let kasan reserve the free meta (16 bytes) outside of object
> >   just like for alloc meta
> 
> Maybe we could add some hack that if both kasan and SLAB_STORE_USER is
> enabled, we bump the stored orig_size from <16 to 16? Similar to what
> __ksize() does.

How about the following patch:

---
diff --git a/mm/slub.c b/mm/slub.c
index added2653bb0..33bbac2afaef 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -830,6 +830,16 @@ static inline void set_orig_size(struct kmem_cache *s,
 	if (!slub_debug_orig_size(s))
 		return;
 
+#ifdef CONFIG_KASAN
+	/*
+	 * When kasan is enabled, it could save its free meta data in the
+	 * start part of object area, so skip the kmalloc redzone check
+	 * for small kmalloc slabs to avoid the data conflict.
+	 */
+	if (s->object_size <= 32)
+		orig_size = s->object_size;
+#endif
+
 	p += get_info_end(s);
 	p += sizeof(struct track) * 2;

I extend the size to 32 for potential's kasan meta data size increase.
This is tested locally, if people are OK with it, I can ask for 0Day's
help to verify this.

Thanks,
Feng

> 
> > I don't have way to test kasan's SW/HW tag configuration, which
> > is only enabled on arm64 now. And I don't know if there will
> > also be some conflict.
> > 
> > Thanks,
> > Feng
> > 
>