Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2396193imn; Tue, 2 Aug 2022 00:47:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v92oqCTb6aVTstYCJkLBI3uSycDu6a4P3jrVTbribt+mIB6fAfTdpDtrUi03aS0coWJREH X-Received: by 2002:a05:6a00:21c2:b0:52b:ff44:6680 with SMTP id t2-20020a056a0021c200b0052bff446680mr19926824pfj.57.1659426446997; Tue, 02 Aug 2022 00:47:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659426446; cv=none; d=google.com; s=arc-20160816; b=sJLF+HJG36S83SN1ShQNMq+oYyQ/4d0s95xN6lkeM9jtbM1054I/r8bE5NqlsWGmzJ eIZMDhFAN4GW4vePiptLEAOlY5PxQO3oY22NCO982/O+2wF+3yAbJOSZxip7kCvBHitf xiULH+Qh2sleSPImNAx/BjgZU3hN0THCKSRBQnYGiUYOsVS6h1dl6ZFGpu9zSyILOEKr lzvhJQBGk5Re5QJqJC+zDbUeuOIczA7B1iUAhH0BH/tiQvR2acC5er5VbHF9WV1YCscQ Xw5ToZvwSW2s35QwD/LKNpoDK+x3RSj6VsfGDEQ2+Ya6MYaBxCcEw9pSDYiOY9xpytZt dqDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=l0q+QYiG/Eqa3mATE+vLJIuo/ItC1B0Gui0igDzgwt4=; b=GTqzJgtuy9/J9geHquXI5ICNo3LciARwnhW7wElfd1jeezkrDZQXWIpJa/uyA8dbJA dSLruN6R5fRyYha81Ja1BAshGTZ6jSztvd1OCzm4m85g9zlPHLzGhisQY3gczt+2YPig qkj2GNXfFF+NnXHt98/yyK26CW7cHRkPckccHCYQNALolrZ9f7vlwzYHu+ycZkM2n/ep HJfPQWf6EtBYXr/txkvidAv1xmfy/nwqEtjuS6esCR+HtmQrT1iHjFlIA46t8cPqZwL8 zx52t+0cP8X8sxgrkLQSoaAFUzZAXM7ECgwaJpFiwcY8YTnU5oReXurmRquyHQ3vRT3D nD+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=UuR1oIOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr1-20020a17090b4b8100b001f51b9f1b12si2804407pjb.160.2022.08.02.00.47.13; Tue, 02 Aug 2022 00:47:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=UuR1oIOZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235991AbiHBHiM (ORCPT + 99 others); Tue, 2 Aug 2022 03:38:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236008AbiHBHiD (ORCPT ); Tue, 2 Aug 2022 03:38:03 -0400 Received: from mail-m971.mail.163.com (mail-m971.mail.163.com [123.126.97.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 24296E008; Tue, 2 Aug 2022 00:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=l0q+Q YiG/Eqa3mATE+vLJIuo/ItC1B0Gui0igDzgwt4=; b=UuR1oIOZkpDf12FOYjgYW RIddEflkNmVKmZRjpsA5uPYeWwlAMLZs8ys8V/uv9ENXEx6ipjji8FKO1jJqCq6L hNx4FQ8a0i1e/05vATssKO7SEWGXnhNgfJkU4APJYpXsbI6aiXz18Wh4W+7ISt8W IYxcjeZEWyX9ePq+EoF08k= Received: from localhost.localdomain (unknown [123.58.221.99]) by smtp1 (Coremail) with SMTP id GdxpCgCXJZbw0+hiFYdnSA--.5473S2; Tue, 02 Aug 2022 15:36:18 +0800 (CST) From: studentxswpy@163.com To: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Xie Shaowen , Hacash Robot Subject: [PATCH] scsi: sun3x_esp: check the return value of ioremap() in esp_sun3x_probe() Date: Tue, 2 Aug 2022 15:36:14 +0800 Message-Id: <20220802073614.3213171-1-studentxswpy@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: GdxpCgCXJZbw0+hiFYdnSA--.5473S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xw4DCrW8tF47XFW8JryfXrb_yoWfWwc_Wa 1Svrs7WF4Yyw1xtF17Cwn8Z34Ikr1kZr4kuF1FqFy3Cw1UZ3WDXa9F9rn7ua45WaykGayF y3s0vF4Fv34SgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8JGYJUUUUU== X-Originating-IP: [123.58.221.99] X-CM-SenderInfo: xvwxvv5qw024ls16il2tof0z/xtbB0wpRJFXlwVHQtwAAsr X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie Shaowen The function ioremap() in esp_sun3x_probe() can fail, so its return value should be checked. Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache") Reported-by: Hacash Robot Signed-off-by: Xie Shaowen --- drivers/scsi/sun3x_esp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c index d3489ac7ab28..cc670b50a357 100644 --- a/drivers/scsi/sun3x_esp.c +++ b/drivers/scsi/sun3x_esp.c @@ -199,6 +199,8 @@ static int esp_sun3x_probe(struct platform_device *dev) goto fail_unmap_regs; esp->dma_regs = ioremap(res->start, 0x10); + if (!esp->dma_regs) + goto fail_unmap_regs; esp->command_block = dma_alloc_coherent(esp->dev, 16, &esp->command_block_dma, -- 2.25.1