Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 15:46:47 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Dmitry Vyukov <dvyukov@google.com>
CC:     Vlastimil Babka <vbabka@suse.cz>,
        "Sang, Oliver" <oliver.sang@intel.com>, lkp <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Christoph Lameter" <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "John Garry" <john.garry@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: [mm/slub] 3616799128:
 BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
Message-ID: <YujWZzctbp1Bq25N@feng-skl>
References: <20220727071042.8796-4-feng.tang@intel.com>
 <YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020>
 <YuY6Wc39DbL3YmGi@feng-skl>
 <Yudw5ge/lJ26Hksk@feng-skl>
 <0e545088-d140-4c84-bbb2-a3be669740b2@suse.cz>
 <YujKCxu2lJJFm73P@feng-skl>
 <CACT4Y+Zwg8BP=6WJpQ5cCbJxLu4HcnCjx8e53aDEbTZ5uzpUyg@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CACT4Y+Zwg8BP=6WJpQ5cCbJxLu4HcnCjx8e53aDEbTZ5uzpUyg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6star+EqjT9b0enhGP2zLaRdcJ65xgmHma39fxnwtmGIaaHO7Ljxx6QyOpiO?=
 =?us-ascii?Q?1jkBL9FhSz0c8AsZ+72LTmFWnJNlUplD24u5BqF7TnMGiM46kUHHSxXCyphR?=
 =?us-ascii?Q?EA9nLx40N/8D7rZymo+NxMIqcEQW/KjPJMccAd9Mut/XyO8VJoBI3w8PSDE6?=
 =?us-ascii?Q?CuKo+juK6Go6aldSPCnKIRDFpWeH0wGNGRZdKXd88nWSbS/qs0TTjWk4Jt6l?=
 =?us-ascii?Q?lPeVzA9C8+gKAHGBi0rfxBy7DvyVoS/hOD5CpMXeE8cQ/P7790xaZJBK8Y5h?=
 =?us-ascii?Q?6l1eKM/qb3s8V8/viiykm1hmzdDK6mgFYmbb4+Lg55ocMMVXSiF/Ch5RpbQL?=
 =?us-ascii?Q?h1Kdvn6q7AUjVpkoJP30b5thZ/C2R8KfZSaZS7bSQVz94kuWVZwcXPnoBOja?=
 =?us-ascii?Q?4mPdg6RDwT77PzkPuDtAp6QEcYOkHI/hZqHjLA934nk68CypKyvsQhQamx5A?=
 =?us-ascii?Q?vx0EPEDkONkVSll2P5VGyclnFGLjCjADcujn5JhO7UutuHnpRZej88Zo/ri9?=
 =?us-ascii?Q?mSX8rfclcOn5IIhh4R3SEp56WaXMeuqFJyuGy34tUaQAh4YPl75b69WLyv27?=
 =?us-ascii?Q?2ZmBc4NdKlWhLvhhMZLP/iMJC3uAcXJgQRcfjuero9Vq/fx7+CmQ1Mfa0AGj?=
 =?us-ascii?Q?bCqc14YlrtrOG7Y7PNDguj09Or3mJ9UYby7IMBWwTI4Ky7ZBUssrC6hJBftj?=
 =?us-ascii?Q?pCCiVFNNh356bdKY1cKzS+kHClLrtzb96XSDi0MdHdISP9CppMnDxQwHPLfX?=
 =?us-ascii?Q?AorNCO3ZsESsBSa9RPJcz3zZroeVFot7vNxnSANPbSyW7m/HKv7Ngh4vGbnC?=
 =?us-ascii?Q?FaGg9vDsx0+N+fMaPjpdqLe7TuwArXgpNPi1sgZ+qnMwfWfUbE182Wrw+lmB?=
 =?us-ascii?Q?rPv3d9+VPbq39IAQFPDTMJEYXiF+wn/TlOorjslAqcDHbmn/xvCcOsWAqXZs?=
 =?us-ascii?Q?vwJyef7A98jtmDky/rZH+WZrKgRWUsNZZJTKrqQi5rrtc1Omz3pSfe+PkRZ3?=
 =?us-ascii?Q?GNg3sxFQ8ZTCLr1y6JEw96+r4ehgS3amHgu7b9KJI5piWC7/itW29wf2SVQ2?=
 =?us-ascii?Q?OVOID4zQEoJHuVHb6RlOMns7GuV2C1Jd2qh4vPcFlULM41ezJCDNGk9kExBo?=
 =?us-ascii?Q?xRK7Il+HtTB+CoD4ZwraKSoLmfsfYHEk6Z89GgFBsjrfMsGXDCxuJsHRqhYn?=
 =?us-ascii?Q?E4FznKFHPLvPDwkopF9P4YqfVqtD/d2K7o4qg58sOEizBrDMqEs05YvqNI0o?=
 =?us-ascii?Q?+rmvAS7YembwN4FHxW+2gGVe04cinw9AlpSNqBat+MkSwW12jx9teMfLcoR2?=
 =?us-ascii?Q?j49zsmPDxdhJmQSuLocUEBHoYg6D7eVjf6rEJA+O+KgTY/niSd2npuZHG1ES?=
 =?us-ascii?Q?RcrBpTrqM7CuZkKjEJ6HQw9Q83iDJb5FxYMnnDhmPp+AktKn2e2mt+QuknjQ?=
 =?us-ascii?Q?o7RcZvzpMOajJX9q9pXzV0i7hpmcK96hyOgYG4R8U81U6Kry10xt6uHGxC2v?=
 =?us-ascii?Q?yYOAu4HEHQYoGJBV6DqbILIpcfa/kw9Ws3ircsW7aip+/nqh//kV4jdi+Xwk?=
 =?us-ascii?Q?ZMk3D9ucBa87B54Fd/qQuPB6EV1bduPyuyKJonxf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd9a9811-45f8-4b3d-231f-08da745b38db
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 07:47:17.2327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KQF5fPTwPCjKtYoc1Bde98AMk8oJDRGoP7X4MsJptLomHGzBS+HCxhPwG+tr9ll9xIbf8XqzEOwDgfUlFqjUHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4120
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 02, 2022 at 03:06:41PM +0800, Dmitry Vyukov wrote:
> On Tue, 2 Aug 2022 at 08:55, Feng Tang <feng.tang@intel.com> wrote:
> >
> > On Mon, Aug 01, 2022 at 10:23:23PM +0800, Vlastimil Babka wrote:
> > > On 8/1/22 08:21, Feng Tang wrote:
> > [snip]
> > > > Cc kansan  mail list.
> > > >
> > > > This is really related with KASAN debug, that in free path, some
> > > > kmalloc redzone ([orig_size+1, object_size]) area is written by
> > > > kasan to save free meta info.
> > > >
> > > > The callstack is:
> > > >
> > > >   kfree
> > > >     slab_free
> > > >       slab_free_freelist_hook
> > > >           slab_free_hook
> > > >             __kasan_slab_free
> > > >               ____kasan_slab_free
> > > >                 kasan_set_free_info
> > > >                   kasan_set_track
> > > >
> > > > And this issue only happens with "kmalloc-16" slab. Kasan has 2
> > > > tracks: alloc_track and free_track, for x86_64 test platform, most
> > > > of the slabs will reserve space for alloc_track, and reuse the
> > > > 'object' area for free_track.  The kasan free_track is 16 bytes
> > > > large, that it will occupy the whole 'kmalloc-16's object area,
> > > > so when kmalloc-redzone is enabled by this patch, the 'overwritten'
> > > > error is triggered.
> > > >
> > > > But it won't hurt other kmalloc slabs, as kasan's free meta won't
> > > > conflict with kmalloc-redzone which stay in the latter part of
> > > > kmalloc area.
> > > >
> > > > So the solution I can think of is:
> > > > * skip the kmalloc-redzone for kmalloc-16 only, or
> > > > * skip kmalloc-redzone if kasan is enabled, or
> > > > * let kasan reserve the free meta (16 bytes) outside of object
> > > >   just like for alloc meta
> > >
> > > Maybe we could add some hack that if both kasan and SLAB_STORE_USER is
> > > enabled, we bump the stored orig_size from <16 to 16? Similar to what
> > > __ksize() does.
> >
> > How about the following patch:
> >
> > ---
> > diff --git a/mm/slub.c b/mm/slub.c
> > index added2653bb0..33bbac2afaef 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -830,6 +830,16 @@ static inline void set_orig_size(struct kmem_cache *s,
> >         if (!slub_debug_orig_size(s))
> >                 return;
> >
> > +#ifdef CONFIG_KASAN
> > +       /*
> > +        * When kasan is enabled, it could save its free meta data in the
> > +        * start part of object area, so skip the kmalloc redzone check
> > +        * for small kmalloc slabs to avoid the data conflict.
> > +        */
> > +       if (s->object_size <= 32)
> > +               orig_size = s->object_size;
> > +#endif
> > +
> >         p += get_info_end(s);
> >         p += sizeof(struct track) * 2;
> >
> > I extend the size to 32 for potential's kasan meta data size increase.
> > This is tested locally, if people are OK with it, I can ask for 0Day's
> > help to verify this.
> 
> Where is set_orig_size() function defined? Don't see it upstream nor
> in linux-next.
> This looks fine but my only concern is that this should not increase
> memory consumption when slub debug tracking is not enabled, which
> should be the main operation mode when KASAN is enabled. But I can't
> figure this out w/o context.

Yes, the patchset was only posted on LKML, and not in any tree now.
The link to the original patches is:

https://lore.kernel.org/lkml/20220727071042.8796-1-feng.tang@intel.com/t/

Thanks,
Feng