Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2409688imn; Tue, 2 Aug 2022 01:29:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR5DopXdbPZLNL5COC/VSBu1loE5aefI2MsZyI/K9vZUwGtIhYrE2s5N9fn5kMCWSK3ltxpF X-Received: by 2002:a05:6402:3323:b0:43d:65fc:8d29 with SMTP id e35-20020a056402332300b0043d65fc8d29mr13264530eda.251.1659428967121; Tue, 02 Aug 2022 01:29:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659428967; cv=none; d=google.com; s=arc-20160816; b=yAFnUmWvgt6MJ1Xx+Odxp+nkbz/+saSi7wEGdOcf0ABtIuSkG8Pi+8rWsIYdRJfRFO A3NB1dZjOtJgBwe4n2IKLongY1LC4+sXdb1qg/E1fp8ZBRsdg1CPmeGPKGoMKQA6bBPL 5p68tz+e5YaWJ8yxVTTegcUHjgoDUQHADeKW+NWN1Eurnylg4UhOxzttmPw41Jopy4xU Itiq8aFfstb8/ZdGCQNNUufJxcE51sjXWQIYLDiGgJn2NMooWCSlY5lKU3CmgoHlhqcj oM38lUucQmCimEv/tgka89FayTFp7pBMUfB0MLbwYbZgbc4zsOKu2BtNINfJ8O42cglO WdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=OdSBCPIRoOiFck0jwTh7RdSR6UYy7WHwx+8EVevXMbM=; b=xBJcoaKuc3c06denrF8fwJvYkmSMOEK9ATaPFnafio4/+cO26UYIAq+WrUc1HkZdaN f4vScohv9Oo4BebUw4lXRuBr0f6HGMmXs0EY+ccOMekxvDnkUzCBNaworHmw0d/jMS9C pT8QSMknyUxz9DAL/CfSWLAmBEaok0PFMTyocekWDJKjjZW31Vg+0yO2RJ3nKG2etEx1 XhZrFwpkA79mJG/Eboejq8XZY3RMKv461tHv+Ip6MBxdX7sm1tMHmXajIXd6nqHRjuGB rH+Y//ZmPQH/wwu5m9sPHoBXf8TzS+rASJuaFuQmzZqwrRNZW4FurmGSe172G/LZ/tR7 lhow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz5-20020a1709072ce500b00730870cb4b6si5071972ejc.621.2022.08.02.01.29.02; Tue, 02 Aug 2022 01:29:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236204AbiHBIKQ (ORCPT + 99 others); Tue, 2 Aug 2022 04:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235653AbiHBIKP (ORCPT ); Tue, 2 Aug 2022 04:10:15 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E2526D5; Tue, 2 Aug 2022 01:10:13 -0700 (PDT) Received: from mail-ed1-f51.google.com ([209.85.208.51]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M5gAG-1oLVk13t9e-007C6I; Tue, 02 Aug 2022 10:10:11 +0200 Received: by mail-ed1-f51.google.com with SMTP id w3so963814edc.2; Tue, 02 Aug 2022 01:10:11 -0700 (PDT) X-Gm-Message-State: AJIora+2O9gaY5hbZ4oqjC8Wr8sYFyeQYvMGdO4Xq8Pbo9h1WReQsomp sJN+UWWh7lyV87B9Uq7sYmuO8D0d5mZ2Sf4P13k= X-Received: by 2002:a05:6402:3693:b0:43d:1a40:21fd with SMTP id ej19-20020a056402369300b0043d1a4021fdmr18891990edb.206.1659427811579; Tue, 02 Aug 2022 01:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20220802020819.1226454-1-sunliming@kylinos.cn> In-Reply-To: <20220802020819.1226454-1-sunliming@kylinos.cn> From: Arnd Bergmann Date: Tue, 2 Aug 2022 10:09:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static To: sunliming Cc: Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , LINUXWATCHDOG , Linux Kernel Mailing List , kelulanainsley@gmail.com, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:ufX2SafejYawHSK04SlcPYS2TjNFODc8KLsqVGlZiglCrGNASBx 3zdNsDpereppXx9l0yNr5sAdrKeprzrhHUNv7pm71fySGHnR0c1ZAadQlkxcMFRohnerap9 doRNydqZi951ON1NQtXVT6QNn0Eh8/JxodXy1AmvcBccvSLO6e2ofsXJhLqTmdC5unqv9hY /Nm3bwLtvQC1MR2Envkbw== X-UI-Out-Filterresults: notjunk:1;V03:K0:QwvWEWBpm+g=:VRsJuzbhfDYZ8Xx8Tmmrmh WVq0prnpdh7yRtZp4KMC4CPhzNLXDvgqU7KUe3h5H3SaQCoG+pBRAa3nLcL0N/Ll+erIqbker wnKspT+hLzwBu5BTutUOUY/TDVT2YgXWG4XOi9o4GwTB8V4K+6/1mNkasBY9wQ3E/yAV4lcMN F5wmwie7UOt36eaXQEJIqQJMUAErAUlNZe17XMUkyaH82SToz1CYa+bPfhQHDnHsmpC2siuwl dBGI6kE9CfL8SxkexHA18kj8ReMmGDgOP1tFx4Qldbo1jttnEzEx7q3OjXKfr0LfaPpaQeuea lMlBV7AaheAnF+cKk+cDl1N0dIxdxgokrUKRvY+67YBBo9v5NSqLgF0ci8i9pUuMYai3F1yKv O4hjoCr/iEZbaDOnPejFhsZBVjt8OFgZ20E+hgDQcVYbldDVJ6aOi8/iZ9SJewPamdw/9iWPQ hPT20IXVaA/WMieO1sK30werqJ5fzwvJh33dIVLnxtOfOFff1tTU6eHlOOffXVextxAmeJr4G YdEIX52UU+99vmzRcWiVU32ZOZ1LIafWW/Q0b21NxNtmQbOYkGfRZkK6nNSsWpu5X7vxsZSta lQxZ8TV7Wwe6Mg/qNhERB/ZNLwDmSLtNhPvg188EOgnRo3T5RgxEv/qd0KV5F1L1ubngqnedq Nx8XlBjZb3FraQ44/D5nNtchGVZAvrfM13IQ8UJnne7Al/OKX9FVhhH7lLgXsXyVed3nWy8fx H8shiRC5hWEAMykk6Z1vr75LtWQJL1Tsac4xWQ== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 2, 2022 at 4:08 AM sunliming wrote: > > This symbol is not used outside of sa1100_wdt.c, so marks it static. > > Fixes the following warning: > > >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver' > was not declared. Should it be static? > > Reported-by: kernel test robot > Signed-off-by: sunliming Acked-by: Arnd Bergmann