Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2414446imn; Tue, 2 Aug 2022 01:43:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sGJwU29mT2ZSa38r6+tcpc+4jz8Fy3QueQ+2GSh5MBtTEVldgP3p//YeNctBE/XxWdFUE+ X-Received: by 2002:a05:6402:3509:b0:43b:f09d:6517 with SMTP id b9-20020a056402350900b0043bf09d6517mr19828694edd.66.1659429830440; Tue, 02 Aug 2022 01:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659429830; cv=none; d=google.com; s=arc-20160816; b=IX3CFboCC5NnuUKtGy8PWwjZ4pTRdR20PTQWpaD2LvKjaaQE3LBzMrPcoLlAhyC9Lv iufhGplxN6Sgy4DWJdCT+A0D2fBArCS5X2BrDL6oGkRIZxCbKWr2Ll7LbPFDdmGrci7Y mqlhNl67HOCI1GUJ98v/8bSb0AppTXT5e50waWp6wjokbA+NmVFwdBOW9ZOTHoTiNV4/ 1D+HGCgX5f8Pr6iBMZpm+ebfbTQph0K8MP8VQzg/DwdqceY3oVQQAhI8i6JnC9uhJf+n 8UbQWw7w+3XzB3PDMTl/JRCGMP3ZAZINnthUObRyUqVrLB96ePP40WEoy0M3zZ3grEEk yluw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8coOzfONG0+Ewy5HXZVWYPVuqOi18EON1F7O34DgPQY=; b=d9oX9M6lZweGi2RLbIKjOibfq0fkn7Fd0dgTpav/1KmnOeVu6uCpef1G20FGN+ELzY l6ff7RUjrUzKbW+EN51G2aDsk6YwgkqeTzqSbDtgaGE5Me/KFczAZ4PCA2iVRyR538bS DUT1iFCAJb+f7SLBw1Ykb0Ii0zGZiCNjdKl1eMGQAg9UaicLyVRbPFTIqJ+MEe5A6Htc bC4YqKXSDwIGwJ08p8s7MdkWga9pkvRNqBueLtAHCdr5WtcK5hXdxa54iLQ7vjURis0R LW7xEW41ME+jPQ74hu5CVTXc+GDnmYmjIrxO/Ro2A0jTlmi6MuoaOlG40TCuANJMhazn qKOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VBMYxzC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp18-20020a1709071b1200b007269f9395d7si5371920ejc.482.2022.08.02.01.43.25; Tue, 02 Aug 2022 01:43:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VBMYxzC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236419AbiHBITX (ORCPT + 99 others); Tue, 2 Aug 2022 04:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236413AbiHBITU (ORCPT ); Tue, 2 Aug 2022 04:19:20 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B637D3CBFC; Tue, 2 Aug 2022 01:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659428359; x=1690964359; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=z+vewyv6+8WMMh7FJKU7WpWGSmrkNzmBg1CxJQHgUEc=; b=VBMYxzC9CJyx4zALFWExBavfMKOFcj51Fn5Y3TmLYQ2bNGbWzU6gjyHW vobJ+4GB8TDgIFe6oy8gd9Awzlbf13sGm26IqG4eGDROA3fLC9sVw6/BV +HcXSFqJSmY5XBqEFCnRIo27RxIqIt3YRrqN2HuPHFC+Rc/rJIpeopWYb jDEW1wRy9k1jX7BBRON0fCcpwmmjt7VTufHpNMPocdW2nOyDNQ2bo97Em iQn1tEiOCr/DEJ+NaGTmuDQtCmDZCBqqJ9SL5nZtZl+Z2emi4wl/Bh0iI /cLYXgVuiJr5TUfHngg7iuv0vAMVGRQwm+C1+9JpmzjmFzPSYy0hoRoAn A==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="286913667" X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="286913667" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 01:19:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="744587113" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 02 Aug 2022 01:19:16 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 02 Aug 2022 11:19:15 +0300 Date: Tue, 2 Aug 2022 11:19:15 +0300 From: Heikki Krogerus To: Gene Chen Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, gene_chen@richtek.com, cy_huang@richtek.com Subject: Re: [PATCH v3 4/7] usb: typec: tcpci_rt1711h: Add initial phy setting Message-ID: References: <20220801101447.86207-1-gene.chen.richtek@gmail.com> <20220801101447.86207-5-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220801101447.86207-5-gene.chen.richtek@gmail.com> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gene, On Mon, Aug 01, 2022 at 06:14:44PM +0800, Gene Chen wrote: > From: Gene Chen > > Add initial phy setting about phy dicard retry, > rx filter deglitech time and BMC-encoded wait time I'm sorry, but what does "deglitech" mean? Is it just a typo? > Signed-off-by: Gene Chen > Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c > index df7bfe299987..33d8ea95b7c1 100644 > --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c > +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c > @@ -20,6 +20,9 @@ > #define RT1711H_VID 0x29CF > #define RT1711H_PID 0x1711 > > +#define RT1711H_PHYCTRL1 0x80 > +#define RT1711H_PHYCTRL2 0x81 > + > #define RT1711H_RTCTRL8 0x9B > > /* Autoidle timeout = (tout * 2 + 1) * 6.4ms */ > @@ -107,8 +110,18 @@ static int rt1711h_init(struct tcpci *tcpci, struct tcpci_data *tdata) > return ret; > > /* dcSRC.DRP : 33% */ > - return rt1711h_write16(chip, RT1711H_RTCTRL16, 330); > + ret = rt1711h_write16(chip, RT1711H_RTCTRL16, 330); > + if (ret < 0) > + return ret; > + > + /* Enable phy discard retry, retry count 7, rx filter deglitech 100 us */ > + ret = rt1711h_write8(chip, RT1711H_PHYCTRL1, 0xF1); > + if (ret < 0) > + return ret; > > + /* Decrease wait time of BMC-encoded 1 bit from 2.67us to 2.55us */ > + /* wait time : (val * .4167) us */ > + return rt1711h_write8(chip, RT1711H_PHYCTRL2, 62); > } > > static int rt1711h_set_vbus(struct tcpci *tcpci, struct tcpci_data *tdata, > -- > 2.25.1 thanks, -- heikki