Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 16:44:31 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Dmitry Vyukov <dvyukov@google.com>
CC:     Vlastimil Babka <vbabka@suse.cz>,
        "Sang, Oliver" <oliver.sang@intel.com>, lkp <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Christoph Lameter" <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "John Garry" <john.garry@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: [mm/slub] 3616799128:
 BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
Message-ID: <Yujj76AGNMXOQIsN@feng-skl>
References: <20220727071042.8796-4-feng.tang@intel.com>
 <YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020>
 <YuY6Wc39DbL3YmGi@feng-skl>
 <Yudw5ge/lJ26Hksk@feng-skl>
 <0e545088-d140-4c84-bbb2-a3be669740b2@suse.cz>
 <YujKCxu2lJJFm73P@feng-skl>
 <CACT4Y+Zwg8BP=6WJpQ5cCbJxLu4HcnCjx8e53aDEbTZ5uzpUyg@mail.gmail.com>
 <YujWZzctbp1Bq25N@feng-skl>
 <CACT4Y+YEtmvR2KOW5P0VtbHatxdY7MT22hp9FrUOyjZiKR+BJw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CACT4Y+YEtmvR2KOW5P0VtbHatxdY7MT22hp9FrUOyjZiKR+BJw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UTPWD2wOWZ/NBO+Vp0mzl3/Cge+1N3yPczAmQjGE3VaZMlIBHsVNihuP9WZq?=
 =?us-ascii?Q?5F2rqvhsUSmOwvXfuRDPqvx5BK66FwLa59bNGhz6zuuT+9RSUDoiI+evAOq8?=
 =?us-ascii?Q?GSNuf8miqSJoyMGivYjTZEmOxZ3+bfuJ+qzQBK+zUv+PXUp3za2a0g+aopbw?=
 =?us-ascii?Q?LMRED4YVKkqYautSpcxMVUjbnjHLEhZ/KFXL9XG8tGJXK0CV8C8EJcvW53Jx?=
 =?us-ascii?Q?m6Pu520FSXe97wEVYvV0+UeZqyERyIT8XXWwwMrlKmfjcm0vocrJ16XlIBl/?=
 =?us-ascii?Q?NA8nq9+mj4Mf9u5eyvhYv43TpNZ4oROI+U1Uhq3QYAz+VfdGNHl4fo9yk8BA?=
 =?us-ascii?Q?f9Y4aKIfFhKkLIWX63xf38k0Mx26UVTZsg12aArR++bZCQo432KQGb6C6mm/?=
 =?us-ascii?Q?Xg9NB4dRVxXrJZwOPV3+4Hv2RV2uVPVZ52WUTjwN2GRe24/7zAdlP50gFRml?=
 =?us-ascii?Q?BT+fqiFzej0vm/j7z9t0lqnSX17bGhbdzOW74tunp6d8nNc6fj9pySzjJWU+?=
 =?us-ascii?Q?t4QYU58TvR/fvq25bQfp4WqGTNWvYi5oXhyO6Uy+ztcHgSZaondK12i2Kj9s?=
 =?us-ascii?Q?gxbAHnNlk4k89d/fyQ68R145HE5Qwr2MznsnB9oTp8Rnt215KsQrY5qqrZBV?=
 =?us-ascii?Q?qTkEbfVQepf6rcOpUbq0vyHN3EqYHSBb3dxRTdIIlPiH2/MxCkmrDMmyuazY?=
 =?us-ascii?Q?snmiGI+gADq+1M3Lx+XReFpjP+MNCBdsdy7JquOKDCcqvM24gVPxxB181JHQ?=
 =?us-ascii?Q?2bHa/BdQQl6aCofgxtBwAiyXDDWW4G2m3SPvpeIyGUMteh6Z04mOW6ZUqsJc?=
 =?us-ascii?Q?dE2qx4OaPjyrAa0w7384O6x45Bqa1/hr82400Wr09JbNwNMSMOxKPAhADkGd?=
 =?us-ascii?Q?TDqxH2U/B8nFHDr/ClxqXhGQ6kDfxyxSre/tfYqL4qDIRFctJSYtZOpumv2O?=
 =?us-ascii?Q?e7q7wDxSwZqRelg7dTLyb3uRpt0+V4SkyrSzY4txQ5t5BBAOE3hvWqCfLYRK?=
 =?us-ascii?Q?e+lFkOyEugXfTB8nhBG5KGeSTYynY6MqVpPVoAMkAFzkhXeT15zzWcC5Thah?=
 =?us-ascii?Q?3mOBy0kKEYutYoQAs2cmrryYSoRC13w2w0kMO0cedDPhYic+mcoGYymF5Ggc?=
 =?us-ascii?Q?qh4Sj3sL/R8lwELjvJwSqKZUxIA0N7HYCQqLUcrlAtxsj6zAyLHIgbwYMjb4?=
 =?us-ascii?Q?2R5rBGRT8p9+PrzqqgNYm+mCS48AK/hyBAI+UlSiYBbTpZd3cZevFY37DZj9?=
 =?us-ascii?Q?hFuGnGW7r4LUVvL6Nft4iZ1HQl5G6DVgHdvy0J8PTG92vErN+2DqE/XGQ8Mk?=
 =?us-ascii?Q?oN57wedONnp5cYpLXautaegdAewvIs7gv2FbLRZCb+zHxgNcLf1le96oJfzr?=
 =?us-ascii?Q?Fpnslsvim0TjzcqzqrxCfUF3HwoQriJIYva2pmSKGxGsmZYn+DHzghUQ5YX0?=
 =?us-ascii?Q?Y5gKClyx5eStQtgT4WRrs9iKi3WVEtzTFfUOW8kRqXXtDaAU4Ow2USuprR0V?=
 =?us-ascii?Q?/4bE/V/neARCnlO9wnh7WB3WVKH0nzKyO1WEBkIwrfawIde//Za+lCgWj6Ka?=
 =?us-ascii?Q?EzGeVdR9EYuIzcMpv43eN9xW3Xs/51kqYOx/DtmH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e62a59-7bc7-496b-024c-08da74635487
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 08:45:19.8359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cNEkWcqqfBL5dwttvt9S3Mmhvud6v86bF4SlKdlHwGKALu6vARLrBu7ybWEAA3xYKosI7/7TNrD2r3vBZqe7Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1777
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 02, 2022 at 03:59:00PM +0800, Dmitry Vyukov wrote:
> On Tue, 2 Aug 2022 at 09:47, Feng Tang <feng.tang@intel.com> wrote:
> > > > On Mon, Aug 01, 2022 at 10:23:23PM +0800, Vlastimil Babka wrote:
> > > > > On 8/1/22 08:21, Feng Tang wrote:
> > > > [snip]
> > > > > > Cc kansan  mail list.
> > > > > >
> > > > > > This is really related with KASAN debug, that in free path, some
> > > > > > kmalloc redzone ([orig_size+1, object_size]) area is written by
> > > > > > kasan to save free meta info.
> > > > > >
> > > > > > The callstack is:
> > > > > >
> > > > > >   kfree
> > > > > >     slab_free
> > > > > >       slab_free_freelist_hook
> > > > > >           slab_free_hook
> > > > > >             __kasan_slab_free
> > > > > >               ____kasan_slab_free
> > > > > >                 kasan_set_free_info
> > > > > >                   kasan_set_track
> > > > > >
> > > > > > And this issue only happens with "kmalloc-16" slab. Kasan has 2
> > > > > > tracks: alloc_track and free_track, for x86_64 test platform, most
> > > > > > of the slabs will reserve space for alloc_track, and reuse the
> > > > > > 'object' area for free_track.  The kasan free_track is 16 bytes
> > > > > > large, that it will occupy the whole 'kmalloc-16's object area,
> > > > > > so when kmalloc-redzone is enabled by this patch, the 'overwritten'
> > > > > > error is triggered.
> > > > > >
> > > > > > But it won't hurt other kmalloc slabs, as kasan's free meta won't
> > > > > > conflict with kmalloc-redzone which stay in the latter part of
> > > > > > kmalloc area.
> > > > > >
> > > > > > So the solution I can think of is:
> > > > > > * skip the kmalloc-redzone for kmalloc-16 only, or
> > > > > > * skip kmalloc-redzone if kasan is enabled, or
> > > > > > * let kasan reserve the free meta (16 bytes) outside of object
> > > > > >   just like for alloc meta
> > > > >
> > > > > Maybe we could add some hack that if both kasan and SLAB_STORE_USER is
> > > > > enabled, we bump the stored orig_size from <16 to 16? Similar to what
> > > > > __ksize() does.
> > > >
> > > > How about the following patch:
> > > >
> > > > ---
> > > > diff --git a/mm/slub.c b/mm/slub.c
> > > > index added2653bb0..33bbac2afaef 100644
> > > > --- a/mm/slub.c
> > > > +++ b/mm/slub.c
> > > > @@ -830,6 +830,16 @@ static inline void set_orig_size(struct kmem_cache *s,
> > > >         if (!slub_debug_orig_size(s))
> > > >                 return;
> > > >
> > > > +#ifdef CONFIG_KASAN
> > > > +       /*
> > > > +        * When kasan is enabled, it could save its free meta data in the
> > > > +        * start part of object area, so skip the kmalloc redzone check
> > > > +        * for small kmalloc slabs to avoid the data conflict.
> > > > +        */
> > > > +       if (s->object_size <= 32)
> > > > +               orig_size = s->object_size;
> > > > +#endif
> 
> I think this can be done only when CONFIG_KASAN_GENERIC.
> Only CONFIG_KASAN_GENERIC stores free meta info in objects:
> https://elixir.bootlin.com/linux/latest/source/mm/kasan/common.c#L176

Thanks for the catch!  will change.

> And KASAN_HW_TAGS has chances of being enabled with DEBUG_SLUB in
> real-world uses (with Arm MTE).

I only have device to test the kasan-generic mode, and not SW/HW tag.
But if there is conflict, we may have to apply the similar solution :)

> 
> > > > +
> > > >         p += get_info_end(s);
> > > >         p += sizeof(struct track) * 2;
> > > >
> > > > I extend the size to 32 for potential's kasan meta data size increase.
> > > > This is tested locally, if people are OK with it, I can ask for 0Day's
> > > > help to verify this.
> > >
> > > Where is set_orig_size() function defined? Don't see it upstream nor
> > > in linux-next.
> > > This looks fine but my only concern is that this should not increase
> > > memory consumption when slub debug tracking is not enabled, which
> > > should be the main operation mode when KASAN is enabled. But I can't
> > > figure this out w/o context.
> >
> > Yes, the patchset was only posted on LKML, and not in any tree now.
> > The link to the original patches is:
> >
> > https://lore.kernel.org/lkml/20220727071042.8796-1-feng.tang@intel.com/t/
> 
> Lots of code...
> 
> This SLAB_STORE_USER seems to be set on all kmalloc slabs by default
> when CONFIG_SLUB_DEBUG is enabled, right?

Christoph has explained in one earlier mail that CONFIG_SLUB_DEBUG only
compile in the debug support but not activate it. Option CONFIG_SLUB_DEBUG_ON
will enable it, and each slub debug flag bits can also be enabled 
by changing kernel cmdline for some or all slabs.  

> And KASAN enables CONFIG_SLUB_DEBUG, this means that this is stored
> always when KASAN is enabled? Looks wrong.

Thanks,
Feng