Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <efaa69fc-2402-9cc4-f7c8-86d6a93c6b02@redhat.com>
Date:   Tue, 2 Aug 2022 10:59:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] staging/rtl8723bs/core: remove inactive initialization
Content-Language: en-US
To:     Li zeming <zeming@nfschina.com>, gregkh@linuxfoundation.org,
        sevinj.aghayeva@gmail.com, fabioaiuto83@gmail.com,
        duoming@zju.edu.cn, keescook@chromium.org
Cc:     straube.linux@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20220802012513.2824-1-zeming@nfschina.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220802012513.2824-1-zeming@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/2/22 03:25, Li zeming wrote:
> The allocation address of the psta pointer variable is first performed
> in the function, no initialization assignment is required, and no
> invalid pointer will appear.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index f2242cf2dfb4..6498fd17e1d3 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2521,7 +2521,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr
>  {
>  	u8 issued;
>  	int priority;
> -	struct sta_info *psta = NULL;
> +	struct sta_info *psta;
>  	struct ht_priv *phtpriv;
>  	struct pkt_attrib *pattrib = &pxmitframe->attrib;
>  	s32 bmcst = IS_MCAST(pattrib->ra);