Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220722040609.91703-1-colin.foster@in-advantage.com>
 <20220722040609.91703-10-colin.foster@in-advantage.com> <CAHp75Ve-pqgb56punEL=p=PnEtjRnqTBSqgs+vVn1Zv8F94g9Q@mail.gmail.com>
 <YuiJLK8ncbHH3OhE@euler>
In-Reply-To: <YuiJLK8ncbHH3OhE@euler>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 2 Aug 2022 10:47:04 +0200
Message-ID: <CAHp75VcHU+Rh2ROjMcK+Yuyu1Ty9C0Dcx2SjrnrM4BV9NuMZig@mail.gmail.com>
Subject: Re: [PATCH v14 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip
 via spi
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa@kernel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 2, 2022 at 4:17 AM Colin Foster
<colin.foster@in-advantage.com> wrote:

...

> > I'm wondering if you can use in both cases
> > spi_message_init_with_transfers().
>
> > > +static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg_size,
> > > +                                     void *val, size_t val_size)
> > > +{
> > > +       struct spi_transfer tx, padding, rx;
>
> struct spi_transfer xfers[3] = {0};
> struct spi_transfer *xfer_tok = xfers;

unsigned int index;

> > > +       struct device *dev = context;
> > > +       struct ocelot_ddata *ddata;
> > > +       struct spi_device *spi;
> > > +       struct spi_message msg;
> > > +
> > > +       ddata = dev_get_drvdata(dev);
> > > +       spi = to_spi_device(dev);
> > > +
> > > +       spi_message_init(&msg);
> > > +
> > > +       memset(&tx, 0, sizeof(tx));
> > > +
> > > +       tx.tx_buf = reg;
> > > +       tx.len = reg_size;

index = 0;

> xfer_tok->tx_buf = reg;
> xfer_tok->len = reg_size;

tok[index] = ...;
index++;

> xfer_tok++;
>
> > > +       spi_message_add_tail(&tx, &msg);
> > > +
> > > +       if (ddata->spi_padding_bytes) {
> > > +               memset(&padding, 0, sizeof(padding));
> > > +
> > > +               padding.len = ddata->spi_padding_bytes;
> > > +               padding.tx_buf = ddata->dummy_buf;
> > > +               padding.dummy_data = 1;
>
> xfer_tok->len
> xfer_tok->tx_buf
> xfer_tok->dummy_data

tok[index] = ...

> xfer_tok++;

index++;

> > > +               spi_message_add_tail(&padding, &msg);
> > > +       }
> > > +
> > > +       memset(&rx, 0, sizeof(rx));
> > > +       rx.rx_buf = val;
> > > +       rx.len = val_size;
>
> xfer_tok->rx_buf
> xfer_tok->len

tok[index] = ...

> xfer_tok++;

index++;

> > > +       spi_message_add_tail(&rx, &msg);
>
> spi_message_init_with_transfers(&msg, xfers, xfer_tok - xfers);

..., index);

> > I'm wondering if you can use in both cases
> > spi_message_init_with_transfers().
>
> I could see that implementation getting the response of "what the heck
> were you thinking" or "that looks alright" and I honestly have no idea
> which pool it will fall into.

See above. I.o.w. use index based assignments.

> > > +       return spi_sync(spi, &msg);
> > > +}

-- 
With Best Regards,
Andy Shevchenko