Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6bb054d2-66c9-361c-bae6-c457b20d6870@prevas.dk>
Date:   Tue, 2 Aug 2022 11:45:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v8 02/31] kallsyms: avoid hardcoding buffer size
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        'Miguel Ojeda' <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>
References: <20220802015052.10452-1-ojeda@kernel.org>
 <20220802015052.10452-3-ojeda@kernel.org>
 <c2bdc599a30e4cb887aa97e7c9d0355a@AcuMS.aculab.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <c2bdc599a30e4cb887aa97e7c9d0355a@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkFDMGdCakd0QVJzVllUZVp6bXUrbG1SNWFvUjJtd0JRVHVyVGd2NmlnZGZM?=
 =?utf-8?B?bTR4Y2JSTUIzWkJVZVVTSEphQ0p3QVVrT2NwREdaeGE2eXcvWTVuVmE3K0JY?=
 =?utf-8?B?TmJ1YVI2ZkM1N09lMzZQbGpUa0tna21xMS84N1NQZ3dzdUFpSEh0WDY5ZEh6?=
 =?utf-8?B?cVhEbnp6WHl2dkE1cmdUbk5uL0tjOTFoL01tbWxjbm9pYlpuQTdpYjhxUHZU?=
 =?utf-8?B?NVNXakpIcVp4K2NtVUljZXVIek9FU0lteVdOQnFiV3p6bnBMdzBhUFdxNjZO?=
 =?utf-8?B?QURKbUdkV1VvTXduVFFvZUlKWWk4dFoyNlIvVEpJdTh4aVpSQUNxT20zVnlB?=
 =?utf-8?B?eU8rdHQ0cXdST2xyUGpsZE10cFpLNFdiSXNmY0ZvT1FBeHI1WXAyUU9aS0Y0?=
 =?utf-8?B?MDhCSDY4dkcyQi9yYUF1OEtSa0Z2SWxMUjYxb1R6QkJPcU5SYVdYWlZyd2hr?=
 =?utf-8?B?bElZSXBITzVZWXh6bkNaTUYybU9hSDJBd3pteGJsVjdIVWF6Z3FTcDkvMXhV?=
 =?utf-8?B?RU1xTG03bHFwM1VHU3VoZ20yWHh0bTdFMU9wZ2VBYzBFcG1SVG1sb2FyeEVX?=
 =?utf-8?B?V3hVY0t1TlN0T25HMFhqdGl2Vk5GMllMVUlVcFRaMkFnRGVMUFJSUEZDWE1w?=
 =?utf-8?B?dm45RVJBcGlTY1VQSHhBOEtrM3haTEx2UHpGNXhJdjFDYmt6emRseUZFN1Bz?=
 =?utf-8?B?Nld3MFJvODZpNEo3eEUzWmtzMGpHVCtsdEsyTzltMnNTWjk0MTU5K1l0VUNq?=
 =?utf-8?B?d1J3NkJxamxUbDlxOTBERTYva0tOVi9QQVZ0a3E3VW54Zk9OeU1aODRZdXZ4?=
 =?utf-8?B?czhlbzBWYm5vZVd4SFhPeTJsNTZzSFNlckM1YnIyTEFCS2FEblpIOXNEc2lB?=
 =?utf-8?B?TXlCV2p5dmUvLzdBOWJNd2xxVjJuYkE0MUtyRHUySDZZekF3YjFoMnZWMW84?=
 =?utf-8?B?bmNTNlBwd05hazQrMlUyV3p4Tzd5SjlYM1o4ZVNyNjI2a2lEY1pZdnkzWVpa?=
 =?utf-8?B?eHByc0kxNld1VnN5RHFTZ2R4RTBPQVBleFRSWHNGaWdjb0JsSERwRXluMlRi?=
 =?utf-8?B?M04xTUFRUzlDQWxKNmxpdFpxdXNSTzAzUXBTZDEzcjgzYUhRcGxNSmt3eVl5?=
 =?utf-8?B?V205eVBRVk91TVNKbmFHcEpOUXpuNzVTSisyWmN6bGozRFFUMy9nYnhxZVpG?=
 =?utf-8?B?aDNvcDZJa3M4dUQ0ejVZZkFzc0ZhUDdNYjZpeGU1dHM0ZkhSV29rQU9xSzRq?=
 =?utf-8?B?U1d2RDFrS1FhNXlGbWl4bndkMkVlQjV1bk5IaUdDR0tubUV6K1pDNHU4V0FN?=
 =?utf-8?B?VVpKQUFqUC9ueERiWGdmUUxYR0hyaWJydVprSEZJMGczOFk2aHVmZmtRL2lJ?=
 =?utf-8?B?a3NidGZmd1d2VDdqVEd4cHowVzJrbldKUE5YVjFETjdPYlg0NWNjRkNWSFhp?=
 =?utf-8?B?ajMyN3UxMzZteGM5V01qSTlwaHZCMTZPR3hEc2MraXJmelpFYVVjeTI3Q1Z0?=
 =?utf-8?B?eThaODRzTnVqUzJyaGxsdS9kOHh0Wmp3akVpUEJsdTMrN3ZQcmhHSTJtWDJP?=
 =?utf-8?B?cFRZLzJ6NysxZWYvYjg3Z0FFVkh5eWF4WlcyaVFGMWJNNzNib3VKdmxMUnV6?=
 =?utf-8?B?cENMUlIwTTBhYzRIbnJQSGx5OW15WVlHcWl4Nmt6UGh5ZVlpQjlXWXhVNng5?=
 =?utf-8?B?MTJHbHdjYXNTR08rQ2RJVmYvU0VZcjE2NEgrWHNaNFhYTXlnRENsWmp0bjZJ?=
 =?utf-8?B?bVVyT2ovSWU3dTBleWNTdWw1WHE4WFBMclk5dFNFQnRnREpGUzBscDZNaE16?=
 =?utf-8?B?NzNod2pwWnpLV0pHOXpOV3NSdzFVZEJhMXlXTXdyZ3dkUkNWYkxjR1gxb1dW?=
 =?utf-8?B?QkFTZk1wN25JMm1DTzFHUGFFVmVic1g4Z2M1enBaNFNmemovOUZvM0Z3cG5T?=
 =?utf-8?B?Qm9VejJXcjIxaDBYamVqTFJBcHBpQTlIM3NoNzZFdDJMcUNZc3VkNE5tUkQw?=
 =?utf-8?B?RVZOVnlkQ3RvUy9QbGVuU3JlRjN4SFF3K1JzSXhqM2w2c1IzZlhKZVpLR3Fn?=
 =?utf-8?B?NVJ4ZzRXN3lxTFFYZmJLdHJQTU90Q1BEc3FjZU91NHBwT0dQMGdFQ0ozUFE0?=
 =?utf-8?B?clZ4TlFPcTRwRlpJRzJ4aElkNGtwdTZ4eGVua2VUZTVmcm1kTXNuQVJPbWZw?=
 =?utf-8?B?a3c9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: a6c65fb8-09f5-4c6a-0219-08da746bb7e4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB5280.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 09:45:22.3092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KKUGTbFpoMf2WhSjioKVtCKjkyYTv2iXM81/qSOfCAsGs1wC7gwJgN37+LUIXbj4iZc4p9r9KJpYCTA2oGdLkatfFFuy1NTOlIvc0g6Y4Jo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4242
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/08/2022 10.29, David Laight wrote:
> From: Miguel Ojeda
>> Sent: 02 August 2022 02:50

>> -	rc = fscanf(in, "%llx %c %499s\n", &addr, &type, name);
>> +	rc = fscanf(in, "%llx %c %" _stringify(KSYM_NAME_LEN_BUFFER) "s\n", &addr, &type, name);
> 
> Think I'd use "%*s" - simpler.
> Although I normally completely avoid scanf() - too easy to get wrong.

Indeed, and your suggestion is a perfect example: for scanf, * doesn't
mean "there's an int argument specifying the 'precision'", quite the
contrary. man fscanf:

   •      An  optional  '*'  assignment-suppression  character:  scanf()
          reads  input  as directed by the conversion specification, but
          discards the input.  No corresponding pointer argument is  re‐
          quired, and this specification is not included in the count of
          successful assignments returned by scanf().

Rasmus