Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2464912imn; Tue, 2 Aug 2022 04:00:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR6miwF3UlPHN1WbWK2FpAbdWaC7AFYoe0XkXtmEj+qZviA0UWZkNZrUl0mTp5R+ub1RKR6G X-Received: by 2002:a17:902:d2c3:b0:16e:ea56:7840 with SMTP id n3-20020a170902d2c300b0016eea567840mr9403249plc.142.1659438033909; Tue, 02 Aug 2022 04:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659438033; cv=none; d=google.com; s=arc-20160816; b=zX2SxscVVhmhXXxpzyGXXKtLJ+2TXAovKlUU0r/m2dzBb2UWV05gwfmdELPxJpMZ+O gvKqKNEb8axIJHWvCGWXfpko5CbJupWOfxatW1Dv6blzOUXlP3JapJmjktVRQTIoHMay 7oL+kSlxE+bD1xlkPXBni2vL7tWhaEw8WwsOy8Xwo6s9FjseP5Qv4HNbMgBz2AXPibbg gjvFo9GJRbf0IJKQC1NxCQ46Fe1OmX36aJ0Z8Qk6RmWOllNpNci4g7BdXcqoEw8qhVfM DHW50MjcGvINWCj4r+oMG/7kBsmxNulxc7VIFhV6NMyawi/wgmgB11XW49HnxIgQOyQ4 PD5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TUaOXEFYI4/20pV6XLFl4RI3eF97HuwdB9C4aMQDG8o=; b=ozbJO2IlrEAZnKOFPx5HA9Eq3DvNJeyL1zr8T0zpFhUgnhg4z5z7ERa4V6wAmnFyuS IDytsJggcHV7uqD5hFixQL/3XW0EaPSgfg1FxSB6IZYF5ObDBMbaj/E6hbbJgKL5NRfh rcB94hWNZsocYRTFsTuKMPFL99V4lNp7vcKSjblMLjC3887u5F8wAd+E5O0uQYMhYTnJ cIsFo3G3T4BzOBOrOtNO4kQKafSl8pvjIthv4Nq9QpT4YDzN2flfCWFcViczVy/0ob8R V6pyi0e8qf8I07voRiE2mrmebldJ1JQhhpWm7cWzM/aa2PtHaTvGR+eS/0Mikg8XpvHs 13fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=PLf6T6q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j2-20020a170902da8200b0016bec53a672si17954503plx.477.2022.08.02.04.00.18; Tue, 02 Aug 2022 04:00:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=PLf6T6q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236514AbiHBKxm (ORCPT + 99 others); Tue, 2 Aug 2022 06:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbiHBKxk (ORCPT ); Tue, 2 Aug 2022 06:53:40 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2729167C8 for ; Tue, 2 Aug 2022 03:53:37 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B200B25B; Tue, 2 Aug 2022 12:53:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659437614; bh=w8AZJHqp+A9fn1ePAye0WrrjbAMpqA/lRUqJ3qO4C9E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PLf6T6q508gLjgspDip9CkpueQ+XlYkfgVC55ovdoqaOOc0ELjJLiQW0KsI/HqpNS g418Fy6Ajgis4ryKa+ZwH6zWBON4NLY8NWan+1YDmvxwE3XH/yGHeXbOp+pFJzlI35 eXIujlVMPgsaM9UOPIUexcLunmxP98DgcbskvrdA= Date: Tue, 2 Aug 2022 13:53:29 +0300 From: Laurent Pinchart To: Danilo Krummrich Cc: daniel@ffwll.ch, airlied@linux.ie, tzimmermann@suse.de, mripard@kernel.org, sam@ravnborg.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm-misc-next v7 1/5] drm/fb: remove unused includes of drm_fb_cma_helper.h Message-ID: References: <20220802000405.949236-1-dakr@redhat.com> <20220802000405.949236-2-dakr@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220802000405.949236-2-dakr@redhat.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Danilo, Thank you for the patch. On Tue, Aug 02, 2022 at 02:04:01AM +0200, Danilo Krummrich wrote: > Quite a lot of drivers include the drm_fb_cma_helper.h header file > without actually making use of it's provided API, hence remove those > includes. > > Suggested-by: Sam Ravnborg > Signed-off-by: Danilo Krummrich Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 1 - > drivers/gpu/drm/arm/malidp_drv.c | 1 - > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 1 - > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 1 - > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 1 - > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > drivers/gpu/drm/imx/ipuv3-crtc.c | 1 - > drivers/gpu/drm/logicvc/logicvc_mode.c | 1 - > drivers/gpu/drm/pl111/pl111_drv.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1 - > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 1 - > drivers/gpu/drm/solomon/ssd130x.c | 1 - > drivers/gpu/drm/sti/sti_drv.c | 1 - > drivers/gpu/drm/sti/sti_plane.c | 1 - > drivers/gpu/drm/stm/drv.c | 1 - > drivers/gpu/drm/sun4i/sun4i_drv.c | 1 - > drivers/gpu/drm/sun4i/sun8i_mixer.c | 1 - > drivers/gpu/drm/tidss/tidss_crtc.c | 1 - > drivers/gpu/drm/tidss/tidss_kms.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > drivers/gpu/drm/tve200/tve200_drv.c | 1 - > drivers/gpu/drm/v3d/v3d_drv.c | 1 - > drivers/gpu/drm/vc4/vc4_drv.c | 1 - > 26 files changed, 26 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 350ca4e4eaa6..b32168e3f9ae 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -26,7 +26,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index d5aef21426cf..fa6c1a4254dc 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > index 7780b72de9e8..54aa8af45829 100644 > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 7a503bf08d0f..4baa4977e473 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -20,7 +20,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c > index d763f53f480c..5b47000738e4 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c > @@ -6,7 +6,6 @@ > */ > > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > index 2af51df6dca7..e8b0fe970969 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > @@ -19,7 +19,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index 50fd7aac5198..e43345bd1346 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c > index f7863d6dea80..d9f832f952c2 100644 > --- a/drivers/gpu/drm/imx/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c > @@ -18,7 +18,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/logicvc/logicvc_mode.c b/drivers/gpu/drm/logicvc/logicvc_mode.c > index 11940704f644..c59da7039dc1 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_mode.c > +++ b/drivers/gpu/drm/logicvc/logicvc_mode.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c > index 19a4324bd356..5b5f3573b619 100644 > --- a/drivers/gpu/drm/pl111/pl111_drv.c > +++ b/drivers/gpu/drm/pl111/pl111_drv.c > @@ -48,7 +48,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > index 169ca0c8912f..ed887ebd2f6b 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 70d85610d720..110ec9538b44 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -20,7 +20,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 761451ee5263..7fed5b0c65ce 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/shmobile/shmob_drm_kms.c > index 68d21be784aa..edb003537530 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_kms.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_kms.c > @@ -9,7 +9,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c > index 77f80b0d3a5e..973ae2dfb2f8 100644 > --- a/drivers/gpu/drm/solomon/ssd130x.c > +++ b/drivers/gpu/drm/solomon/ssd130x.c > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c > index d858209cf8de..c0fbdb8cf6eb 100644 > --- a/drivers/gpu/drm/sti/sti_drv.c > +++ b/drivers/gpu/drm/sti/sti_drv.c > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c > index c74b524663ab..0a55180be22b 100644 > --- a/drivers/gpu/drm/sti/sti_plane.c > +++ b/drivers/gpu/drm/sti/sti_plane.c > @@ -9,7 +9,6 @@ > #include > > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c > index c63945dc2260..bb269dad30f9 100644 > --- a/drivers/gpu/drm/stm/drv.c > +++ b/drivers/gpu/drm/stm/drv.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c > index 6eb1aabdb161..382074ef1394 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c > index 4e9bd9cb6b36..b3d1c0940406 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -16,7 +16,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c > index ad4ce9d06622..92d2c25bb0ff 100644 > --- a/drivers/gpu/drm/tidss/tidss_crtc.c > +++ b/drivers/gpu/drm/tidss/tidss_crtc.c > @@ -8,7 +8,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c > index 666e527a0acf..b61db8f279e9 100644 > --- a/drivers/gpu/drm/tidss/tidss_kms.c > +++ b/drivers/gpu/drm/tidss/tidss_kms.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c > index 68a85a94ffcb..42d50ec5526d 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > > #include "tidss_crtc.h" > diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c > index 6d9d2921abf4..86ebfe626cd0 100644 > --- a/drivers/gpu/drm/tve200/tve200_drv.c > +++ b/drivers/gpu/drm/tve200/tve200_drv.c > @@ -39,7 +39,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c > index 8c7f910daa28..e8c975b81585 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.c > +++ b/drivers/gpu/drm/v3d/v3d_drv.c > @@ -22,7 +22,6 @@ > #include > > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > index 89975bdd607e..d33baf2667dd 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.c > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > @@ -33,7 +33,6 @@ > #include > #include > #include > -#include > #include > #include > -- Regards, Laurent Pinchart