Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 14:24:30 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 04/10] net: dsa: microchip: ksz9477: add
 error handling to ksz9477_r/w_phy
Message-ID: <20220802112430.7e7kpoqqlvxqrflf@skbuf>
References: <20220729130346.2961889-1-o.rempel@pengutronix.de>
 <20220729130346.2961889-1-o.rempel@pengutronix.de>
 <20220729130346.2961889-5-o.rempel@pengutronix.de>
 <20220729130346.2961889-5-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220729130346.2961889-5-o.rempel@pengutronix.de>
 <20220729130346.2961889-5-o.rempel@pengutronix.de>
Precedence: bulk

On Fri, Jul 29, 2022 at 03:03:40PM +0200, Oleksij Rempel wrote:
>  	} else {
> -		ksz_pread16(dev, addr, 0x100 + (reg << 1), &val);
> +		ret = ksz_pread16(dev, addr, 0x100 + (reg << 1), &val);
> +		if (ret)
> +			return ret;
> +
>  		ksz9477_r_phy_quirks(dev, addr, reg, &val);
>  	}
>  
> @@ -340,11 +344,9 @@ int ksz9477_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val)
>  
>  	/* No gigabit support.  Do not write to this register. */
>  	if (!(dev->features & GBIT_SUPPORT) && reg == MII_CTRL1000)
> -		return 0;
> +		return -ENOTSUPP;

I wonder if ENOTSUPP is the most appropriate error code, given that I
see it defined under a comment "Defined for the NFSv3 protocol".
How about -ENXIO?

>  
> -	ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val);
> -
> -	return 0;
> +	return ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val);
>  }
>  
>  void ksz9477_cfg_port_member(struct ksz_device *dev, int port, u8 member)
> -- 
> 2.30.2
>