Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2487033imn; Tue, 2 Aug 2022 04:54:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uK2k2KLoWwNYNMandFnfjrJnjsWSLPvFIZ4gB/YQ2FHLshIEJBVfzhlmT0zOuWGBF4zORw X-Received: by 2002:a05:6402:280b:b0:43b:5d75:fcfa with SMTP id h11-20020a056402280b00b0043b5d75fcfamr19872068ede.114.1659441299661; Tue, 02 Aug 2022 04:54:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659441299; cv=none; d=google.com; s=arc-20160816; b=OlyYLTEZNqatnMdViTbvEPYzRf4+t3HlUiNrNXD56ZFsF/IG9tLp6er76xQqgIAhG+ MIsh/b7XOfYuAfjUKHywLD9SaUbK62fDxYYg3WBmy+n8s2Mlo37A2Dp6uF1X67RVGnPW 0vwIwc3FzIz7vsx36uZuUOXXDqiBgWIPokr8mSo6osmstOOeoJI14wXZp/Q/laqW2lJb bsFCM2lI2ESzh7dku2yJpj9slAVOUdcurWodOfsJ4yowPbIKsD7+vD0PxrEM9drU52DZ tYW7PfJsLDFR6Y0caAifqVQulZne911Yq1u2ipUuIAxT3TlNGd16b6+QPGaUvtVN4dTs tk1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from; bh=9fDh/XeKIePhZhS1MA/ru6ev7sfarXCScrRImKLLfGs=; b=Olhz6p9n3MKF+naHKkQcoTvoUvwAWpAyr0bUE/AekhO6I1o1nbiwaqpxEwvEMd2u+7 o7uQtJwWAKNXzGfhPZTkchfkmoSdU73G7yHso9a318ygwKktmRURewHCvoJDDAKzj6j7 O+kIZw4UoRfUEYMyvrraY7xe1h7FfwPg9FtlnrEf4gX5GqsSV16vCcd2LYh5A2dniZ3d tThzIez18WeGyEe9LYg7a1Wv/udyxAuMqWg1H4+HV0y2pnbyLUb0Vdw/MXREbA9wTz+Z JfmRTvmLsuATviBBJmZ7LHqBY5F6XWTUPYNEiT52GMFXZSVP2NPaOQzO2UtK6cptz8TP OqqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a170906794900b00730a530954dsi621934ejo.901.2022.08.02.04.54.34; Tue, 02 Aug 2022 04:54:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236710AbiHBLCz (ORCPT + 99 others); Tue, 2 Aug 2022 07:02:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236689AbiHBLCv (ORCPT ); Tue, 2 Aug 2022 07:02:51 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 900AE33E09 for ; Tue, 2 Aug 2022 04:02:50 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4LxsXT0B3Tz4x1L; Tue, 2 Aug 2022 21:02:49 +1000 (AEST) From: Michael Ellerman To: linuxppc-dev@lists.ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org, Arnd Bergmann , Benjamin Herrenschmidt , Michael Ellerman , Miaoqian Lin In-Reply-To: <20220605065129.63906-1-linmq006@gmail.com> References: <20220605065129.63906-1-linmq006@gmail.com> Subject: Re: [PATCH] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address Message-Id: <165943814479.1061647.2007889797474531468.b4-ty@ellerman.id.au> Date: Tue, 02 Aug 2022 21:02:24 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 5 Jun 2022 10:51:29 +0400, Miaoqian Lin wrote: > of_get_next_parent() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > Add missing of_node_put() in the error path to avoid refcount leak. > > Applied to powerpc/next. [1/1] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address https://git.kernel.org/powerpc/c/df5d4b616ee76abc97e5bd348e22659c2b095b1c cheers