Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 09:21:08 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alistair Popple <apopple@nvidia.com>
Cc:     akpm@linux-foundation.org, minchan@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, jhubbard@nvidia.com,
        pasha.tatashin@soleen.com
Subject: Re: [PATCH] mm/gup.c: Simplify and fix
 check_and_migrate_movable_pages() return codes
Message-ID: <YukWtNwRvOPh6jmM@nvidia.com>
References: <20220729024645.764366-1-apopple@nvidia.com>
 <YuQ4mJqjIUncf7iF@nvidia.com>
 <87wnbsd6yp.fsf@nvdebian.thelocal>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wnbsd6yp.fsf@nvdebian.thelocal>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aGJ8REsERv0+AmTduBPjswp50Z+UszLQBv0AyntSSGIhtpLaMZ7e8BMXRSyp?=
 =?us-ascii?Q?4P2gbdUmul2eV4F0QOXpuESxssworio31ycBWITaB8seIno0m7kiVT9Sil1t?=
 =?us-ascii?Q?ONvxoDbdwydxlSDKS6Mwgzwt7iyou3vgyQ19Oq+57lEmyhpDY6o9jc3nHvxf?=
 =?us-ascii?Q?hXXHIzLtZintU7tGe4nTkN4g4Gax/qRRmaLnfTQE+B5SI9p/aQldOWXb1COq?=
 =?us-ascii?Q?PfVAhGxzA5/TGD8j0df7mh0TmnLqetO11qTzr/eGXCNzxNaDmPbzrtwcI9x8?=
 =?us-ascii?Q?V9btUD/Hd4WE6NM1pH1YUpc6oxo/c0rEokMWrerT2GlWCDQkYQABObwJo/K1?=
 =?us-ascii?Q?gLSsDy4qo/UGBYWIhAQC6JhdvxeJ/0bBBrdcd3OgHXNHKhRcqkKxJuR9RVcN?=
 =?us-ascii?Q?D9+ALJBCYMKaAfP1EZEuef5nVKQSJ2MqmKoQl8KxH7vu5SD4n6j0MtuZ4Vi/?=
 =?us-ascii?Q?Ool7fbbDvJYCDKjNzfgyUSKC3IyR3hvrJGz3ZhOWUy6A6vzUT99Zpn3rek5g?=
 =?us-ascii?Q?PEgHPH/a5dNpeJsoFE9mSqu/hZglFQNOaMFNUC0R7mkLzQgCyQng/onV77zM?=
 =?us-ascii?Q?dEStmVta+5cLgy7HfMjTKZ4f7iHcIYTq/Jg834VhvyoUbY6pR2G53FTYhEBx?=
 =?us-ascii?Q?FRoDroN0DOrTr3DLMnoWN7cG3P2AG/s3BoAjfialQBK4fhdZKW9Rte0LjFY2?=
 =?us-ascii?Q?tjBB0IbOf+hYL5wveu3Ec0zZlWDKMgAMClIDZG7NYiYq1sQxnmpE9rGMIuvv?=
 =?us-ascii?Q?4POXosTHBGKs/lkUAgs8TYk6uS7tyyn+88wXH+Xg6Ixe7lJtjEb6bAz1Vh25?=
 =?us-ascii?Q?cevsD+97efPnCr+qYFf9es1+tecGdsGWs/xiEpBA2xFPfARpxMSov2AIlQ2A?=
 =?us-ascii?Q?3AKDWci12/hbHdH7Zsqaiq01/GKNksR4ZHti5xwG0Pvsq4SqNRR50HGqnHgT?=
 =?us-ascii?Q?3wFkgbGGg0muCLm6vxnoTjNyqm/WDgoNI7H0IrZurZANIrPuSzD9YTuJJN5l?=
 =?us-ascii?Q?wf9s9twlgxtUcjN4zXpeDRWjjRWLAnv7plg51z3CPA4vz/4PZiuSQlxyZKnZ?=
 =?us-ascii?Q?rnHmHLDVw3mABKIp3q83+dsv2JAZcthm5Ru1x2qtvH+i2m4XTlS+yI3jW1Ha?=
 =?us-ascii?Q?cG8A5vtesHj6TYg7K94nBXCsbOtE5gDOQA/cu79D41QuFWYR35rGg9idGibE?=
 =?us-ascii?Q?BNdiBWPtimJuj/If+D9M1bqU3wU1G5vaAfFnCauOEnC0oxTamlqMVdnchqw4?=
 =?us-ascii?Q?rmYHTuJtYaehZPYRqXeYnn1tqKoTe31yrZBr1cI5fstJTP4L7qp9F3y7oA1v?=
 =?us-ascii?Q?X7EJmqDWSy02BO4dyNBdtcoWa4ahY2j+nxWvrZekZE6XZCAupq1DR4sIwvxF?=
 =?us-ascii?Q?vbfEIIbUXxRDoUn/yBS3FlPxkNek/s9o1LETlJAysjHzC6ijm+oDzCuYnKFB?=
 =?us-ascii?Q?fuuLVHvbaTIYfi6YWFosQ4sfZBjVwODsPOx/uZlzW+5QzQPJaCchZemGx+TW?=
 =?us-ascii?Q?ArFb5tBp20TrgSwLjS5VT34CY2ixh35DymDO7oavX0YZqqBm0wD68Lz4UtZr?=
 =?us-ascii?Q?em/ThSlhI0gQFgMgy8Eb2wP+y8eZJOdHSw8aI2Bx?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc983db9-e1a5-4759-d451-08da74817adf
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 12:21:08.8844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OWLZCn4Vu6LOiU8PkyNNyqXvoP9l673hknon/H3hAPW3aGvBN47TSwOsC/pJg7jR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2885
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2022 at 12:18:53PM +1000, Alistair Popple wrote:

> > AFAICT there is no reason to 'continue' in most of these paths since
> > we intend to return to userspace with an error anyhow? Why try to
> > isolate more pages?
> 
> The main reason would be if callers want to retry the operation. AFAIK
> isolate_folio_lru() can have transient failures, so if callers want to
> retry it makes sense to isolate and migrate as many pages as possible
> rather than one page at a time as subsequent retries may find different
> pages that can't be isolated.

Except we don't try to do the migrate, we just isolate and then
unisolate and return failure.

> Actually I should have called this out more clearly - the previous
> behaviour on isolation failure was to retry indefinitely which is what
> lead to looping in the kernel. This patch turns isolation failure into
> an error and doesn't retry. I wonder though if we need to maintain a
> retry count similar to what migrate_pages() does if there are unexpected
> page refs?

This makes more sense, exporting this mess to the caller and hoping
they retry (they won't) doesn't make sense..

Jason