Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 12:22:20 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new
 MCA_SYND{1,2} registers
Message-ID: <YukW/IltcCRwvSM4@yaz-fattaah>
References: <20220418174440.334336-1-yazen.ghannam@amd.com>
 <20220418174440.334336-2-yazen.ghannam@amd.com>
 <Yr2CpuL+JHWblJMD@zn.tnic>
 <YsxefXQDCiJ1zxLG@yaz-fattaah>
 <YtUgb2Y/H/Wq9yIn@zn.tnic>
 <YtVlNrW58cFmksln@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtVlNrW58cFmksln@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZvbIoDjO6XSM3665qP20b5hdykQw2ko1/jDrPqGPH4SGyI6GsR3YgtoF+Obe?=
 =?us-ascii?Q?X2uMhtjFz2yZu/bUjvlYbvea+EtLzmFeJ7WycZK87mevrYbdvNpVPaMm0THK?=
 =?us-ascii?Q?J2rC1m55Et909mH06FYpzAJdha1NMRUMZliBqEaKkiT9eN55EYLWGMu6lfQZ?=
 =?us-ascii?Q?azfyVUOVwZ+R8K0f5lOsMQQuql18Q7eXeIyrGoXo5U71Pu39W4XEkfzjWGtc?=
 =?us-ascii?Q?vEY6IYGtaEP67CRQ6zh+phgZf737o5khu/nu39EgxYEDKE0B6daimArQ72ue?=
 =?us-ascii?Q?9VNbtSfQyg4qMn8hcmvZLhDt5qRIeLjbVSQ00/VJ6BEGftXxrqU3hY/blMQP?=
 =?us-ascii?Q?WAjt886FctI+JGVtkvxuUMwLphZGJ2VO4mLjAGC2dOGAPaun0Tyrek2g1Rhw?=
 =?us-ascii?Q?RxJwvSH9No7HW8UbvcDmTQDNUyLQquJ43Iy2v4TBBC0xLj7WyjaZcpXGU7us?=
 =?us-ascii?Q?aBWiNQQNuXAzm2egS1BJtqCTe4QD4yTrHjCfpLfAgURhQ6X1m4FOK1OOToKb?=
 =?us-ascii?Q?d5qJMDgJygK5w4jRF5fTOo3qoWkzwU0NRom2oiZPQcOqdH50PZ4Cp1LNwKur?=
 =?us-ascii?Q?kyfVppF/GD2GpPfCMHrbIJ41l9LbHZbaWTuhr+G4xh/KX56ztvMh9TIQUCAg?=
 =?us-ascii?Q?lhF7nfCQUpnxSG1ryftCLkG2PI+lkpPcysavXKMjpsppbk+XMuUlJ6kCR434?=
 =?us-ascii?Q?tQbZ/feFOz6KVura+byAbTeY4aipZk6z2OGuPmbMiBfhxGTeZg+/HogSaXg1?=
 =?us-ascii?Q?Gq66TYSsqsZHRUVbvkVqn7cqvzrVO015+ZEYSx9WMODivcYEqKY1dQKVAkE7?=
 =?us-ascii?Q?R5ccgu97gPJZMipcm60kx4bCiBing85AURbm9GiC/0KAriq0iN5Qbih/SCPT?=
 =?us-ascii?Q?I/Q1i47KoIZtK222w5dDfXQgvjITOVCbNfUw5e3AC9dJblmmL9jUPxdvHDwg?=
 =?us-ascii?Q?3oJgVq6t8a4X6XFGxd+xGndbVhF6FqN+MOw3n/WNiPKxZNuWX9UvFJ98zZw2?=
 =?us-ascii?Q?A7M/KebM4H+RkIRlx/5vDOmmtX9ohnRkjCtUq6J7UwxpDyxHXghPHMEi+LSe?=
 =?us-ascii?Q?QvYkomHbNvFgBMAnqG9NRdfoVO5WPpcpw+G/32z6QakbvqfpIc7RS1wRGNqu?=
 =?us-ascii?Q?YM9NcZ6GQ10m70uWmwO5J4k1ALehsWPzrdczrifuJ77rN3wG5HlNpDIqRO2e?=
 =?us-ascii?Q?o1VO2oEXfiBTIhw2IpvESprzkCeZlTIShwmFgT3Z/UrxOLSXptM4m9qrSh+J?=
 =?us-ascii?Q?M/FTkOLBCuLQzB9/R8nf207lON/AKkzHVneYUQxJyye11AUnW61JVxX7zzIa?=
 =?us-ascii?Q?MwMZ1CHRn+AZDInLOtMht0FL1u44KeS6oJpebegMttc6Js7Zdovm0UwXqvFA?=
 =?us-ascii?Q?GyRPUZUCbMg/+Rna5pN9/71Fc5A/GZzOAuYyPuZzCZzUSfJ1J3rLe7IGAzM0?=
 =?us-ascii?Q?B5Ltt6CQRHBwdQnI+OzwjlbTV6GSmS90eRNlqbPGE+MhXbZ+fjpiQhlIbb/4?=
 =?us-ascii?Q?ElTg0utgo0v/NwnEuInQelNNrDshxSAGyOAja6mcShoc+IHH9ntVOLu20HL2?=
 =?us-ascii?Q?6jLhxYyRFB3CkDd7yhFirpXnZFUNvuiRH9lOabqX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f861b7c4-cad9-442d-cdf2-08da7481ab82
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 12:22:30.5144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gWr6vmejPXyfOCpyuzUPLhvny//G5b5Wdl0w5MpzulJl5evDPG6EZcQZbwrvfqU8z8S5y9SniEgh0ueP/qaY1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3832
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2022 at 03:50:46PM +0200, Borislav Petkov wrote:
> On Mon, Jul 18, 2022 at 10:57:19AM +0200, Borislav Petkov wrote:
> > Lemme talk to rostedt.
> 
> Right, he says __dynamic_array(). Grep the tree for examples.
> 
> I'm thinking we can add a field called vendor_info or so, at the end of
> the TP and then dump whatever fields we want there.
> 
> We can even slap a flag in front of the whole thing saying what the
> vendor info type is. But we don't have to get ahead of ourselves and
> keep it simple first.
> 
> How does that sound?
>

Sounds okay to me. But how should this look in the internal kernel data
structures?

struct mce {
    ...
    void *vendor_info; /* Points to a vendor-defined struct. */
};

..or..

struct mce_ext {
    struct mce *m;
    void *vendor_info;
};

I ask because struct mce is UAPI. But I think this is just for /dev/mcelog,
and this has been deprecated for a while. So on a related note, should
/dev/mcelog be removed and struct mce moved out of UAPI? Then changes to
struct mce won't affect user space, and we can just consider the mce trace
event when reporting to user space.

Thanks,
Yazen