Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a79c4c60-6179-1cdf-77ff-6c45d6b7cd87@amd.com>
Date:   Tue, 2 Aug 2022 09:05:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amd/display: remove DML Makefile duplicate lines
Content-Language: en-US
To:     Magali Lemes <magalilemes00@gmail.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     mwen@igalia.com, mairacanal@riseup.net, isabbasso@riseup.net,
        siqueirajordao@riseup.net, andrealmeid@riseup.net,
        tales.aparecida@gmail.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220802120406.88845-1-magalilemes00@gmail.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220802120406.88845-1-magalilemes00@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkhxQzZwdG1WazBybVBhbzV0OHZ0dHEzdm8vLy9LRHZRUmllR0NqeFhjNS8r?=
 =?utf-8?B?c1pBa2xuRWNTd3BWNUJMc3dLRnRCMXg4ZEpISmpZUXkzNTdoRS9XTlNKbmVV?=
 =?utf-8?B?S0NpK1FvOE5CRnp5ckdORWt1WFdFVVdBNUFjQmlmWHFyNlVIdm5JRDZ6ekkw?=
 =?utf-8?B?NUM0SW83Q1ZNOUVjVDUxa2lwME0zelkvSmVudUJuTW8rSVBtS3dNVlVvT1No?=
 =?utf-8?B?a0UybmlMZldNSGh6R2F1a2wyRzBnYUEySVRXdStYM09WVml5b3FwblowYlBT?=
 =?utf-8?B?NzduNUF1RnpOMEhwSkFqOFQwRUt3dE9MdW9yamthMHdaVzBMUk54bEptSzJq?=
 =?utf-8?B?dHhsM0M4cVkwcUdGQ2hOU2xMYWxGR1U1R3k1YU8xejZuYitNT2pTM0FUZGNS?=
 =?utf-8?B?VDNSSDVpb1JUNWpndW9WTXlUM1dscTVmbWIwM2d1ZnRMNEo5NHByNlp2NEZP?=
 =?utf-8?B?Qi9FcXZXakJ4MkdFbFlWYmZBT0NCNjlSSUx2aDlEMzlDQUxqM3BvVkFIRGl4?=
 =?utf-8?B?MUJXVEJ5cmFjS0J4VklNNDVnSlI2WHJSNDcvS2xtRGdFbUpscENtd3lzN0l1?=
 =?utf-8?B?MStaMGl2QjloVmF4WEptUnJYazNEQTlacTQ0ak93dFg0NWFUeW91KzVmWnVr?=
 =?utf-8?B?UlI0Qm1EZ3lZT1ZNTlBNak5HaStLajl1eEFHend5Yi9GbnRnbnVNNWVvRU5S?=
 =?utf-8?B?UGpCQkZKc05wQkJsVzRnUHJ4aGdLUFpQNStoYVFmUTJwb3B6RU40TElpMnNj?=
 =?utf-8?B?STZPODN3anphOHFveUtId2lsdUFZamhkdXBnSUVtUEhyU3paR2s2MmRKVkhx?=
 =?utf-8?B?NlZueXNxVks4MW9GcjV4eEFuM1ZaN0tDemdaejhKa3pRTDJBQk9LQVlWdU5E?=
 =?utf-8?B?Q0lwcHQydzJmNStpUEEzQ3JIR2wvem0zRUJxT2ZXQTBacFJLVVVmbXN1NHBW?=
 =?utf-8?B?SUFLUTZMVllNVlM2bE9RbG5ub3d0WDl4L0ExcldxaERiZDFhQXBVbm9qNVZk?=
 =?utf-8?B?d0tsU0VoOUJ0a3NVTUZWRnlSNFVBQTlacSt4SExHY1k2d1VFbUFKcWZEUVdr?=
 =?utf-8?B?U3Q3M2Q1Rko2MWpFSXdlbXovNXFScEFDcjBVMzJ3RTEzdlZZZERySDVBeFhU?=
 =?utf-8?B?QWxGSXNZcjJsTEpINmhsaU9HUm80WkVCZGtrV0ZnSTBaM0sxNFpDYjhQOWNi?=
 =?utf-8?B?WGdMQmVsWDhLaVVya1NJbGFJN3hOVW92Ulk4QkJLNVhCNXo4R2MvVW93K3BG?=
 =?utf-8?B?R3NiNXVDUVM3UGR3WnB1WXd0TDNud3I5dVZJK0hiVHFXeUM1aGNBN29iYTZT?=
 =?utf-8?B?bjBHbkpNdGRDMWl6cDAyNEl0VDdqRVZwUXBuNEtHUnJiUlFGVVppcTVDVGg3?=
 =?utf-8?B?RXlza0lwZzJYWDBrSkQzOENMbUpINXFTYzFGNG9ja2YyeGtHNDlpbGhKbzcx?=
 =?utf-8?B?TlR1Nlo0TzhGZHYyS25GKzhhOWxqODVsYWVZOTJkRzgyRGZ1aHVqbXJWMGlB?=
 =?utf-8?B?KzlieXh1YWs5U2JFN2ViMm1ZdVdqd0NVYkFoL1dEVUpIWDZOMEdNVWxRV0hK?=
 =?utf-8?B?WnVCRFlpYzM0Ulh2MThWcGxHRy9MaFhlY05pYWVsVVZUUUtKd3hZamM4RlJz?=
 =?utf-8?B?U0NjWUpuWXRhNERTaXNrMTFWUmxuUVdXME1QNFA4bGhtSVMyVXh4ejVCeGtp?=
 =?utf-8?B?VHBXSjVVdFpRdkFOUWVqVG42c3RONkVEQi8vWGFydmtWT2RhaVk1cmpQWXdq?=
 =?utf-8?B?VlR1OGZiRUxyUjFJWjh1b2t3YWhrUnhCSVhLZXd5YWFXT1IwbEZwdUU0NzA4?=
 =?utf-8?B?SE1pRVRKRGEySVc5SVlrcXBscCtmTHpvVXg2SzBVTG4zSHBLWlFtNklONWh1?=
 =?utf-8?B?WENsTFB5Q0FuNjJWQkZ6WHdZS0lhTDRjc2x6SXpGbDkweGhQelZrYXZDNnZE?=
 =?utf-8?B?KzRKYm5hbjNiSUNaOXJlS25LZDhlVmZIQXhtTUlhMWFkRVN5dHpReitHVU5M?=
 =?utf-8?B?eWZkMEZlZllVK2dqUUxXeGhPY3dDL2xCdmJ6aUplRmYyK2VIODRZSTdoSHVM?=
 =?utf-8?B?L3Rub2RRTEp3bE1TWCtSdEN5UVpQVExrcFVsczJaWG53Z0ZhMU8yUk1wU09G?=
 =?utf-8?Q?nz2sShW8zcogv8G2Qrc7ApAl2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 143dc0a2-7645-45cf-2749-08da7487ab8c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 13:05:27.5092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C6aXzy3hFNTuLFRSIPAEKUNKpkAZOnMApHCgFes6Yd3rTCHx85/3Osbz+klEZPyrEjLpqxaHrXhy1sh2nh8usg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5885
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-08-02 08:04, Magali Lemes wrote:
> There are two identical CFLAGS entries for "display_mode_vba_20.o", so
> remove one of them. Also, as there's already an entry for
> "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being
> defined or not, remove the one entry between CONFIG_DRM_AMD_DC_DCN ifdef
> guards.
> 
> Signed-off-by: Magali Lemes <magalilemes00@gmail.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> index 359f6e9a1da0..41bb6c3cc2d8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> @@ -61,7 +61,6 @@ CFLAGS_$(AMDDALPATH)/dc/dml/display_mode_vba.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn10/dcn10_fpu.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/dcn20_fpu.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20.o := $(dml_ccflags)
> -CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_rq_dlg_calc_20.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20v2.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_rq_dlg_calc_20v2.o := $(dml_ccflags)
> @@ -82,7 +81,6 @@ CFLAGS_$(AMDDALPATH)/dc/dml/dcn301/dcn301_fpu.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn302/dcn302_fpu.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dcn303/dcn303_fpu.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/dsc/rc_calc_fpu.o := $(dml_ccflags)
> -CFLAGS_$(AMDDALPATH)/dc/dml/display_mode_lib.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calcs.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calc_auto.o := $(dml_ccflags)
>  CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calc_math.o := $(dml_ccflags) -Wno-tautological-compare