Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        NXP Linux Team <linux-imx@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Nicolas Diaz <nicolas.diaz@nxp.com>
Subject: [PATCH 1/1] serial: fsl_lpuart: RS485 RTS polariy is inverse
Date:   Tue,  2 Aug 2022 11:38:54 -0500
Message-Id: <20220802163854.1055323-1-shenwei.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lf6YMq4QUv8GFlLTQYntSzwnOlzmMmIehUt3U4qyT0ungCWqQJhH6TQvt8Oy?=
 =?us-ascii?Q?4iJz6mOzUVILU0gX0L+BCFmPz56meUZ9cCC3aMfUZzR/hQXUFJeUBOMIEX9N?=
 =?us-ascii?Q?a5adxDHN5M2xvSmYKkIPI4LTMHrxnMMeIsvr9x6qRBHCOvafxPTmPAExXpwI?=
 =?us-ascii?Q?Iu3dLkAuDZIlx07CIedxZSP5hDbIfDB6DVIhHkzbI/XyT/BrJYsi0Nz6jl5n?=
 =?us-ascii?Q?21J8SdDpXHElCv0ARqGEjve/NuluKNcMxz2FhrcuNM0Wl+tyyH/iV6t34FiH?=
 =?us-ascii?Q?nsAN9WljMb5L00rRiiTn4itJY7SlpxeMVDzVmy0NEvBJPqq/zrsAzRtt6Pnq?=
 =?us-ascii?Q?yqsNcypq3/AzmQvf9CR0RTPonoleyWJZ9ATmGkYiz2rRabTWXoKnH75qmgo2?=
 =?us-ascii?Q?LFBiT7S03JEO6EectR7YOHj9mSqzPGh9kyuQ4Etms3C011gRYYtrSi5rBLhA?=
 =?us-ascii?Q?ArxvB4ee4kw1TZ1kxyCen46hXqiu7QNWTHObDQ9JxkmijoL3bwVphXoVDZvM?=
 =?us-ascii?Q?oQzd09zHyooXZGXDIjH8HQ/pzWpBLDLd0l8+9HWWaOAXoMVDG5ZahvsZUMjE?=
 =?us-ascii?Q?YPFtdEb8dflQR5dzoIwbIvmd4lZQtfsxyjU87lhlAj9riC6h1pnNSgLCUJQ7?=
 =?us-ascii?Q?BFPLLe4H81h5SvFgO68UlVGcGwOuFA6dUNYdEm72XX10NzB88XTIh/xgu4Rj?=
 =?us-ascii?Q?pqI71tmC6XdAbo6qGkINt+2Hi/UlONME72MNL2S+LTMVWPWIlG4hH1oE0A+Q?=
 =?us-ascii?Q?+ld4Yje3cChfGMN2LWWbs7HFMJrweEMRXg+hCi0u3YVBf/7pRrIoznMaeAoP?=
 =?us-ascii?Q?zNoSnPqIv2Qm3ePxFxNAghlIa8pNE4KxHwVewUVxpeKtonTVeXRpOC6AzExX?=
 =?us-ascii?Q?1rkPkze2LjrgG7Vw5KQPeIhJVKxnushBOFK9BqISi3q4e3gn3saAVnz4SXZS?=
 =?us-ascii?Q?NwYwo6f/XDxHjAr/6HyP8SYiOAT9ZiW4Smvb2DPLJBptsv/+VE+8qqlNOnqB?=
 =?us-ascii?Q?77S6P7DcGmokiwgH2D9MuCQAek+lWdmuuX56O8lU2nRDooW4kZAHXMbI3In/?=
 =?us-ascii?Q?+s69O46QQaKsyDPbLdeQzkPf9Um4pqXeaOk2wTvSmVlNsl9W5Pn3XHXb5tDb?=
 =?us-ascii?Q?HpRaG3F/sP2ksVplphk4gkBIe9xaFC2jdVKtZkdfpfwJFkkIfFOGFK680GtV?=
 =?us-ascii?Q?Eklf67grJ5LQ3ZCPXZgFqp5uDHnyqDw7PW4chPnmzQ73YuwXexCUKIqBZ3ho?=
 =?us-ascii?Q?0rbt5S4pVsdVLa9pd3WLboYtiU+4S9derdu4HSPJzQRSKC1y7w1hEOol6Wyf?=
 =?us-ascii?Q?R1zJ9s8BJby8ws236QFUTxEu3nanFrpbD57K+sdgtXjf0J3MbFMCc5nYKIhw?=
 =?us-ascii?Q?S+w3wCbWO89xIN+cepCHHvLsmTWGgz+hbaJeEFzeY4H9W5KvUAgoURjH+vkt?=
 =?us-ascii?Q?5POoKpAlWVoxONQ9SVjtHig9pdMmO5Fa7x/sXLGyCjplwaXaUeHdazH8cHUw?=
 =?us-ascii?Q?U2k+HTXYYz4DZejkdgrWO2mI6SGveW3MpLWM7eRacZ26YBA9DWNfbM1H/uIh?=
 =?us-ascii?Q?lG4oIOvfdaWkwd8REDoJuHVvJk9/GGQMIs/KyEt+mPTBFYGgO4U/IQZ9bnwV?=
 =?us-ascii?Q?UQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8ee8897-28e3-4003-7398-08da74a58b75
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8274.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 16:39:18.5440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 00VUTnEaOTi5TKFyWnyh9XFJSmhGq2iChRBD/9mFlTzfHLcBolCCiJ+ScsjkMr8NbLyz7C3pTAt5I30XfvSpXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3555
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The setting of RS485 RTS polarity is inverse in the current driver.

When the property of 'rs485-rts-active-low' is enabled in the dts node,
the RTS signal should be LOW during sending. Otherwise, if there is no
such a property, the RTS should be HIGH during sending.

Signed-off-by: Nicolas Diaz <nicolas.diaz@nxp.com>
Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index afa0f941c862f..abc3a3674bc39 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1394,9 +1394,9 @@ static int lpuart_config_rs485(struct uart_port *port, struct ktermios *termios,
 		 * Note: UART is assumed to be active high.
 		 */
 		if (rs485->flags & SER_RS485_RTS_ON_SEND)
-			modem &= ~UARTMODEM_TXRTSPOL;
-		else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
 			modem |= UARTMODEM_TXRTSPOL;
+		else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
+			modem &= ~UARTMODEM_TXRTSPOL;
 	}
 
 	writeb(modem, sport->port.membase + UARTMODEM);
-- 
2.25.1