Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <25f53aa0-a84d-9d81-48b8-9bc9e3de707e@amd.com>
Date:   Tue, 2 Aug 2022 12:26:11 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] drm/amd/display: remove DML Makefile duplicate lines
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        Magali Lemes <magalilemes00@gmail.com>, sunpeng.li@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc:     mwen@igalia.com, mairacanal@riseup.net, isabbasso@riseup.net,
        siqueirajordao@riseup.net, andrealmeid@riseup.net,
        tales.aparecida@gmail.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220802120406.88845-1-magalilemes00@gmail.com>
 <a79c4c60-6179-1cdf-77ff-6c45d6b7cd87@amd.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <a79c4c60-6179-1cdf-77ff-6c45d6b7cd87@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzRPSlVwZFdWdWtYNWJDVXI4THFWYzVyNUZZZnViYU9kdG5XM0g0eStPR2oz?=
 =?utf-8?B?RXRidXlwcFprallKQXZWbXZBT1llQ3pQcElVbzNDZ1p6RnY5UktpdVRwRTg2?=
 =?utf-8?B?dyszQ3ZkQjVXTUlrcXJyRFRoSE5pZjlYSEo4cEpmajVsNWFGYWJRaVJDbmZa?=
 =?utf-8?B?cVAwY1pQYmY0RmdHT0RnajdnNVVNSzFRcnpFdDJjaXg5eGN0YlIveENLK3Vj?=
 =?utf-8?B?c0puY0VPcUpHd2tOUmJRa3VUemZhMXBaTzdFWGgrb0h3MnEwRnF3MEU5U0VX?=
 =?utf-8?B?WUJvK2tPVDhab09RcHVqWHQyT05YaS9rQm0yRFN6MDg4MTlyeExXdzlsL2pH?=
 =?utf-8?B?M1FHWTZwb1N1NWhqYitsNCtoWjc1OVQ3bDdTZVV6SXdBbks5YUdudG0zYTRa?=
 =?utf-8?B?cFZKeHNEWWw0M09zU3pqMFVwOVdmL05XYUxWU2ppYVU5enhPVE02ZjFOaklm?=
 =?utf-8?B?amh0RUtTTm50SnVXMU9QU2J3cWp5YVk4R3QxMmZqTHY5OG1vcGxyb0FRQnNF?=
 =?utf-8?B?YU1Rb1VXemtGQTZIaW5Oald1TGx1OFFtdS9xaWJiaHpWRWRmaUxzM0JVcGM4?=
 =?utf-8?B?c29QQXRhMVZKWmdYek9ybG1iKzJvVDEweWdua3BpcXlHVU9uSXVUd1Z1SXpK?=
 =?utf-8?B?RVRMNXFVV0dhMHhHTHlIMEs1WUhJNWpoNmUvZmljcVZzcnNWQitCL0RnWWhD?=
 =?utf-8?B?bGx5QSs3ME5JNDFpU1hMenZtaHdCUGI3em8zR2orZmljNml5ZVdUekZJakg5?=
 =?utf-8?B?Zy95dUI3YzlaZ0JGTHNDOWVHaUlFbXpSRkJwTVlsL1BwUUJ0VWp0ZHdzSEVk?=
 =?utf-8?B?RmF0VGt2bm9qbU1IVFN5QnpwaVI1bi9HNnd5c21CbjR6OXFKNFhXNms1bUg1?=
 =?utf-8?B?UDFLU052b0N1VXcxblpGV0RYeXNnb3NMK2FXSEYzb3ZuMkZHUmxUSUtMeTlL?=
 =?utf-8?B?eldVRUZwdnJJRXRtdENMSTBxUXlqWGMyYko1MDdTdjBsSG9Qb0tsMzZpVTNK?=
 =?utf-8?B?aUNWcFc1TCtxYjM1U2N5Z0RJdWNXTEpjUmg0NGNnNGxSUWt3Z1FmU3RQKzI2?=
 =?utf-8?B?YlVaR3laYkJ3NHA3NjR1YjhCM3RMd1N3a3pzTXBLTWZNdWQ4MXAxenpVcFdU?=
 =?utf-8?B?UG5BenRYVkxtTUFJdzVmQ1VpbHZOUEdvajJ4dVZ3elZ6RzN3QmlUM1NUZHFQ?=
 =?utf-8?B?UktXMDdyaXdIeWxEOFhIcXl1Sk45T3FObkRJQ2M3NTM2Tk9lak92VlBDYUdJ?=
 =?utf-8?B?QkplVU5JMmxDWmpEYVhmREpacDRVTGFXLzZ4R2FwWXIxLzNYMzVGb21wSVNY?=
 =?utf-8?B?VCtuYVhTWXgvMXkzVjhrWFVjKy9VN0h2b0FJRjhSSEZsTXBURHhKNHpnZThu?=
 =?utf-8?B?RTN3RlVmK0EzQTFyRE9vWVExcFN2eEpEVXN6ak5Jb21LdkN6U2lDRU5DOUM0?=
 =?utf-8?B?TnhWZ0llS2lNS1J1bldXY0V2NDhDR3EvbncyVlFHQzM3YzREdWVNZHZmK1J1?=
 =?utf-8?B?SjdkUEdEa2F2YUNkLzQyR3k4emRKL1QxNndhUWdmT0FzbWgybXJDWmdUMFpL?=
 =?utf-8?B?SHBXQ3B1cDdIdG1WMCs4dzJ6V1VaY1RHMFc0TzUxVjRtcnFDMS92RTE4WVo5?=
 =?utf-8?B?TVU5dThzaUpVQlBkT3BpODBWWWxJbG53emQ0cGI0NUoyOEIwSy92cVY1MXNn?=
 =?utf-8?B?T2g5MUNRaDJYOTA2MmtHejcyOHU2VVhudGpHeUFkZjNwSFRLcGdrOGhPM0s5?=
 =?utf-8?B?U1NWVGY2VUtkMDJvWUFtRFJzNHljNXRTUVVOUXUrN0FnOTBkS0Ewa3FjMU9w?=
 =?utf-8?B?T0dyWTZoQ0ZQQVVnczhibUdBSkErTFE0aE9tWXVzQlQ1MkxhVzg2SmFOMU9X?=
 =?utf-8?B?LzlDYkRob2s0Z3B3ZTUrbGNCZU4xamUyR052UU1ldXh2N2tNa3ExVGh1c2Zz?=
 =?utf-8?B?OHRVU0JITzhSbnpSaXc5a1Fha0g2MGJqVExIdEQ5akFnNzV0WkVLMUtqYXg5?=
 =?utf-8?B?RGtVVkd2WjBLWFp3L3FSVVpZa1lIaE5nbm1PVnEwOStHOUpLNE50VzRBWktM?=
 =?utf-8?B?SnBRZzBTSis4NmxKTGs2UXBaY0QwNEVrb20zZkQzdmNkeGlNRjcrU2J0NWpm?=
 =?utf-8?Q?9UzEiui0UHHGk0EiTsJp4M5vA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc49b5e2-62b2-4f33-df0b-08da74a3b711
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 16:26:12.7801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gQcCfKl/AWBhCD1Ip2+1QLRoYAd3FsZ1k2iyQMqfuEdK7gweVUpYxjUzsJNBs3mT9j+iWwl1RkomhRtbaga23g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4532
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-08-02 09:05, Harry Wentland wrote:
> On 2022-08-02 08:04, Magali Lemes wrote:
>> There are two identical CFLAGS entries for "display_mode_vba_20.o", so
>> remove one of them. Also, as there's already an entry for
>> "display_mode_lib.o" CFLAGS, regardless of CONFIG_DRM_AMD_DC_DCN being
>> defined or not, remove the one entry between CONFIG_DRM_AMD_DC_DCN ifdef
>> guards.
>>
>> Signed-off-by: Magali Lemes <magalilemes00@gmail.com>
> 
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> 
> Harry
> 

Applied to amd-staging-drm-next.

Thanks
Siqueira

>> ---
>>   drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> index 359f6e9a1da0..41bb6c3cc2d8 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
>> @@ -61,7 +61,6 @@ CFLAGS_$(AMDDALPATH)/dc/dml/display_mode_vba.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn10/dcn10_fpu.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/dcn20_fpu.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20.o := $(dml_ccflags)
>> -CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_rq_dlg_calc_20.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_mode_vba_20v2.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn20/display_rq_dlg_calc_20v2.o := $(dml_ccflags)
>> @@ -82,7 +81,6 @@ CFLAGS_$(AMDDALPATH)/dc/dml/dcn301/dcn301_fpu.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn302/dcn302_fpu.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dcn303/dcn303_fpu.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/dsc/rc_calc_fpu.o := $(dml_ccflags)
>> -CFLAGS_$(AMDDALPATH)/dc/dml/display_mode_lib.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calcs.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calc_auto.o := $(dml_ccflags)
>>   CFLAGS_$(AMDDALPATH)/dc/dml/calcs/dcn_calc_math.o := $(dml_ccflags) -Wno-tautological-compare
>