Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 13:57:59 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Sebin Sebastian <mailmesebin00@gmail.com>
Cc:     Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] RDMA/mlx5: unchecked return value
Message-ID: <YulXl1qhse/NM589@nvidia.com>
References: <20220730103242.48612-1-mailmesebin00@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220730103242.48612-1-mailmesebin00@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qCxCozn/7pP4mBO/u74Bcbue/4w0fgwrDNBjOjG1/eGWE6zvPI/egwrfSzNQ?=
 =?us-ascii?Q?KtvTa85SDJG65SHVBOihYWcLfkUKhrwUOTCs0hCaoM6ymHri2c5NIdMaWlCa?=
 =?us-ascii?Q?GWInwQTqdW8Ifjh24SATSQ6sshL0nFKdaguYiLXMIMVC9IsDrdaGGS7izAaU?=
 =?us-ascii?Q?TYEwQrTtM9opATiemkwrEhb1AD4ots180CX7kJORadIyddK4s5c1NneCvNiK?=
 =?us-ascii?Q?B8t6QeGOBAFyUIbpQTAVfYf4cenO1En8D6Q0j+QIm0sz2UfCrPTqtlPqeOmd?=
 =?us-ascii?Q?2245LIny0D559i7PjX+0WmKXu0A1LmtJc1wgd/3ROm1+A0Kaovt7ZG5qEIdL?=
 =?us-ascii?Q?4qSGzl4PAOV8iV9/Xs7GKfH2gMlBi9kdGB7Gf5vcLL+XO/2CSkcnNuL3fidE?=
 =?us-ascii?Q?7ZlhqP1WwQWX15yEYYmEkEPrf8rG+Iis2w0jpJpsiWFpj3y8lzTsuEJd31He?=
 =?us-ascii?Q?2pTVsAZf95inV9FJGUQUJp7nczS29rgAjiP7oVbpxjDFV5vwRT3yI/k3UbTD?=
 =?us-ascii?Q?70jgdpfEUYGM72MuFm9cnsP+rBv5AQaIqo4HKNecGd+LXcO3c4PyObZlzWTd?=
 =?us-ascii?Q?0eyRhNqUkd/3eq7+7ssecrYDxEdtUi2EAnO7fwsf4JOOyPEkQObfskE/i7AO?=
 =?us-ascii?Q?aJX0soHFY80utRjjUVDkExi3suDDuxYXGyLwv707QakVuvgCXFoMhE5sIomg?=
 =?us-ascii?Q?4d0GSAeSr4muhw/5nVorPHb0oFCgOkPvHcgB+riVQSteJoiGIhRsacXKSsen?=
 =?us-ascii?Q?26HbEbO8V0vG3jPdfPoRUSkY4FMtgpkZFGmFGfdlxzWGvGXj+T5s3244srtC?=
 =?us-ascii?Q?pGkuvqOg9qve+9XqL75L7PorJ+leF1aOpLybzfK6SV2cCobU/xUmgak5N9ZV?=
 =?us-ascii?Q?tp3e6FrOivFmge8yAk2zMsldsy327uhCJKBR95c7EgxVTz0xDGMxoQpBI+d/?=
 =?us-ascii?Q?exH9WJ+/lo31i+vjlFxad5W3qQ2nV8Wizw5j8iauEfPbNY7Doo/kZFk8E9ai?=
 =?us-ascii?Q?cDOos2kwZfzvHijSpFgHOqijl/SQFpC2hUWNoXxXQZwLnqw8wQmnz7Tl/2Dz?=
 =?us-ascii?Q?nHmuZyL9sR+wHNn46/Drr4yQqCxX+iJ024VONCe6lSRGuXgMEKoNI8hfcgWW?=
 =?us-ascii?Q?0o7AzVxsk8KcqOf9WXPS0vmxMeevZ3upaNs6JO52cWfJG6X+6/v7FoQvp+FN?=
 =?us-ascii?Q?pHp4NTx1bxQ7OJCLzocFwfFHUtDWsUA2HcSvuAbigpzYOh3J7nm+q6HZY9zS?=
 =?us-ascii?Q?ZoJxSPrFTQAwwmJYz3qMTasTbn1UxzBVB4FN7RcDF0tCTfDmkoNJhFZRhLHi?=
 =?us-ascii?Q?70c5v2eEFoMUERg7o/juekfKkum5E/jUP4J5lFr9GT+0ePdNS+5uLXacLDv0?=
 =?us-ascii?Q?ucYy+TMrajcMF0VezokQzG5p1XOXolcC8vytngFOTPh9Ck8HwtlNvx+DxNT6?=
 =?us-ascii?Q?ubwIlc+s7pBUr3rtxs/zM+LC/vIUWGXLaktbtUxQie7jEDxKhqzD9qqEs8Mi?=
 =?us-ascii?Q?X4p+0P0mKHWAeoPL0JdT9UVjLVqWXs9Tv3QEb1hm9CxgtJaFXyk4cjW1xY6Q?=
 =?us-ascii?Q?Far4iM4rfOCehkPulSzICdfOX4Bzm1qMyrclbhGg?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f687f16b-7136-4239-e71e-08da74a8285a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 16:58:00.8282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x/gJ6Nr/agf1zcAJyLchd1BqQL+cGqT+ytb3h5E4CFfoJL4XtTxCozFUts4Od5Re
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4055
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 30, 2022 at 04:02:42PM +0530, Sebin Sebastian wrote:
> Unchecked return value warning as reported by Coverity static analyzer
> tool. check the return value of mlx5_ib_ft_type_to_namespace().
> 
> Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
> ---
>  drivers/infiniband/hw/mlx5/fs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Leon's is cleaner and has a proper fixes line, so I will use his

Thanks,
Jason