Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Tue, 2 Aug 2022 19:28:56 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        bpf <bpf@vger.kernel.org>, Kernel Team <kernel-team@fb.com>,
        linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
        Daniel =?iso-8859-1?Q?M=FCller?= <deso@posteo.net>
Subject: Re: [PATCH] x86/kprobes: Fix to update kcb status flag after
 singlestepping
Message-ID: <Yule2F3i+Qj6Cdxc@gmail.com>
References: <165942025658.342061.12452378391879093249.stgit@devnote2>
 <20220802105230.43bb6079@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220802105230.43bb6079@gandalf.local.home>
Precedence: bulk


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue,  2 Aug 2022 15:04:16 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > 
> > Fix kprobes to update kcb (kprobes control block) status flag to
> > KPROBE_HIT_SSDONE even if the kp->post_handler is not set.
> > This may cause a kernel panic if another int3 user runs right
> > after kprobes because kprobe_int3_handler() misunderstands the
> > int3 is kprobe's single stepping int3.
> > 
> > Fixes: 6256e668b7af ("x86/kprobes: Use int3 instead of debug trap for single-step")
> > Reported-by: Daniel M?ller <deso@posteo.net>
> > Tested-by: Daniel M?ller <deso@posteo.net>
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > Cc: stable@vger.kernel.org
> > Link: https://lore.kernel.org/all/20220727210136.jjgc3lpqeq42yr3m@muellerd-fedora-PC2BDTX9
> > ---
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> I guess this will go through the tip tree?

Yeah, it's already in tip:perf/urgent.

Thanks,

	Ingo