Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 15:11:33 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Bart Van Assche <bvanassche@acm.org>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/ib_srpt: unify checking rdma_cm_id condition in
 srpt_cm_req_recv()
Message-ID: <Yulo1SNrjPYZuIFv@nvidia.com>
References: <1659336226-2-1-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1659336226-2-1-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PdYqzbFkIUYBmS5je89mll9nD9GV75HXH9C92zYhYvdzA30/lgBjVc7Zn7PH?=
 =?us-ascii?Q?v0vzN6rUMrEjbceI8TqxeL/AWN4/2O3MBY8XeiywXr2H2J5Ek0P/ZJZwTZlg?=
 =?us-ascii?Q?wP9b9FfR2QJKqHpgOze/wKHYL2P58h241SdMvFoVquIZoNLq/B3BZPSqcgD3?=
 =?us-ascii?Q?HBiakE92CuD+pSNNd+ZX1xGmOSPDc1uL4Jj2lGjH2Tzg2eZ1ocDYeW+G4/Rn?=
 =?us-ascii?Q?fMeq+d1c02XF4bm3P59MvnQFbR2oMcF5FAVk3e1GjOOkyZ7OCCXQbXP+omxz?=
 =?us-ascii?Q?4BOjqqKs3wardQC4z8QjGKg8fQHTwJiM69xmHgeHkL+pOACFauyQfKm981u2?=
 =?us-ascii?Q?FBeGLw7uh0j3CmVDe6ia5NYnAR8nGz/XZ71pnXbO7Ig2+gVDtoQauIh6nnxG?=
 =?us-ascii?Q?tgSZ+7C4c7Te84HfNHYh8r7+ooYMXIqSkxbpETsidR4prykckac1JMXN/fOy?=
 =?us-ascii?Q?XQq8mqLnrjLT6SAP5mgcoepUlskrrQ2lkfR0u9s34SZdQsJyYlFF9qUEd33y?=
 =?us-ascii?Q?GytASVZmEVeSqSKHbNTqDx7YvDlz0CNQktXAwbZN6V0MBfQleh9ahmtltOSN?=
 =?us-ascii?Q?B0a+9zqc89XJZJz+DAe2hmbyqqLd10dELG7yqo5YJr3ZmfjuNHtXRkk+nUfA?=
 =?us-ascii?Q?p1hU48jefC3z+Wh8AGYBQAGWlLqlIlCF5Y/zVwRks48XvPONIkw+XLKK1mWN?=
 =?us-ascii?Q?VqOxhzPbdaY2rhH+tHfcWF2wz2pLNcRydqAI1DFDhYGwZikH2+B3kapp5RMK?=
 =?us-ascii?Q?n+m3yGCWwR2Sz/a2UySw+67fR0F2fty+2ijnAO4Wmi2a/ApoWBWrdWktzHQb?=
 =?us-ascii?Q?/KyV+mBh3uII7SumUZJlLwUaAyCcnkEa4YiEEn/OIOJzPQ6vQofMvEEZVoAQ?=
 =?us-ascii?Q?VcnnsNiA2psQaiE3g1Ne3+tKb3WKHlw9Zmixmq+2mPfsUI0FaaT739P9dGQN?=
 =?us-ascii?Q?VYZHRrkmNVaC7Uwp8qaPwPy6BjUbeeBt5Q3w/vmXj6/oFCSNeRtBHiZ334/D?=
 =?us-ascii?Q?tywE1pMtAg7TkX8HUck6Gmpfa085X1sKXoLoaKnWJAruvRSvQ45pe/PgX/1t?=
 =?us-ascii?Q?OonQjLBWnUERjY7Cg/RvlX7kS4lYmVwNRRQsNOqZutBQg4mT66AOUL93sM0c?=
 =?us-ascii?Q?UYJOt8ZXbWiAb13PdQaCErOVY9PvJFAfRJ/dKJio4F6v2e7dEoOe64BWkY/7?=
 =?us-ascii?Q?gwNb76GReDJefZD+7Dh35GBPS6OcBU+AhIXHTc9OMshLXL3eu74l+MPptRAb?=
 =?us-ascii?Q?VvU2OrurX7uT2DLI6Gz6kTujoMeXXKfLYkE1nDMSNLj2SvMGKmvoSC7HI/2O?=
 =?us-ascii?Q?XIqTODFPq44A6+UlWE7+pehNxjeplcR10P2Cq+kYOvyydyTR8A2DfvCOHQ8m?=
 =?us-ascii?Q?CzUEVg8VKoFCMmdj9FYbHYdxPcXRpyxTedVpsa4IAtaXGLqtGVfqWdvVrsjH?=
 =?us-ascii?Q?9hIIeTT9UJl2jl2HK73IB28JlxHCkqvzL49T0Q9WYkbNyej1itvwCNQ/3zAV?=
 =?us-ascii?Q?uOyH2OU8NnkgDWO6Gh5l09qa6a7b7THrneowB48W2yIV8u9ugxSyHuwtA4rQ?=
 =?us-ascii?Q?c5hhd3+YUZbNgtvSFZhxJfUN4XYewY+iBt4ij2fG?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71c1669e-ef0d-4c05-0d63-08da74b26f40
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2022 18:11:34.7377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BkDGTjbmSewq74tLyhR8n208WswblkD8Jf1L2QSEBW8WJMRL5S4SMyM8dURKOpa0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6364
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2022 at 06:43:46AM +0000, Li Zhijian wrote:
> Although rdma_cm_id and ib_cm_id passing to srpt_cm_req_recv() are
> exclusive currently, all other checking condition are using rdma_cm_id.
> So unify the 'if' condition to make the code more clear.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to for-next.

Thanks,
Jason