Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp2682098imn; Tue, 2 Aug 2022 11:56:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR6aIsO+4w27dryiLhVy9lBjX94Oufm+j8Sg7Jdag1DOVgZ+wQJr+s9qRGQElYsQ3bU0XHoW X-Received: by 2002:a05:6402:43c5:b0:43d:f9ca:4061 with SMTP id p5-20020a05640243c500b0043df9ca4061mr4111820edc.352.1659466616221; Tue, 02 Aug 2022 11:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659466616; cv=none; d=google.com; s=arc-20160816; b=gEWdqMZHp2FjBp+N9odRjmBAeP7bn8ca3XE+a/DC/0gnpLzD31V/5dGvpowisrPAp7 qAfOaTxczpDHjxselgTOt5BCmzLLHwt8Gmrg9lYLqFa/OljKrYJvzN9aP35q2KP9tHrp 5ZKblWP2i+ZA0pMtjDWbAKVRtbXqrDr1fP0p9MkLzKYgzB91oZthSzM9GtJnP3pghzPA J0oxJnz0WrGeM8+y3TegmMAEomR9qJgyaI7qq+3bm6PQuMHtZOc9TY8q79PGetStW4Xw A991DnaM8TTOASX83tYClw5h2wDCeMsbUUiCJQDx6DgxlWDgIeN/wrEYBxrNSpLMcAi/ 6uZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hRTxdZdFnYU2ReJxhVfPZugKAM0sPBKDqlQGDbAlz6Y=; b=cAR0UCozk8WMMJ5DDtOnC7JZFEl1rWFMtr53Y1HvCaHPqiUp8id39LBM2dZl64U6eX MfKe2OOTXyGXNJJHm8MMLiTOAQhKI7BpkPokzJyfIikg1nV3n0feKtq1NMfGiSDBjjeC axNcElzektsh9JveOOra1kiGQ0O55YO3rItSo+smOJc6NOdq0lZ8IuYwzx+6ivl2y3x1 YXmH9oLkjia1q3yOEwFTD0G6l3+f4tEelLVMH7soFpjZ6aGGjHUHIlsKtwXzO3mX/84a dOQ2MyX179tFUAdqDf3H8H0qBrU31DMkSFADsfS3a14ptLPfSzoPm3IIr6xarCNxoFF+ CYrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XuAr0J0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e11-20020a056402190b00b0043dd133f9afsi3963545edz.274.2022.08.02.11.56.30; Tue, 02 Aug 2022 11:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XuAr0J0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237443AbiHBSJP (ORCPT + 99 others); Tue, 2 Aug 2022 14:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236661AbiHBSJN (ORCPT ); Tue, 2 Aug 2022 14:09:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DCD51260C; Tue, 2 Aug 2022 11:09:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4FCDB81EE8; Tue, 2 Aug 2022 18:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 931E7C433D6; Tue, 2 Aug 2022 18:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659463749; bh=3m8XltI+Jl+jFjBten+Mlx06s0qeecBCmc9bi22rqio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XuAr0J0gEK56Qchy3h2DcX0QGjfWI3dg1sUMOFcAVySs95YRb7e5N+F4lLf0JMDYW uTpRo0JLzZ9lcvMaJZ6FCMxZdMSdNsZVLYHB71VgtRDcHmw+lh9ROq2HVibosRZXTE SGjc+YVTLQqe2DXmqpayhOJmKcEYdnx52Ddl4vCUgxmrycC5y0RxBuuCxmD71CmeIx duO26RTyTbaAhNGDEjDd3gGFzTowItuNY8i1y/jY26YM2Y6FMPmonmFCVVZK+4USQK u8urtU2yho4Xl2RBSjm5onC8SNqJdGqA1VZiEQChABfYvZcMe3puwsn05/sGTmIrIi Ok0iPeMfwvD8g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DE2CF40736; Tue, 2 Aug 2022 15:09:05 -0300 (-03) Date: Tue, 2 Aug 2022 15:09:05 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Stephane Eranian , =?utf-8?B?6LCt5qKT54WK?= , Zixuan Tan , terrelln@fb.com, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] perf build: Suppress openssl v3 deprecation warnings in libcrypto feature test Message-ID: References: <20220625153439.513559-1-tanzixuan.me@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 01, 2022 at 03:24:18PM +0200, Jiri Olsa escreveu: > On Tue, Jun 28, 2022 at 08:16:06AM +0200, Jiri Olsa wrote: > > On Mon, Jun 27, 2022 at 11:08:34AM +0800, 谭梓煊 wrote: > > > On Sun, Jun 26, 2022 at 10:45 PM Jiri Olsa wrote: > > > > > > > > On Sat, Jun 25, 2022 at 11:34:38PM +0800, Zixuan Tan wrote: > > > > > With OpenSSL v3 installed, the libcrypto feature check fails as it use the > > > > > deprecated MD5_* API (and is compiled with -Werror). The error message is > > > > > as follows. > > > > > > > > > > $ make tools/perf > > > > > ``` > > > > > Makefile.config:778: No libcrypto.h found, disables jitted code injection, > > > > > please install openssl-devel or libssl-dev > > > > > > > > > > Auto-detecting system features: > > > > > ... dwarf: [ on ] > > > > > ... dwarf_getlocations: [ on ] > > > > > ... glibc: [ on ] > > > > > ... libbfd: [ on ] > > > > > ... libbfd-buildid: [ on ] > > > > > ... libcap: [ on ] > > > > > ... libelf: [ on ] > > > > > ... libnuma: [ on ] > > > > > ... numa_num_possible_cpus: [ on ] > > > > > ... libperl: [ on ] > > > > > ... libpython: [ on ] > > > > > ... libcrypto: [ OFF ] > > > > > ... libunwind: [ on ] > > > > > ... libdw-dwarf-unwind: [ on ] > > > > > ... zlib: [ on ] > > > > > ... lzma: [ on ] > > > > > ... get_cpuid: [ on ] > > > > > ... bpf: [ on ] > > > > > ... libaio: [ on ] > > > > > ... libzstd: [ on ] > > > > > ... disassembler-four-args: [ on ] > > > > > ``` > > > > > > > > > > This is very confusing because the suggested library (on my Ubuntu 20.04 > > > > > it is libssl-dev) is already installed. As the test only checks for the > > > > > presence of libcrypto, this commit suppresses the deprecation warning to > > > > > allow the test to pass. > > > > > > > > > > Signed-off-by: Zixuan Tan > > > > > --- > > > > > tools/build/feature/test-libcrypto.c | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git a/tools/build/feature/test-libcrypto.c b/tools/build/feature/test-libcrypto.c > > > > > index a98174e0569c..31afff093d0b 100644 > > > > > --- a/tools/build/feature/test-libcrypto.c > > > > > +++ b/tools/build/feature/test-libcrypto.c > > > > > @@ -2,6 +2,12 @@ > > > > > #include > > > > > #include > > > > > > > > > > +/* > > > > > + * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the > > > > > + * feature test to fail silently. This is a workaround. > > > > > + */ > > > > > > > > then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, > > > > so I wonder how come the rest of the compilation passed for you.. do you have > > > > CONFIG_JITDUMP disabled? > > > > > > > > thanks, > > > > jirka > > > > > > > No, CONFIG_JITDUMP is not disabled. I am using the default configuration. > > > > > > Yes, you are right. The rest of the compilation should fail, but it doesn't. > > > I checked the verbose build commands. This seems to be the result of another > > > inconsistency. > > > > > > If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be > > > defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" > > > prefix is checked. This causes urandom always be used to create build id > > > rather than MD5 and SHA1, no matter what the detection result is. > > > > > > In perf/Makefile.config, from line 776 > > > ``` > > > ifndef NO_LIBCRYPTO > > > ifneq ($(feature-libcrypto), 1) > > > msg := $(warning No libcrypto.h found, disables jitted code injection, > > > please install openssl-devel or libssl-dev); > > > NO_LIBCRYPTO := 1 > > > else <-- if libcrypto feature detected > > > CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT <-- define this > > > EXTLIBS += -lcrypto > > > $(call detected,CONFIG_CRYPTO) > > > endif > > > endif > > > ``` > > > > > > In perf/util/genelf.c, from line 33 > > > ``` > > > #ifdef HAVE_LIBCRYPTO <-- but check this, it's always false > > > > nice :) > > > > > > > > #define BUILD_ID_MD5 > > > #undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ > > > #undef BUILD_ID_URANDOM /* different uuid for each run */ > > > > > > #ifdef BUILD_ID_SHA > > > #include > > > #endif > > > > > > #ifdef BUILD_ID_MD5 > > > #include > > > #endif > > > #endif <-- this block will be skipped > > > ``` > > > > > > Maybe we should fix this, to really make use of libcrypto if it is available? > > > > yea, I think that was the original idea, let's keep the variable with > > SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c > > > > full fix would be to detect the new API and use it when it's available but.. > > given that the check was false at least since 2016, perhaps we could remove > > that code? ;-) Stephane? > > ping So, we should start with 谭梓煊 patch, then fix that ifdef and go on from there? - Arnaldo