Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 Aug 2022 20:13:44 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sudip Mukherjee <sudip.mukherjee@sifive.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        greentime.hu@sifive.com, jude.onyenegecha@sifive.com,
        william.salmon@sifive.com, adnan.chowdhury@sifive.com,
        ben.dooks@sifive.com, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        jeegar.lakhani@sifive.com
Subject: Re: [PATCH 04/11] spi: dw: use TMOD_RO to read in enhanced spi modes
Message-ID: <Yul3aNP8yoBf5QWu@sirena.org.uk>
References: <20220802175755.6530-1-sudip.mukherjee@sifive.com>
 <20220802175755.6530-5-sudip.mukherjee@sifive.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7HxAbNud4AYGSDtm"
Content-Disposition: inline
In-Reply-To: <20220802175755.6530-5-sudip.mukherjee@sifive.com>
Precedence: bulk


--7HxAbNud4AYGSDtm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 02, 2022 at 06:57:48PM +0100, Sudip Mukherjee wrote:
> When we are using the enhanced spi modes we can not use EEPROM Read.
> The Synopsys datasheet mentions EEPROM Read is not applicable in
> enhanced SPI modes. We will need to use Receive only mode.
>=20
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@sifive.com>
> ---
>  drivers/spi/spi-dw-core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
> index 8c84a2e991b5..8e624620864f 100644
> --- a/drivers/spi/spi-dw-core.c
> +++ b/drivers/spi/spi-dw-core.c
> @@ -727,7 +727,10 @@ static int dw_spi_exec_mem_op(struct spi_mem *mem, c=
onst struct spi_mem_op *op)
>  	cfg.dfs =3D 8;
>  	cfg.freq =3D clamp(mem->spi->max_speed_hz, 0U, dws->max_mem_freq);
>  	if (op->data.dir =3D=3D SPI_MEM_DATA_IN) {
> -		cfg.tmode =3D DW_SPI_CTRLR0_TMOD_EPROMREAD;
> +		if (enhanced_spi)
> +			cfg.tmode =3D DW_SPI_CTRLR0_TMOD_RO;
> +		else
> +			cfg.tmode =3D DW_SPI_CTRLR0_TMOD_EPROMREAD;

This is fixing the previous commit...

--7HxAbNud4AYGSDtm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLpd2gACgkQJNaLcl1U
h9AdcQf/fp0qGacGXOTmxLhzXNUGajNyCyIQp3hVO43WcLLNP1qX7SwYdQqpJsWL
+Uodapi9ubYTtcuQRK/vTodDYvuYLM4lCY3uEga/7aTesUwFrYL/ExoW8eaqI67B
HC6fmMyp44SZHhKAjp5ayY7HXg0e/eAAY8LwapbRfFC8W93kVApYWirG9hPCYS+W
HGw+HZ80eyBcA0fQNBXzWqfD0Mr0LpIy0itNFZQU/kqcJANcBYuL23i1XkvLFhTJ
I0sOmMtidWMjhig9BvOtfmenSOMvNMVd/PIgGdHI8o21d8f4odJJ9Meni8q4jxkE
s1oep2Sjf6h+xyDDUGGHUoO2irGkBw==
=mC5X
-----END PGP SIGNATURE-----

--7HxAbNud4AYGSDtm--