Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965757AbXFFXEy (ORCPT ); Wed, 6 Jun 2007 19:04:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935675AbXFFXEn (ORCPT ); Wed, 6 Jun 2007 19:04:43 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:2748 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935639AbXFFXEm (ORCPT ); Wed, 6 Jun 2007 19:04:42 -0400 X-AuthUser: davidel@xmailserver.org Date: Wed, 6 Jun 2007 16:04:40 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Alan Cox cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Ulrich Drepper , Ingo Molnar , Eric Dumazet Subject: Re: [patch 7/8] fdmap v2 - implement sys_socket2 In-Reply-To: <20070606235906.72439d16@the-village.bc.nu> Message-ID: References: <20070606235906.72439d16@the-village.bc.nu> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 41 On Wed, 6 Jun 2007, Alan Cox wrote: > > The sys_accept() system call has been modified to return a file > > descriptor inside the non-sequential area, if the listening fd is. > > The sys_socketcall() system call has been also changed to support > > a new SYS_SOCKET2 indentifier. > > This still all seems really really ugly. Is there anything wrong with > throwing all these extra cases out and replacing the entire lot with > > prctl(PR_SPARSEFD, 1); > > to turn on sparse fd allocation for a process ? There was a little discussion where I tried to whisper something similar, but Linus and Uli shot me :) - with good reasons IMO. You may link to runtimes that are not non-sequentialfd aware, and will break them. > Anyone needing to deal with certain special fds will use dup2() anyway so > a task global switch seems to be cleaner and make the behaviour simply to > flip on, with no extra calls (and you need to submit man pages for them > all too), and also more importantly no new glibc stuff should be needed, > and a process can try to set sparsefd, fail and carry on so its more > portable and back portable. Man pages! Damn, I forgot Michael Kerrisk is already waiting for the other stuff :( - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/