Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220625153439.513559-1-tanzixuan.me@gmail.com>
 <YrhxE4s0hLvbbibp@krava> <CABwm_eT_LE6VbLMgT31yqW=tc_obLP=6E0jnMqVn1sMdWrVVNw@mail.gmail.com>
 <Yrqcpr7ICzpsoGrc@krava> <YufUAiLqKiuwdvcP@krava> <YuloQYU72pe4p3eK@kernel.org>
 <YulpPqXSOG0Q4J1o@kernel.org>
In-Reply-To: <YulpPqXSOG0Q4J1o@kernel.org>
From:   Zixuan Tan <tanzixuan.me@gmail.com>
Date:   Wed, 3 Aug 2022 13:16:51 +0800
Message-ID: <CABwm_eR-UmVr71XxJE-SUVHUCi-2OniDh7S9hhHZeNfp4KcZgA@mail.gmail.com>
Subject: Re: [PATCH] perf build: Suppress openssl v3 deprecation warnings in
 libcrypto feature test
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc:     Jiri Olsa <olsajiri@gmail.com>,
        Stephane Eranian <eranian@google.com>,
        Zixuan Tan <tanzixuangg@gmail.com>, terrelln@fb.com,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 3, 2022 at 2:13 AM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Tue, Aug 02, 2022 at 03:09:05PM -0300, Arnaldo Carvalho de Melo escrev=
eu:
> >
> > So, we should start with =E8=B0=AD=E6=A2=93=E7=85=8A patch, then fix th=
at ifdef and go on
> > from there?
>
> I.e. with this:
>
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index aed49806a09bab8f..953338b9e887e26f 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -30,7 +30,11 @@
>
>  #define BUILD_ID_URANDOM /* different uuid for each run */
>
> -#ifdef HAVE_LIBCRYPTO
> +// FIXME, remove this and fix the deprecation warnings before its remove=
d and
> +// We'll break for good here...
> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> +
> +#ifdef HAVE_LIBCRYPTO_SUPPORT
>
>  #define BUILD_ID_MD5
>  #undef BUILD_ID_SHA    /* does not seem to work well when linked with Ja=
va */

yea, i think that's ok, thank you

Zixuan