Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 08:36:49 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Rajat Khandelwal <rajat.khandelwal@intel.com>
Cc:     andreas.noever@gmail.com, michael.jamet@intel.com,
        YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, pmalani@google.com, bleung@google.com
Subject: Re: [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers
Message-ID: <YuoJceCfuJ4RKon5@lahna>
References: <20220803010139.GA32634@rajth-NUC10i7FNH>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220803010139.GA32634@rajth-NUC10i7FNH>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

Hi,

On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend
> and simultaneously project the screen on an external display connected
> to a TBT/USB4 device. This patch enables this feature.
> 
> Let me know what you think about this.

Please prefix patches to follow the sybsystem style. For Thunderbolt it
should be "thunderbolt: ....".

This will cause any monitor plug to wake up the system and I'm not sure
we want that, at least to be default behaviour. If you have a regular
Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it
wake up?

IIRC I already suggested you to do this for the USB4 ports themselves
(struct usb4_port) so that userspace can make them wake up the system on
any event by writing "enabled > .../wakeup" which is the normal way.