Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220801101447.86207-1-gene.chen.richtek@gmail.com>
 <20220801101447.86207-5-gene.chen.richtek@gmail.com> <YujeA2pHG2WnZjaF@kuha.fi.intel.com>
 <20220802085848.GA3096405@roeck-us.net>
In-Reply-To: <20220802085848.GA3096405@roeck-us.net>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Wed, 3 Aug 2022 14:20:44 +0800
Message-ID: <CAE+NS34JmppcAXdYSynuX7wdNKgByogKDn=AmW_PgR13nZ48=g@mail.gmail.com>
Subject: Re: [PATCH v3 4/7] usb: typec: tcpci_rt1711h: Add initial phy setting
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Gene Chen <gene_chen@richtek.com>,
        ChiYuan Huang <cy_huang@richtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Guenter Roeck <linux@roeck-us.net> =E6=96=BC 2022=E5=B9=B48=E6=9C=882=E6=97=
=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=884:58=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Tue, Aug 02, 2022 at 11:19:15AM +0300, Heikki Krogerus wrote:
> > Hi Gene,
> >
> > On Mon, Aug 01, 2022 at 06:14:44PM +0800, Gene Chen wrote:
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > Add initial phy setting about phy dicard retry,
> > > rx filter deglitech time and BMC-encoded wait time
> >
> > I'm sorry, but what does "deglitech" mean? Is it just a typo?
> >
>
> deglitch ?
>

Yes, typo, I will fix it.

> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > >  drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 ++++++++++++++-
> > >  1 file changed, 14 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typ=
ec/tcpm/tcpci_rt1711h.c
> > > index df7bfe299987..33d8ea95b7c1 100644
> > > --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> > > +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> > > @@ -20,6 +20,9 @@
> > >  #define RT1711H_VID                0x29CF
> > >  #define RT1711H_PID                0x1711
> > >
> > > +#define RT1711H_PHYCTRL1   0x80
> > > +#define RT1711H_PHYCTRL2   0x81
> > > +
> > >  #define RT1711H_RTCTRL8            0x9B
> > >
> > >  /* Autoidle timeout =3D (tout * 2 + 1) * 6.4ms */
> > > @@ -107,8 +110,18 @@ static int rt1711h_init(struct tcpci *tcpci, str=
uct tcpci_data *tdata)
> > >             return ret;
> > >
> > >     /* dcSRC.DRP : 33% */
> > > -   return rt1711h_write16(chip, RT1711H_RTCTRL16, 330);
> > > +   ret =3D rt1711h_write16(chip, RT1711H_RTCTRL16, 330);
> > > +   if (ret < 0)
> > > +           return ret;
> > > +
> > > +   /* Enable phy discard retry, retry count 7, rx filter deglitech 1=
00 us */
> > > +   ret =3D rt1711h_write8(chip, RT1711H_PHYCTRL1, 0xF1);
> > > +   if (ret < 0)
> > > +           return ret;
> > >
> > > +   /* Decrease wait time of BMC-encoded 1 bit from 2.67us to 2.55us =
*/
> > > +   /* wait time : (val * .4167) us */
> > > +   return rt1711h_write8(chip, RT1711H_PHYCTRL2, 62);
> > >  }
> > >
> > >  static int rt1711h_set_vbus(struct tcpci *tcpci, struct tcpci_data *=
tdata,
> > > --
> > > 2.25.1
> >
> > thanks,
> >
> > --
> > heikki