Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d90a6a11-f6c4-9e29-61a1-c96f1ceb100b@nvidia.com>
Date:   Wed, 3 Aug 2022 12:02:06 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 1/5] vfio: Add the device features for the low power
 entry and exit
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>
Cc:     Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
References: <aaef2e78-1ed2-fe8b-d167-8ea2dcbe45b6@nvidia.com>
 <20220725160928.43a17560.alex.williamson@redhat.com>
 <bd7bca18-ae07-c04a-23d3-bf71245da0cc@nvidia.com>
 <20220726172356.GH4438@nvidia.com>
 <f903e2b9-f85b-a4c8-4706-f463919723a3@nvidia.com>
 <20220801124253.11c24d91.alex.williamson@redhat.com>
 <YukvBBClrbCbIitm@nvidia.com>
 <20220802094128.38fba103.alex.williamson@redhat.com>
 <YulSOK+YKjV2634b@nvidia.com>
 <20220802105755.2ee80696.alex.williamson@redhat.com>
 <YulYVOWh8km2knhx@nvidia.com>
From:   Abhishek Sahu <abhsahu@nvidia.com>
In-Reply-To: <YulYVOWh8km2knhx@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0xFaUtvVkJ2OXZ5Z1ZvUzlPQVgzeU91d2YyUG1WTU4rOVEvVk5NUFZiWWww?=
 =?utf-8?B?dzZHbTAyT0ZEa3psQVQvWXY4MWNHOE91cFJsdE54UFZNLzhGNW11a3I0N21P?=
 =?utf-8?B?RWRlU1g1emRPaUtJeWNPT0hPOUJYRVEzcS9vSWlrU3VRZm5JNEYyUmxMY1ZP?=
 =?utf-8?B?YUxYMWRsN1lRM1JTZ1FDUWdaL2NQNk10N0xMR3daZnNNYlB3UUY4dGNUMzZ4?=
 =?utf-8?B?cUtBdmVUbGNlc3Z1ZCs5UGZNSm5NWmFPcUhiZ1NoMzh0cExNd21vSEVocndZ?=
 =?utf-8?B?c3R1ZkNZRCtaYURTQ29jWmw2L3VXcWFOZ1JMdUhWNTYvSzViQ3ZLbTRaSVA2?=
 =?utf-8?B?a1owQUJWVDE4eVcwQXQyRE1INWdiMTZDbHRyTGt4QndyTmJxaU5RQTN3eXZn?=
 =?utf-8?B?Z3B0a0RjcDMwa24zaEgxS0FTYXRHMDZYNmpwUFhtZmhIWjJBdks4OUNoU0x3?=
 =?utf-8?B?dGRGclhzblZpUjA0SjJsRHpQUjJsMVd3Z0JhV0g3dVduaE9rK3FUd3RWdlFn?=
 =?utf-8?B?VjloOUVJUTUxd2dSUGJKUlFNVStqUjYvUG4yRlBmdW8rcVdiUWJXbEdPL0xa?=
 =?utf-8?B?SlhwU3NCbnNiYVZFS1FJMlV0d1NnUEYrTEV5RElrdHByNVJxVHBmNVU5OXZU?=
 =?utf-8?B?OU85VDFTV2Vmc29oUjN6cENCZ2dTdXdVRElUYWJIVVRMeWloQm5qcnI1RDA5?=
 =?utf-8?B?Vis2OHBXN3ZGSTVDSkFZL1IvT0dWeGdHUnV4N2NvQ1ZvK1VMd3ZkYWtLRDNs?=
 =?utf-8?B?VFQyRHE3L0ZGOFgxRFBJWVRaNk12Z1A4ZlR4dG4rbGxFK3Iva3lhdTYxa2No?=
 =?utf-8?B?U216ejF2NXUxM3I1dHZjeVVFdW5CUkZ0OFRqb1VOMkkrU1NjVHlLdXFBTWVT?=
 =?utf-8?B?N2F4THI1cjZpT0VNZnphQUczaU9ray95RWZneEFvUmZ4Z05YM3RCaUJreFNH?=
 =?utf-8?B?MFllQjlLdk9QbkJuODQ3bnNySFAwWXNvZVhPOEk4eHpXOXlOaVZaTjFXcWp2?=
 =?utf-8?B?MDcvc2x1cnpaM2gwU3p1dm1UQmtGTk1MY3VXNm1KVHhYMVZFaG9SU3hFOHRO?=
 =?utf-8?B?RkZINktqYytFNXNYSk9Gc3BCbW9jclhMTG5taDNBMHZ2WW5ZdzQ5eWlMb3RV?=
 =?utf-8?B?MzJCc1NhZCt5cHBEcDdRQngwQ3EvQmw0L2dqZkxORkw3ME9pV1REWGhQTysr?=
 =?utf-8?B?U1RNdW1jdm9OUStqQWN5dmxub2FST1RHRXFUcURpcmw4WlhVSEVCNUwzbzgz?=
 =?utf-8?B?aTNWVGkrUzZ3S3pMZzFuVFFJYTdYdy9VV1E4TmxoWTlJaVlNQWEwVllMQnpT?=
 =?utf-8?B?cUprVHJoR1pCM1ZUdjQ1Y25kVXYzekhpNk1Rbk9wVW42UlZpWWFqdll5dXpI?=
 =?utf-8?B?MFJIdmtyZUU3UkI0cUdaa3QwVUtIbi9HUnVOb1AzMFBWcGE1eWdlRVc2cENo?=
 =?utf-8?B?UlM0bUhHUmlsZlVSekkvNzZQdG5LUnFpcHRXTk15eXdrL0RSZTREdjlkVkh6?=
 =?utf-8?B?SjdzdlBabFYwRjJWQWF4V1Rab2pqNWI0bHVhdkNFeTJoNkJJeDZ4NlpWQXVI?=
 =?utf-8?B?UFA1QWtDUDZSWFFBaitIUmg3dXRyK2k3N3NySVREd3ZmWE5zTzUrbmovbkNU?=
 =?utf-8?B?NVk2OGVBQjA1RTVCTVZnYmhnNElBZUNLTGtQcjk1cVBseWt6ZllwdS90S3ZD?=
 =?utf-8?B?VzlqZEpkeDFSN3p4ODFTVm1qUVk4UnpuVlpwbzJtN2pSSnJJbUJmVHRwWWJk?=
 =?utf-8?B?cjJHaCtabjM4c3BaaUxqRTRFVHF1bEwwK0hHYWsraHpzVy9PZUM5NkVsTlN0?=
 =?utf-8?B?Y05pczRtSHJzNkZ1YVBHT0pmQ0RPVFRCU290dkp0c25tU005NUFCNGdOT0pz?=
 =?utf-8?B?b0MzQnREV3h3UVZJRnV6b2N3dzhuazdnYk00aEtqVkxWQWVIeGRzUlYvZWlh?=
 =?utf-8?B?Q0xCMXVsT1hSL3ZKa1V4MDcyU3JSMWYrcVRGTWlKc21EQ21MNHF6SU1kUHcz?=
 =?utf-8?B?RkRucVpmRXBlQ24zSm9Qb2ZsTy91NU9ZaUVjaDNxeC9sZWN2WnNHaDdkblVM?=
 =?utf-8?B?TG1oTDB4N1IxVFplVUFmOW1qQVNObll3aHRCTzBZckorUE5GK1lTWnBpRjFt?=
 =?utf-8?Q?1DjA4tRxVVcB5N6Gb1s/Z75Te?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3d26cd3-2e5d-4090-384e-08da7519e9ad
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5304.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 06:32:19.7412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fTt+3+poOdIvBzQFIgiY3QkvPyaokYsHjtLA9yBSVxWgk0Q6w6Yjf9uyhAzpdnoRKZdSDNs51VhfOtZFUPAxug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6434
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/2/2022 10:31 PM, Jason Gunthorpe wrote:
> On Tue, Aug 02, 2022 at 10:57:55AM -0600, Alex Williamson wrote:
>> On Tue, 2 Aug 2022 13:35:04 -0300
>> Jason Gunthorpe <jgg@nvidia.com> wrote:
>>
>>> On Tue, Aug 02, 2022 at 09:41:28AM -0600, Alex Williamson wrote:
>>>
>>>> The subtlety is that there's a flag and a field and the flag can only
>>>> be set if the field is set, the flag can only be clear if the field is
>>>> clear, so we return -EINVAL for the other cases?  Why do we have both a
>>>> flag and a field?  This isn't like we're adding a feature later and the
>>>> flag needs to indicate that the field is present and valid.  It's just
>>>> not a very clean interface, imo.  Thanks,  
>>>
>>> That isn't how I read Abhishek's proposal.. The eventfd should always
>>> work and should always behave as described "The notification through
>>> the provided eventfd will be generated only when the device has
>>> entered and is resumed from a low power state"
>>>
>>> If userspace provides it without LOW_POWER_REENTERY_DISABLE then it
>>> still generates the events.
>>>
>>> The linkage to LOW_POWER_REENTERY_DISABLE is only that userspace
>>> probably needs to use both elements together to generate the
>>> auto-reentry behavior. Kernel should not enforce it.
>>>
>>> Two fields, orthogonal behaviors.
>>
>> What's the point of notifying userspace that the device was resumed if
>> it might already be suspended again by the time userspace responds to
>> the eventfd? 
> 
> I don't know - the eventfds is counting so it does let userspace
> monitor frequency of auto-sleeping.
> 
> In any case the point is to make simple kernel APIs, not cover every
> combination with a use case. Decoupling is simpler than coupling.
> 
> Jason


 Thanks Alex and Jason for your inputs.

 It seems, I can use the original uAPI where we will have 2 variants
 of ENTRY.

 Since already kernel merge window is started, so I will wait for
 v5.20-rc1 (or v6.0-rc1) and then I will rebase and test my patches on
 the updated kernel.

 Regards,
 Abhishek