Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH] tty: serial: imx: initialize peripheral_config/peripheral_size for sdma config
Date:   Wed,  3 Aug 2022 14:57:37 +0800
Message-Id: <20220803065737.14752-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D6gJAQYM4/PwUciLdvE2Z8aPWHdiu3pf66XitZQceRFOti4OJIuGQ9Ba7/3L?=
 =?us-ascii?Q?ebJE0kiZdkLc3mBGAab6Un8tCdEFKFU4DAlCRE9JpIS41J7pQB7gkfCRdIZr?=
 =?us-ascii?Q?8Y20WTUlVcAsOXsTm3325mNXrk9C5hfDyHoVjaX9AbRYV5mR56BLaHFFvziX?=
 =?us-ascii?Q?TZocEiTBmr3DLqJxHdtLa+OTKmdgKLL7DaIl4brhehYvXLmOEjnZ5o3cmKyD?=
 =?us-ascii?Q?v2m/r8D4csUa8SAhrokgcq7aJvSBtMujvKoqXY9qQvw1AlgGIs0HNl7vVoze?=
 =?us-ascii?Q?Y0EZkoY1cJl6UmZ6m6TaoxYRGmOairCdU3iuNUrsRstVeKigXFeUS2CazxyB?=
 =?us-ascii?Q?pghudGouB7TF4vigVg+ZcjQANKWJ1Peb76xRls8CA/74T7uURJ1tz3wmRUYV?=
 =?us-ascii?Q?MBM8EgpygxzIdzZWcrTjU5Vh7yfxUyfc707tZUVLX1gJ+rUbkhAskuPmR0vt?=
 =?us-ascii?Q?A38DeqI9EhpAKVYBO2++BHBFSpU9m8SHWm7CHX1Lb1CqC/e5k0a06CdMkTaR?=
 =?us-ascii?Q?tXcH8A87X+deuI/oBQ/AcGsy08f9wx1CVPJDNpavbhQSHcHkjFQiuIl8w1Nw?=
 =?us-ascii?Q?m3p9hsbaSWUygmjOdDpD+qlks8TVwQzbfOZ6ErOQQ6A5RUUTONx8GlflXGAA?=
 =?us-ascii?Q?/71zCDQCmddk5nylXLGvTDKtvfM1WzSmfzNghETIxOr/Fg18m4Uc6c79Pulz?=
 =?us-ascii?Q?AGh0xt5hdn5+kC+kxgLZAhuaDsiBUqb0FrS6YIIXfjJHZzkbg3YNTlMfpHeN?=
 =?us-ascii?Q?lMiDsr0ksdxSimXxapz+ekg+f/co0RfzqzSbzksLuioPY+QupyvBUeWFK94y?=
 =?us-ascii?Q?3NbR/MyA81BIiUQtjTPZA8qYvSSul4OJjHlGqrIe5JZzjD7ppcG1Yp2GZf6q?=
 =?us-ascii?Q?6mRrAUgwf5Jynhc2kqD6Rgg/3gA3/3RRmui3DYkLeIMemw1Aw0Q3oYo4N7rN?=
 =?us-ascii?Q?mTZ7aTJg7Z3DYwgECilbZB8e/MdnnIxkSiGTHoVHO0K/3Mhi3vMVTVoRiEzC?=
 =?us-ascii?Q?Bz4LGkgOTg5dT4AOJFHK7WwpEpodjsyYy+eGbXwBLArNZHn3yxcc5EDfLFQf?=
 =?us-ascii?Q?N8YIFPCqCuHf4D5t4wS0w9UKPcazu3Aq7lRQmi6BcbVNORAz2TpeQmZdghtZ?=
 =?us-ascii?Q?sEoolpOX2HbTR766dKdjPKW1/vqGmigXy7XYyh+zg4COQvVHiOpKuk0zsRiT?=
 =?us-ascii?Q?IqdeU2oiB/2kwqpKP8m+nPF1d3pkBffShfo0fOLgdBR0MAaWAWW2VmKg8cHV?=
 =?us-ascii?Q?V4w1owc8AnZpu8Iq77UPQwKOufKJkz64y9tOJ3JyNAT0hFww8DTHPZvgf+DI?=
 =?us-ascii?Q?WEaLuSQsmEP/Ea1Rt+DFA8ZHn61iBf2kynQb3X8neHt7Eyi0xtCGeJsRR9TP?=
 =?us-ascii?Q?fSVUcTV+OFa6+8JVwvZlXkkFUPy+wOpvQiWzA+n7NiR4peHtXVXX9AG8pckN?=
 =?us-ascii?Q?FhAtP+UngC+nlAJ8QawB5EOula9HXdZJPd81UZ+HtAGOM8V0ssphrQCebuTK?=
 =?us-ascii?Q?COrf5dJePGUVwwtetWgo5adphFih+iY9ridoRPR99+WRgcRlkjoW1RPUKaGO?=
 =?us-ascii?Q?kT1foYKt2yxi8MHgSKl6vjay9Xyljsaf0QTr9xGj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 006e29f4-982d-42bd-856b-08da751e0160
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 07:01:36.2198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fzXWPZYj4YX0/hyknuZdDoBNlfD8RMLU4bq5uWpVrTfE4ciyx0ieXdHMi0ZJCn92rni+1AvIFVDkvOhUylmyYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8024
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 824a0a02cd74 ("dmaengine: imx-sdma: Add multi fifo support")
adds the use of dma_slave_config->peripheral_config/peripheral_size to
sdma driver, the client drivers like uart need to initialize the
peripheral_config/peripheral_size for sdma, otherwise, the random value
of local variable slave_config may cause unexpected peripheral_config
and make sdma mess up.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/imx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 522445a8f666..bb8c2a712e94 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1320,6 +1320,8 @@ static int imx_uart_dma_init(struct imx_port *sport)
 	slave_config.src_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
 	/* one byte less than the watermark level to enable the aging timer */
 	slave_config.src_maxburst = RXTL_DMA - 1;
+	slave_config.peripheral_config = NULL;
+	slave_config.peripheral_size = 0;
 	ret = dmaengine_slave_config(sport->dma_chan_rx, &slave_config);
 	if (ret) {
 		dev_err(dev, "error in RX dma configuration.\n");
@@ -1346,6 +1348,8 @@ static int imx_uart_dma_init(struct imx_port *sport)
 	slave_config.dst_addr = sport->port.mapbase + URTX0;
 	slave_config.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
 	slave_config.dst_maxburst = TXTL_DMA;
+	slave_config.peripheral_config = NULL;
+	slave_config.peripheral_size = 0;
 	ret = dmaengine_slave_config(sport->dma_chan_tx, &slave_config);
 	if (ret) {
 		dev_err(dev, "error in TX dma configuration.");
-- 
2.17.1