Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        "Malani, Prashant" <pmalani@google.com>,
        "bleung@google.com" <bleung@google.com>
CC:     "andreas.noever@gmail.com" <andreas.noever@gmail.com>,
        "Jamet, Michael" <michael.jamet@intel.com>,
        "YehezkelShB@gmail.com" <YehezkelShB@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>
Subject: RE: [PATCH] thunderbolt: Supporting wake on DP hot events behind
 TBT/USB4 routers
Thread-Topic: [PATCH] thunderbolt: Supporting wake on DP hot events behind
 TBT/USB4 routers
Thread-Index: AdinCrp/wAKoliRWSz2ixLRb9JQnKw==
Date:   Wed, 3 Aug 2022 07:29:36 +0000
Message-ID: <CO1PR11MB48353AD9FD931B1D4AD5646F969C9@CO1PR11MB4835.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0hC74bW31jCGNUhV/F47kcmRNu5kQGHRxHLwpe/Pji9MUxgYehSZVOp9spZ9?=
 =?us-ascii?Q?Wrz/KrUNiE06bePz+wW9E+K4z8eIDejsKS2HG0I3TxTFM34x6YLh1mlilzZz?=
 =?us-ascii?Q?Pz1zmQWVchqeiBGhPj58OJH6wJnpr75O3i9YeZYHAY69a+4AkvYC64IkgsHD?=
 =?us-ascii?Q?i5vx/mRGJEHBBf28p3cblwnZRu7RyxrRCBbeNEK98E2n2ls7aHpMyjjvDrKS?=
 =?us-ascii?Q?8Eh7LkG6kMJYiPqNKxE5mNgT942HXC1o5YI/iNbgeljaU9Wdk/xXo/s7QD/b?=
 =?us-ascii?Q?o8qX9k7ZD5bKd5VVb/8/AsLbl3QZl2INEwPaP1TQ0X3lbH1NC9qrl+o84Hn0?=
 =?us-ascii?Q?MzZPKpCdh2r7sAFrwJd9Ry4r0dUbZEsYPJ5GmAdhXhPbkxmLrQZbhubY0ntV?=
 =?us-ascii?Q?H3PcMkA2+adb3tvMU2nsk4B+ZLmoRUWfpXf37eMl6btdTAHzplr3olvmjENY?=
 =?us-ascii?Q?JoUaUCnP9I0ObgIsElu6W2kyVqWpymoPm10cDRXyyIAiRJq4Cw0pmK+vZERU?=
 =?us-ascii?Q?Mu42YLLGiTc/ckDNHpEhPn/JSlwKHEsyNpNUkX2Ir/XNw4CwLXgfCH/2Gv//?=
 =?us-ascii?Q?RkW2MdFjoKz+KloOTxfCywLr0bSb1Cl76UgVWWaq1Hc4dcqnfPTxMHnJ4Hw9?=
 =?us-ascii?Q?pm7K0ycCi1jgoIBeD+kXraEUM2F89Hd9BurwAiKmN6efZ90RaZ3LH8eKsI++?=
 =?us-ascii?Q?qxrptRjWk+Bb62tmR/bkOwl6C+rGweiRr9BnSRxUFnbDEnZ8apgcZ5rkQP46?=
 =?us-ascii?Q?pgx/irtunYcftkjHCjferf5EfCve6+a7NOClm8aKyPcKwsMAx0ICkU7ftkc9?=
 =?us-ascii?Q?wEX1aySmTG5lYxgRymF4twwSPTx+TZvhQg3E8KsGN18ZVRP8yohzrfGYKK45?=
 =?us-ascii?Q?TOvyC7ZbuHmjM0Br31KzlIiH2HXMiP1yRE8D/eTPa+SCbxiFW4fCHVqfGb3f?=
 =?us-ascii?Q?m1E6+CQxg8Q7ezc0tyDJU18H8hor7fx1ZMvFEKQTXbVvVkPmuWfyZBAmUSz5?=
 =?us-ascii?Q?rj1YrIpHhKfJacZcTgCZAgbWYbNUK9N+Xnuhi5oY4qYCgtBa8xvw3xgrurDJ?=
 =?us-ascii?Q?Rq+htuH+v4BfDQpU6kAuekT5jd3+4oBWSFNq7LX0e3x82hbP7Kd3ul6Y0Lq1?=
 =?us-ascii?Q?dUEll39VD+zqqzsIlXDzfTsq4C85WKVSFoK4UZ+TMvgYVU33/B5OAJAoJ9Nd?=
 =?us-ascii?Q?76BjD7TjWSuegWab16Jz1QTXgYupvtWUbuVJNSKrrGxtZMuOGE8DjqDyY6J7?=
 =?us-ascii?Q?OkzvGku0PP4BARTDbFve6HFobJ52ne4V5dCTN+r4dlEb6sK4EbfCN/yYehUu?=
 =?us-ascii?Q?Mo/c6d1ySfTF57P4baSYL3rZKqpWbundXX6/80vpflOFIP7EpnDRdhvDMIhR?=
 =?us-ascii?Q?3C5uM73YcahgkazKy83JVVBynlQ1xPsVgA1SZ8jErZsIOMLHK9lprN1C73B5?=
 =?us-ascii?Q?B30Rwu8Xiu5nhLZ2OkxSEa5ErL//pI6WxP5XymBxsUz/iiWDMvhyzM7OI50x?=
 =?us-ascii?Q?Yd3LNK82ImX0IHj5QAgX2j0qfw75esnTwmZKvNEsy+eKqku6r3McISmZjCE7?=
 =?us-ascii?Q?RCwUMpq61isoRQ6oGTQdKzmsOKibysEjAgRMwGT3Wn9xOsNAvkQr17IBvOhX?=
 =?us-ascii?Q?dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 700aae25-a68e-4fc6-36ac-08da7521eb10
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 07:29:36.4269
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cLJeWedVaWjYOq/GVZqkEcXCd8nLXJZoQeL/ohs0xYeXBvhd52VJVeBrhNK5LN50jnfDaAUXRn4Ch8hwfaG1zz4llBCwKY+7c35bdh1FoOI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2366
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Abhijeet
@Benson Leung @Malani, Prashant Please provide your comments.=20

-----Original Message-----
From: Mika Westerberg <mika.westerberg@linux.intel.com>=20
Sent: Wednesday, August 3, 2022 11:07 AM
To: Khandelwal, Rajat <rajat.khandelwal@intel.com>
Cc: andreas.noever@gmail.com; Jamet, Michael <michael.jamet@intel.com>; Yeh=
ezkelShB@gmail.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org=
; Malani, Prashant <pmalani@google.com>; bleung@google.com
Subject: Re: [PATCH] thunderbolt: Supporting wake on DP hot events behind T=
BT/USB4 routers

Hi,

On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend
> and simultaneously project the screen on an external display connected
> to a TBT/USB4 device. This patch enables this feature.
>=20
> Let me know what you think about this.

Please prefix patches to follow the sybsystem style. For Thunderbolt it
should be "thunderbolt: ....".

This will cause any monitor plug to wake up the system and I'm not sure
we want that, at least to be default behaviour. If you have a regular
Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it
wake up?

IIRC I already suggested you to do this for the USB4 ports themselves
(struct usb4_port) so that userspace can make them wake up the system on
any event by writing "enabled > .../wakeup" which is the normal way.