Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] tty: serial: imx: initialize
 peripheral_config/peripheral_size for sdma config
Thread-Topic: [PATCH] tty: serial: imx: initialize
 peripheral_config/peripheral_size for sdma config
Thread-Index: AQHYpwbfzk8jOQKslUeCbcTMT1rdmq2c1H2AgAANtbA=
Date:   Wed, 3 Aug 2022 09:15:58 +0000
Message-ID: <AS8PR04MB8404990740869737F326D302929C9@AS8PR04MB8404.eurprd04.prod.outlook.com>
References: <20220803065737.14752-1-sherry.sun@nxp.com>
 <d4838245-030c-39b4-df4b-17b3b4c73a5b@pengutronix.de>
In-Reply-To: <d4838245-030c-39b4-df4b-17b3b4c73a5b@pengutronix.de>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SSsIpr20e/CV3pizIhdE5UgacHiw+g0PyuHtEATjVIUfPBQsqHvoPOxK93eq?=
 =?us-ascii?Q?fuBhAjg8mhR0kzueWUv2HOxazQWX1FBfdfR/GM3L/RQvszTZ34gh3cWZ3gZ2?=
 =?us-ascii?Q?bFyiviIdEorQvByhNo85sbmDhmsKSynDh/GvItgfv6ARknGh9+vkb7KPT4N/?=
 =?us-ascii?Q?iPNGi+hMe6iAazEntzS3aropczmg3vmgHnd/YXCSiqkiLDPpAhJXKadHDVTe?=
 =?us-ascii?Q?hPOYTCwDoa/IY6cbbJRdTvqo7e1pUVbr3QROi/RwfjHR9Qf666Z79+pgCYw0?=
 =?us-ascii?Q?iCiUd2y7ApIp/DyYsMGAnp0tBV3e9pdljzqmFjvbWwUtxEVdRfE4oXG+8cHg?=
 =?us-ascii?Q?4zcDyGTONZM6c90uzFVgw3Q2SSJNbD2HXrCTw9NPL8EFcWy94LHHANIaHQbn?=
 =?us-ascii?Q?KteaSC5/yNWDrcDhb5IoSF1lrmJciL/7FNO0hDzs2Jd45JBFX7setOy5WYGF?=
 =?us-ascii?Q?AQDqdaUqiyGb+wTse7vrH9FlzUvsZ70A1dENAcevga27fALubV79CaTHJI6v?=
 =?us-ascii?Q?0j06ZihjBz16Sr6EYIaomQiea75EfVefISqwT5m6hlf6fKqEUKMdCeFbNqFS?=
 =?us-ascii?Q?H4tLwXAjuE3JhEOU8Gh3qI3xzHXvc6kdQG+m5Rh3jfY6hcyzW9fWXep9oUCc?=
 =?us-ascii?Q?5HYBoLxvL6Hx7sZ3p2KZiu9IEyc1L+cLruSrg1JTxDO1J8nsHG4ZHdQS9FET?=
 =?us-ascii?Q?5tRSyagl4ziIPKlxVBTLdBEmirdA9gRlvcHA60BNKT67vJ10KEC3vvafZ+fM?=
 =?us-ascii?Q?H3X0N4RVmBEukgfyYKZBPsNBhqxwNIlMMWDB9NE05NhQ7YUVG9p0jfT4ceDj?=
 =?us-ascii?Q?GxW7G7zKgSktrqAfhxPzXUQ6QUwL0Mcq/Hm8jjBOmjPa5aWVw2aNGR9sDRcL?=
 =?us-ascii?Q?NG2F/7/NPr+s/PtksBuaisIEjotxCxdjI31RTE5awxaUmAzcHtjzBfQoo5Mi?=
 =?us-ascii?Q?RnB6CCszHTfRlJ1U1VSgeYQZLLQ6l3ZoopzfVgGLORWHEwiK3q7VSTDAtOaG?=
 =?us-ascii?Q?F2Fda/qrpmHP/GOgVtiWRietsprEG+es9yujRATjcHG3LTVAv4hBy2MOJUgW?=
 =?us-ascii?Q?32kpkoOnCjp5yQxn8xAPDC+LwdHb8j5qWeYpOZRA12587eKoh2iu7La0QU5z?=
 =?us-ascii?Q?4qD9ufcS7TdvZqLfOi+IGhRfmTBwD8W74UtgAV86vXoFN5CaB0rjMm1RHsJR?=
 =?us-ascii?Q?XKU8qOLRnsfUsG0iLeyqiJHfiLtYUzAc3tFwUeU3N8wBXol0DKoG6yAVPHCD?=
 =?us-ascii?Q?FLtex8hcK5Nd759pPqjjsKsKff9kFwW2mG8Ttja12fGsIGyUB6n6bx51oJVS?=
 =?us-ascii?Q?YxmIzG2CKWVpJITpSd+61GBdX3tvGc6MFLtyR7zd+U4bPXl79CepUSfdSyyi?=
 =?us-ascii?Q?f8IYKarr/62UW6/W6HRcPeu8lDMDrBSPJi5ZeKBSApGLNx9SGJc2YhVKa3qC?=
 =?us-ascii?Q?pZj+rYVVIK26CokkkF7MxGJNCeVvUw4LYXAkQhkgscby2jhm78oaPNsCm+XB?=
 =?us-ascii?Q?n9q8OhtD8apPt8NyaKEGtveY5PTxJWK/n7pGxR2n/l9YvfcRI/dGS9nIINul?=
 =?us-ascii?Q?WRpa3tHeivJY+HjVwIIWI7xQvrwMz79/QHdnWqu/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c61bc0cd-82a9-46ad-5c05-08da7530c70a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 09:15:58.3946
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TxK7dlnKmvxvbiMbKGD3JiDaD1DWOhdmScdaP90GFqmHxmJ9Qm1ay3wpABpxA/xn+XlcM72BpEK11K2+jcE/gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5925
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On 03.08.22 08:57, Sherry Sun wrote:
> > Since commit 824a0a02cd74 ("dmaengine: imx-sdma: Add multi fifo
> > support") adds the use of
> > dma_slave_config->peripheral_config/peripheral_size to sdma driver,
> > the client drivers like uart need to initialize the
> > peripheral_config/peripheral_size for sdma, otherwise, the random
> > value of local variable slave_config may cause unexpected
> peripheral_config and make sdma mess up.
> >
>=20
> If this a fix, please add a Fixes: tag. I am not sure it is though, see b=
elow.

Hi Ahmad, thanks for the comments.
I don't think this patch is a fix for a specific commit, so we don't need t=
he Fixes tag.

>=20
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  drivers/tty/serial/imx.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index
> > 522445a8f666..bb8c2a712e94 100644
> > --- a/drivers/tty/serial/imx.c
> > +++ b/drivers/tty/serial/imx.c
> > @@ -1320,6 +1320,8 @@ static int imx_uart_dma_init(struct imx_port
> > *sport)
>=20
> This function starts with
>=20
> struct dma_slave_config slave_config =3D {};
>=20
> >  	slave_config.src_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE;
> >  	/* one byte less than the watermark level to enable the aging timer
> */
> >  	slave_config.src_maxburst =3D RXTL_DMA - 1;
> > +	slave_config.peripheral_config =3D NULL;
> > +	slave_config.peripheral_size =3D 0;
>=20
> So these are already zero-initialized.

I am not sure actually, I think initialize a struct with {} cannot guarante=
e that all members are initialized to 0, it may depend on the compiler.

Best regards
Sherry

>=20
> >  	ret =3D dmaengine_slave_config(sport->dma_chan_rx, &slave_config);
> >  	if (ret) {
> >  		dev_err(dev, "error in RX dma configuration.\n"); @@ -
> 1346,6
> > +1348,8 @@ static int imx_uart_dma_init(struct imx_port *sport)
> >  	slave_config.dst_addr =3D sport->port.mapbase + URTX0;
> >  	slave_config.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_1_BYTE;
> >  	slave_config.dst_maxburst =3D TXTL_DMA;
> > +	slave_config.peripheral_config =3D NULL;
> > +	slave_config.peripheral_size =3D 0;
>=20
> Not sure if this is required. If preceding dmaengine_slave_config() indee=
d
> makes clearing necessary, you should note that in the commit message.
>=20