Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f44fc6d2-9d3b-2c37-15dd-d002dc09b7b0@gmail.com>
Date:   Wed, 3 Aug 2022 11:58:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 00/13] PM6125 regulator support
Content-Language: en-US
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mark Brown <broonie@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Robert Marko <robimarko@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
References: <20220731223736.1036286-1-iskren.chernev@gmail.com>
 <89469b0d-e6aa-4d60-c93c-a99256f65445@linaro.org>
From:   Iskren Chernev <iskren.chernev@gmail.com>
In-Reply-To: <89469b0d-e6aa-4d60-c93c-a99256f65445@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


>>
>> Iskren Chernev (13):
>>    dt-bindings: regulator: qcom_spmi: Improve formatting of if-then
>>      blocks
>>    dt-bindings: regulator: qcom_spmi: Document PM6125 PMIC
>>    dt-bindings: regulator: qcom_smd: Sort compatibles alphabetically
>>    dt-bindings: regulator: qcom_smd: Document PM6125 PMIC
>>    regulator: qcom_spmi: Add support for new regulator types
>>    regulator: qcom_spmi: Add support for HFSMPS regulator type
>>    regulator: qcom_spmi: Sort pmics alphabetically (part 1)
>>    regulator: qcom_spmi: Sort pmics alphabetically (part 2)
>>    regulator: qcom_spmi: Add PM6125 PMIC support
>>    regulator: qcom_smd: Sort pmics alphabetically (part 1)
>>    regulator: qcom_smd: Sort pmics alphabetically (part 2)
>>    regulator: qcom_smd: Sort pmics alphabetically (part 3)
>
> What is the reason for these part1/2 and part1/2/3 splits? I think you can collapse them into two respective patches, one sorting of spmi, another one sorting the smd regulators

The reason is that if I do collapse them the diff looks much more
complicated and it's not obvious that the sections are in-fact only moved.
I'm not sure how these are reviewed, but casually reading the patch will
not instill confidence.