Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 17:00:59 +0800 (CST)
From:   Guo Zhi <qtxuning1999@sjtu.edu.cn>
To:     jasowang <jasowang@redhat.com>, Michael Tsirkin <mst@redhat.com>
Cc:     eperezma <eperezma@redhat.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        sgarzare <sgarzare@redhat.com>
Message-ID: <2082515061.4772968.1659517259455.JavaMail.zimbra@sjtu.edu.cn>
In-Reply-To: <4185ee25-52af-8271-c4de-3824490fba6a@sjtu.edu.cn>
References: <20220709022745.21020-1-qtxuning1999@sjtu.edu.cn> <4185ee25-52af-8271-c4de-3824490fba6a@sjtu.edu.cn>
Subject: Re: [PATCH v3 0/4] virtio/virtio_test
MIME-Version: 1.0
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Thread-Topic: virtio/virtio_test
Thread-Index: sTk/JzG5xzfYKxwClrIRzy7E2UoPqA==
Precedence: bulk


----- Original Message -----
> From: "Guo Zhi" <qtxuning1999@sjtu.edu.cn>
> To: "jasowang" <jasowang@redhat.com>, "Michael Tsirkin" <mst@redhat.com>
> Cc: "eperezma" <eperezma@redhat.com>, "virtualization" <virtualization@lists.linux-foundation.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "sgarzare" <sgarzare@redhat.com>
> Sent: Thursday, July 21, 2022 7:55:31 PM
> Subject: Re: [PATCH v3 0/4] virtio/virtio_test

> On 2022/7/9 10:27, Guo Zhi wrote:
>> Original virtio_test only use add one descriptor for each io event, thus code of
>> descriptor chain and indirection have not been tested(one descriptor will not
>> use indirect feature even indirect feature has been specified). In fact it
>> would have not been possible for vhost_test to access to the indirect
>> descriptor table, because it's impossible for virtio_ring.c to allocate it.
>>
>> This series using descriptor chain and enable indirection feature. And through
>> gcov we find the code coverage has been improved(not high for virtio_ring.c
>> because virtio_test only test split virtqueue):
>>
>> +------------+-------------+-------------+
>> |            |virtio_test.c|virtio_ring.c|
>> +------------+-------------+-------------+
>> | original   |   72.32%    |   24.71%    |
>> +------------+-------------+-------------+
>> | current    |    75%      |   28.05%    |
>> +------------+-------------+-------------+
>>
>> Guo Zhi (4):
>>    virtio_test: kick vhost for a batch of descriptors
>>    virtio_test: use random length scatterlists to test descriptor chain
>>    virtio_test: enable indirection feature
>>    virtio_test: pregenerate random numbers
>>
>>   tools/virtio/virtio_test.c | 85 ++++++++++++++++++++++++++++++--------
>>   1 file changed, 68 insertions(+), 17 deletions(-)
>>
> Hi, the new version patch of virtio_test is waiting for review:)
> 
> Thanks.

Friendly ping for the patches:)
Thanks