Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <49bdec04ae962e25d9c9dbce61a8098beba1682e.camel@intel.com>
Subject: Re: [PATCH v5 1/22] x86/virt/tdx: Detect TDX during kernel boot
From:   Kai Huang <kai.huang@intel.com>
To:     "Wu, Binbin" <binbin.wu@linux.intel.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     seanjc@google.com, pbonzini@redhat.com, dave.hansen@intel.com,
        len.brown@intel.com, tony.luck@intel.com,
        rafael.j.wysocki@intel.com, reinette.chatre@intel.com,
        dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com,
        kirill.shutemov@linux.intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com,
        isaku.yamahata@intel.com
Date:   Wed, 03 Aug 2022 21:25:16 +1200
In-Reply-To: <7bd30975-fdcc-7d87-af4a-448b92bb6e02@linux.intel.com>
References: <cover.1655894131.git.kai.huang@intel.com>
         <062075b36150b119bf2d0a1262de973b0a2b11a7.1655894131.git.kai.huang@intel.com>
         <7bd30975-fdcc-7d87-af4a-448b92bb6e02@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-08-02 at 10:01 +0800, Wu, Binbin wrote:
> On 2022/6/22 19:15, Kai Huang wrote:
> > +	/*
> > +	 * TDX guarantees at least two TDX KeyIDs are configured by
> > +	 * BIOS, otherwise SEAMRR is disabled.  Invalid TDX private
> > +	 * range means kernel bug (TDX is broken).
> > +	 */
> > +	if (WARN_ON(!tdx_keyid_start || tdx_keyid_num < 2)) {
> Do you think it's better to define a meaningful macro instead of the=20
> number here and below?
> >=20

Personally I don't think we need a macro.  The comment already said "two", =
so=20
having a macro doesn't help readability here (and below).  But I am open on
this.

--=20
Thanks,
-Kai